[INFO] crate strider 0.1.3 is already in cache [INFO] extracting crate strider 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/strider/0.1.3 [INFO] extracting crate strider 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/strider/0.1.3 [INFO] validating manifest of strider-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of strider-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing strider-0.1.3 [INFO] finished frobbing strider-0.1.3 [INFO] frobbed toml for strider-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/strider/0.1.3/Cargo.toml [INFO] started frobbing strider-0.1.3 [INFO] finished frobbing strider-0.1.3 [INFO] frobbed toml for strider-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/strider/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting strider-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/strider/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e69abc95c3fa11f222e1e5627a9ff9d3691c3165ccf2eadaa4d51ba7ee3c3185 [INFO] running `"docker" "start" "-a" "e69abc95c3fa11f222e1e5627a9ff9d3691c3165ccf2eadaa4d51ba7ee3c3185"` [INFO] [stderr] Checking strider v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:149:18 [INFO] [stderr] | [INFO] [stderr] 149 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ help: try replacing the loop by: `output[..count].clone_from_slice(&self[..count])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: item `SliceRingImpl` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:213:1 [INFO] [stderr] | [INFO] [stderr] 213 | / impl SliceRingImpl { [INFO] [stderr] 214 | | /// creates an empty `SliceRingImpl`. [INFO] [stderr] 215 | | pub fn new() -> SliceRingImpl { [INFO] [stderr] 216 | | SliceRingImpl::with_capacity(INITIAL_CAPACITY) [INFO] [stderr] ... | [INFO] [stderr] 356 | | } [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SliceRingImpl` [INFO] [stderr] --> src/lib.rs:215:5 [INFO] [stderr] | [INFO] [stderr] 215 | / pub fn new() -> SliceRingImpl { [INFO] [stderr] 216 | | SliceRingImpl::with_capacity(INITIAL_CAPACITY) [INFO] [stderr] 217 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 174 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:149:18 [INFO] [stderr] | [INFO] [stderr] 149 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ help: try replacing the loop by: `output[..count].clone_from_slice(&self[..count])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: item `SliceRingImpl` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:213:1 [INFO] [stderr] | [INFO] [stderr] 213 | / impl SliceRingImpl { [INFO] [stderr] 214 | | /// creates an empty `SliceRingImpl`. [INFO] [stderr] 215 | | pub fn new() -> SliceRingImpl { [INFO] [stderr] 216 | | SliceRingImpl::with_capacity(INITIAL_CAPACITY) [INFO] [stderr] ... | [INFO] [stderr] 356 | | } [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SliceRingImpl` [INFO] [stderr] --> src/lib.rs:215:5 [INFO] [stderr] | [INFO] [stderr] 215 | / pub fn new() -> SliceRingImpl { [INFO] [stderr] 216 | | SliceRingImpl::with_capacity(INITIAL_CAPACITY) [INFO] [stderr] 217 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 174 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `strider`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> tests/lib.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | let mut input_buffer: &mut [u8] = &mut [0; 4]; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] ... [INFO] [stderr] 50 | test_string_windowing!(VecDeque::::new()); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> tests/lib.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut window_buffer: &mut [u8] = &mut [0; WINDOW_SIZE]; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] ... [INFO] [stderr] 50 | test_string_windowing!(VecDeque::::new()); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> tests/lib.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | let mut input_buffer: &mut [u8] = &mut [0; 4]; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] ... [INFO] [stderr] 54 | test_string_windowing!(SliceRingImpl::::new()); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> tests/lib.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut window_buffer: &mut [u8] = &mut [0; WINDOW_SIZE]; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] ... [INFO] [stderr] 54 | test_string_windowing!(SliceRingImpl::::new()); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/lib.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | output.write(window_buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 50 | test_string_windowing!(VecDeque::::new()); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/lib.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | output.write(window_buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 54 | test_string_windowing!(SliceRingImpl::::new()); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 69 [INFO] [stderr] --> tests/lib.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / fn test_slice_ring_deque() { [INFO] [stderr] 59 | | test_slice_ring!(VecDeque::::new()); [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 69 [INFO] [stderr] --> tests/lib.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / fn test_slice_ring_optimized() { [INFO] [stderr] 63 | | test_slice_ring!(SliceRingImpl::::new()); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `strider`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e69abc95c3fa11f222e1e5627a9ff9d3691c3165ccf2eadaa4d51ba7ee3c3185"` [INFO] running `"docker" "rm" "-f" "e69abc95c3fa11f222e1e5627a9ff9d3691c3165ccf2eadaa4d51ba7ee3c3185"` [INFO] [stdout] e69abc95c3fa11f222e1e5627a9ff9d3691c3165ccf2eadaa4d51ba7ee3c3185