[INFO] crate strided 0.2.9 is already in cache [INFO] extracting crate strided 0.2.9 into work/ex/clippy-test-run/sources/stable/reg/strided/0.2.9 [INFO] extracting crate strided 0.2.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/strided/0.2.9 [INFO] validating manifest of strided-0.2.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of strided-0.2.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing strided-0.2.9 [INFO] finished frobbing strided-0.2.9 [INFO] frobbed toml for strided-0.2.9 written to work/ex/clippy-test-run/sources/stable/reg/strided/0.2.9/Cargo.toml [INFO] started frobbing strided-0.2.9 [INFO] finished frobbing strided-0.2.9 [INFO] frobbed toml for strided-0.2.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/strided/0.2.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting strided-0.2.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/strided/0.2.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f82b74d78b70acdc84218bd4d5898db4b83e3cd8c7aea515331747e4bedd64e [INFO] running `"docker" "start" "-a" "6f82b74d78b70acdc84218bd4d5898db4b83e3cd8c7aea515331747e4bedd64e"` [INFO] [stderr] Checking strided v0.2.9 (/opt/crater/workdir) [INFO] [stderr] Checking num-bigint v0.2.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/base.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/base.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint `raw_pointer_derive` has been removed: `using derive with raw pointers is ok` [INFO] [stderr] --> src/base.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | #[allow(raw_pointer_derive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mut_.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imm.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/base.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | (ptr as *const u8).offset(stride as isize) as *const T [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ptr as *const u8).add(stride)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&'a T`) [INFO] [stderr] --> src/base.rs:222:40 [INFO] [stderr] | [INFO] [stderr] 222 | let ret = Some(mem::transmute::<_, $elem>(self.start)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.start` [INFO] [stderr] ... [INFO] [stderr] 265 | iterator!(Items -> &'a T); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`*const T`) to itself [INFO] [stderr] --> src/base.rs:223:38 [INFO] [stderr] | [INFO] [stderr] 223 | self.start = mem::transmute(step(self.start as *mut T, self.stride)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 265 | iterator!(Items -> &'a T); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`*const T`) to itself [INFO] [stderr] --> src/base.rs:244:36 [INFO] [stderr] | [INFO] [stderr] 244 | self.end = mem::transmute(step(self.end as *mut T, [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 245 | | 0usize.wrapping_sub(self.stride))); [INFO] [stderr] | |_________________________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 265 | iterator!(Items -> &'a T); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&'a T`) [INFO] [stderr] --> src/base.rs:246:30 [INFO] [stderr] | [INFO] [stderr] 246 | Some(mem::transmute::<_, $elem>(self.end)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.end` [INFO] [stderr] ... [INFO] [stderr] 265 | iterator!(Items -> &'a T); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&'a mut T`) [INFO] [stderr] --> src/base.rs:222:40 [INFO] [stderr] | [INFO] [stderr] 222 | let ret = Some(mem::transmute::<_, $elem>(self.start)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.start` [INFO] [stderr] ... [INFO] [stderr] 280 | iterator!(MutItems -> &'a mut T); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/base.rs:223:38 [INFO] [stderr] | [INFO] [stderr] 223 | self.start = mem::transmute(step(self.start as *mut T, self.stride)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `step(self.start as *mut T, self.stride) as *mut T` [INFO] [stderr] ... [INFO] [stderr] 280 | iterator!(MutItems -> &'a mut T); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/base.rs:244:36 [INFO] [stderr] | [INFO] [stderr] 244 | self.end = mem::transmute(step(self.end as *mut T, [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 245 | | 0usize.wrapping_sub(self.stride))); [INFO] [stderr] | |_________________________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 280 | iterator!(MutItems -> &'a mut T); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 244 | self.end = step(self.end as *mut T, [INFO] [stderr] 245 | 0usize.wrapping_sub(self.stride)) as *mut T; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&'a mut T`) [INFO] [stderr] --> src/base.rs:246:30 [INFO] [stderr] | [INFO] [stderr] 246 | Some(mem::transmute::<_, $elem>(self.end)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.end` [INFO] [stderr] ... [INFO] [stderr] 280 | iterator!(MutItems -> &'a mut T); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: item `mut_::Stride<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/mut_.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / impl<'a, T> Stride<'a, T> { [INFO] [stderr] 39 | | #[inline(always)] [INFO] [stderr] 40 | | fn new_raw(base: Base<'a, T>) -> Stride<'a, T> { [INFO] [stderr] 41 | | Stride { [INFO] [stderr] ... | [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn reborrow<'b>(&'b mut self) -> Stride<'b, T> { [INFO] [stderr] 85 | | Stride::new_raw(self.base) [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn get_mut<'b>(&'b mut self, n: usize) -> Option<&'b mut T> { [INFO] [stderr] 121 | | self.base.get_mut(n).map(|r| &mut *r) [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / pub fn iter_mut<'b>(&'b mut self) -> ::MutItems<'b, T> { [INFO] [stderr] 131 | | self.reborrow().into_iter() [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/mut_.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / pub fn into_iter(mut self) -> ::MutItems<'a, T> { [INFO] [stderr] 141 | | self.base.iter_mut() [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / fn index<'b>(&'b self, n: usize) -> &'b T { [INFO] [stderr] 193 | | & (**self)[n] [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / fn index_mut<'b>(&'b mut self, n: usize) -> &'b mut T { [INFO] [stderr] 198 | | self.get_mut(n).expect("Stride.index_mut: index out of bounds") [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/mut_.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const mut_::Stride<'a, T> as *const imm::Stride<'a, T>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: item `imm::Stride<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/imm.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / impl<'a, T> Stride<'a, T> { [INFO] [stderr] 29 | | #[inline(always)] [INFO] [stderr] 30 | | fn new_raw(base: Base<'a, T>) -> Stride<'a, T> { [INFO] [stderr] 31 | | Stride { [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/imm.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / fn index<'b>(&'b self, n: usize) -> &'b T { [INFO] [stderr] 177 | | self.get(n).expect("Stride.index: index out of bounds") [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/base.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/base.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint `raw_pointer_derive` has been removed: `using derive with raw pointers is ok` [INFO] [stderr] --> src/base.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | #[allow(raw_pointer_derive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mut_.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imm.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/common_tests.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `$input[i]` [INFO] [stderr] | [INFO] [stderr] ::: src/mut_.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 234 | | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/common_tests.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `$input[i]` [INFO] [stderr] | [INFO] [stderr] ::: src/mut_.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 234 | | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/common_tests.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `$input[i]` [INFO] [stderr] | [INFO] [stderr] ::: src/mut_.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 234 | | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/common_tests.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `$input[i]` [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/common_tests.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `$input[i]` [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/common_tests.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `$input[i]` [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/base.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | (ptr as *const u8).offset(stride as isize) as *const T [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ptr as *const u8).add(stride)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&'a T`) [INFO] [stderr] --> src/base.rs:222:40 [INFO] [stderr] | [INFO] [stderr] 222 | let ret = Some(mem::transmute::<_, $elem>(self.start)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.start` [INFO] [stderr] ... [INFO] [stderr] 265 | iterator!(Items -> &'a T); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`*const T`) to itself [INFO] [stderr] --> src/base.rs:223:38 [INFO] [stderr] | [INFO] [stderr] 223 | self.start = mem::transmute(step(self.start as *mut T, self.stride)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 265 | iterator!(Items -> &'a T); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`*const T`) to itself [INFO] [stderr] --> src/base.rs:244:36 [INFO] [stderr] | [INFO] [stderr] 244 | self.end = mem::transmute(step(self.end as *mut T, [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 245 | | 0usize.wrapping_sub(self.stride))); [INFO] [stderr] | |_________________________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 265 | iterator!(Items -> &'a T); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&'a T`) [INFO] [stderr] --> src/base.rs:246:30 [INFO] [stderr] | [INFO] [stderr] 246 | Some(mem::transmute::<_, $elem>(self.end)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.end` [INFO] [stderr] ... [INFO] [stderr] 265 | iterator!(Items -> &'a T); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&'a mut T`) [INFO] [stderr] --> src/base.rs:222:40 [INFO] [stderr] | [INFO] [stderr] 222 | let ret = Some(mem::transmute::<_, $elem>(self.start)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.start` [INFO] [stderr] ... [INFO] [stderr] 280 | iterator!(MutItems -> &'a mut T); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/base.rs:223:38 [INFO] [stderr] | [INFO] [stderr] 223 | self.start = mem::transmute(step(self.start as *mut T, self.stride)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `step(self.start as *mut T, self.stride) as *mut T` [INFO] [stderr] ... [INFO] [stderr] 280 | iterator!(MutItems -> &'a mut T); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/base.rs:244:36 [INFO] [stderr] | [INFO] [stderr] 244 | self.end = mem::transmute(step(self.end as *mut T, [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 245 | | 0usize.wrapping_sub(self.stride))); [INFO] [stderr] | |_________________________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 280 | iterator!(MutItems -> &'a mut T); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 244 | self.end = step(self.end as *mut T, [INFO] [stderr] 245 | 0usize.wrapping_sub(self.stride)) as *mut T; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&'a mut T`) [INFO] [stderr] --> src/base.rs:246:30 [INFO] [stderr] | [INFO] [stderr] 246 | Some(mem::transmute::<_, $elem>(self.end)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.end` [INFO] [stderr] ... [INFO] [stderr] 280 | iterator!(MutItems -> &'a mut T); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: item `mut_::Stride<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/mut_.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / impl<'a, T> Stride<'a, T> { [INFO] [stderr] 39 | | #[inline(always)] [INFO] [stderr] 40 | | fn new_raw(base: Base<'a, T>) -> Stride<'a, T> { [INFO] [stderr] 41 | | Stride { [INFO] [stderr] ... | [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn reborrow<'b>(&'b mut self) -> Stride<'b, T> { [INFO] [stderr] 85 | | Stride::new_raw(self.base) [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn get_mut<'b>(&'b mut self, n: usize) -> Option<&'b mut T> { [INFO] [stderr] 121 | | self.base.get_mut(n).map(|r| &mut *r) [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / pub fn iter_mut<'b>(&'b mut self) -> ::MutItems<'b, T> { [INFO] [stderr] 131 | | self.reborrow().into_iter() [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/mut_.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / pub fn into_iter(mut self) -> ::MutItems<'a, T> { [INFO] [stderr] 141 | | self.base.iter_mut() [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / fn index<'b>(&'b self, n: usize) -> &'b T { [INFO] [stderr] 193 | | & (**self)[n] [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mut_.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / fn index_mut<'b>(&'b mut self, n: usize) -> &'b mut T { [INFO] [stderr] 198 | | self.get_mut(n).expect("Stride.index_mut: index out of bounds") [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/mut_.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const mut_::Stride<'a, T> as *const imm::Stride<'a, T>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common_tests.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match expected { [INFO] [stderr] 62 | | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] 63 | | None => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/mut_.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 234 | | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Some(x) = expected { make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 62 | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common_tests.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match expected { [INFO] [stderr] 62 | | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] 63 | | None => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/mut_.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 234 | | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Some(x) = expected { make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 62 | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common_tests.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match expected { [INFO] [stderr] 62 | | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] 63 | | None => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/mut_.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 234 | | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Some(x) = expected { make_tests!(substrides2_mut, substrides_mut, [INFO] [stderr] 62 | slice_mut, slice_to_mut, slice_from_mut, split_at_mut, get_mut, iter_mut, mut); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `imm::Stride<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/imm.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / impl<'a, T> Stride<'a, T> { [INFO] [stderr] 29 | | #[inline(always)] [INFO] [stderr] 30 | | fn new_raw(base: Base<'a, T>) -> Stride<'a, T> { [INFO] [stderr] 31 | | Stride { [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/imm.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / fn reborrow<'b>(&'b self) -> Stride<'b, T> { [INFO] [stderr] 76 | | // only exists to work with tests. [INFO] [stderr] 77 | | *self [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/imm.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / fn index<'b>(&'b self, n: usize) -> &'b T { [INFO] [stderr] 177 | | self.get(n).expect("Stride.index: index out of bounds") [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/common_tests.rs:122:52 [INFO] [stderr] | [INFO] [stderr] 122 | assert_eq!(format!("{:?}", Stride::new(&mut [1u16, 2, 3, 4, 5]).$substrides2().0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/common_tests.rs:124:52 [INFO] [stderr] | [INFO] [stderr] 124 | assert_eq!(format!("{:?}", Stride::new(&mut [1u16, 2, 3]).$substrides2().0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/common_tests.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(format!("{:?}", Stride::new(&mut [1u16]).$substrides2().0), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `>::new` doesn't need a mutable reference [INFO] [stderr] --> src/common_tests.rs:128:59 [INFO] [stderr] | [INFO] [stderr] 128 | assert_eq!(format!("{:?}", Stride::::new(&mut []).$substrides2().0), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common_tests.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match expected { [INFO] [stderr] 62 | | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] 63 | | None => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = expected { make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); }` [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common_tests.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match expected { [INFO] [stderr] 62 | | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] 63 | | None => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = expected { make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); }` [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common_tests.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match expected { [INFO] [stderr] 62 | | Some(x) => assert_eq!(*(&$($mut_)* $input[i]), *x), [INFO] [stderr] 63 | | None => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = expected { make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); }` [INFO] [stderr] | [INFO] [stderr] ::: src/imm.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | make_tests!(substrides2, substrides, slice, slice_to, slice_from, split_at, get, iter, ); [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.60s [INFO] running `"docker" "inspect" "6f82b74d78b70acdc84218bd4d5898db4b83e3cd8c7aea515331747e4bedd64e"` [INFO] running `"docker" "rm" "-f" "6f82b74d78b70acdc84218bd4d5898db4b83e3cd8c7aea515331747e4bedd64e"` [INFO] [stdout] 6f82b74d78b70acdc84218bd4d5898db4b83e3cd8c7aea515331747e4bedd64e