[INFO] crate strfmt 0.1.6 is already in cache [INFO] extracting crate strfmt 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/strfmt/0.1.6 [INFO] extracting crate strfmt 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/strfmt/0.1.6 [INFO] validating manifest of strfmt-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of strfmt-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing strfmt-0.1.6 [INFO] finished frobbing strfmt-0.1.6 [INFO] frobbed toml for strfmt-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/strfmt/0.1.6/Cargo.toml [INFO] started frobbing strfmt-0.1.6 [INFO] finished frobbing strfmt-0.1.6 [INFO] frobbed toml for strfmt-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/strfmt/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting strfmt-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/strfmt/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4fd4937ff35ca0cb440d1c9e7be342660e56370193541717559ecc60dab0018 [INFO] running `"docker" "start" "-a" "e4fd4937ff35ca0cb440d1c9e7be342660e56370193541717559ecc60dab0018"` [INFO] [stderr] Checking strfmt v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | buff: buff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `buff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | buff: buff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `buff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/strfmt.rs:143:37 [INFO] [stderr] | [INFO] [stderr] 143 | vars.insert("long".to_string(), 100000); // len=10 [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/formatter.rs:155:58 [INFO] [stderr] | [INFO] [stderr] 155 | if !fill_specified && end - pos >= 1 && rest[pos] == '0' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fmtnum.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | if x >= (0 as $t) && self.sign_plus() { [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | fmtfloat!(f32 f64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:26:53 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn strfmt(fmtstr: &str, vars: &HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 26 | pub fn strfmt(fmtstr: &str, vars: &HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/strfmt.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | fn run_tests(values: &Vec<(&str, &str, u8)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str, u8)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tests/strfmt.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | failure = !(expected == result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `expected != result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the `c @ _` pattern can be written as just `c` [INFO] [stderr] --> src/tests/strfmt.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | c@_ => panic!("error code {} DNE", c), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/formatter.rs:155:58 [INFO] [stderr] | [INFO] [stderr] 155 | if !fill_specified && end - pos >= 1 && rest[pos] == '0' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fmtnum.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | if x >= (0 as $t) && self.sign_plus() { [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | fmtfloat!(f32 f64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:26:53 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn strfmt(fmtstr: &str, vars: &HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 26 | pub fn strfmt(fmtstr: &str, vars: &HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.30s [INFO] running `"docker" "inspect" "e4fd4937ff35ca0cb440d1c9e7be342660e56370193541717559ecc60dab0018"` [INFO] running `"docker" "rm" "-f" "e4fd4937ff35ca0cb440d1c9e7be342660e56370193541717559ecc60dab0018"` [INFO] [stdout] e4fd4937ff35ca0cb440d1c9e7be342660e56370193541717559ecc60dab0018