[INFO] crate streaming-median 0.1.0 is already in cache [INFO] extracting crate streaming-median 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/streaming-median/0.1.0 [INFO] extracting crate streaming-median 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/streaming-median/0.1.0 [INFO] validating manifest of streaming-median-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of streaming-median-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing streaming-median-0.1.0 [INFO] finished frobbing streaming-median-0.1.0 [INFO] frobbed toml for streaming-median-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/streaming-median/0.1.0/Cargo.toml [INFO] started frobbing streaming-median-0.1.0 [INFO] finished frobbing streaming-median-0.1.0 [INFO] frobbed toml for streaming-median-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/streaming-median/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting streaming-median-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/streaming-median/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9659cf6b01a728231e6d0c3231c2d75279cf5780363afeb0c674f567ed8661ed [INFO] running `"docker" "start" "-a" "9659cf6b01a728231e6d0c3231c2d75279cf5780363afeb0c674f567ed8661ed"` [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking xorshift v0.1.3 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking quickcheck v0.7.2 [INFO] [stderr] Checking streaming-median v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | self.sorted[insert_index + 1..remove_index + 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `insert_index + 1..=remove_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/lib.rs:208:34 [INFO] [stderr] | [INFO] [stderr] 208 | const NANOS_PER_MILLI: u32 = 1000_000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | self.sorted[insert_index + 1..remove_index + 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `insert_index + 1..=remove_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | let nanos_part = d.subsec_nanos() / NANOS_PER_MILLI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `d.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:216:21 [INFO] [stderr] | [INFO] [stderr] 216 | secs_part + nanos_part as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(nanos_part)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.20s [INFO] running `"docker" "inspect" "9659cf6b01a728231e6d0c3231c2d75279cf5780363afeb0c674f567ed8661ed"` [INFO] running `"docker" "rm" "-f" "9659cf6b01a728231e6d0c3231c2d75279cf5780363afeb0c674f567ed8661ed"` [INFO] [stdout] 9659cf6b01a728231e6d0c3231c2d75279cf5780363afeb0c674f567ed8661ed