[INFO] crate stm-core 0.4.0 is already in cache
[INFO] extracting crate stm-core 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/stm-core/0.4.0
[INFO] extracting crate stm-core 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stm-core/0.4.0
[INFO] validating manifest of stm-core-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of stm-core-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing stm-core-0.4.0
[INFO] finished frobbing stm-core-0.4.0
[INFO] frobbed toml for stm-core-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/stm-core/0.4.0/Cargo.toml
[INFO] started frobbing stm-core-0.4.0
[INFO] finished frobbing stm-core-0.4.0
[INFO] frobbed toml for stm-core-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stm-core/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting stm-core-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stm-core/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c82aa60f6fc372bbfe789f5845722d808f8b19b6f6f33f8b07839aeda7663c28
[INFO] running `"docker" "start" "-a" "c82aa60f6fc372bbfe789f5845722d808f8b19b6f6f33f8b07839aeda7663c28"`
[INFO] [stderr]     Checking parking_lot v0.5.5
[INFO] [stderr]     Checking stm-core v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]   --> src/transaction/control_block.rs:32:48
[INFO] [stderr]    |
[INFO] [stderr] 32 |     #[cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))]
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]   --> src/transaction/control_block.rs:32:48
[INFO] [stderr]    |
[INFO] [stderr] 32 |     #[cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))]
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]   --> src/transaction/control_block.rs:32:48
[INFO] [stderr]    |
[INFO] [stderr] 32 |     #[cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))]
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `transaction::control_block::ControlBlock`
[INFO] [stderr]   --> src/transaction/control_block.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn new() -> ControlBlock {
[INFO] [stderr] 36 | |         ControlBlock {
[INFO] [stderr] 37 | |             thread: thread::current(),
[INFO] [stderr] 38 | |             blocked: AtomicBool::new(true),
[INFO] [stderr] 39 | |         }
[INFO] [stderr] 40 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 31 | impl Default for transaction::control_block::ControlBlock {
[INFO] [stderr] 32 |     fn default() -> Self {
[INFO] [stderr] 33 |         Self::new()
[INFO] [stderr] 34 |     }
[INFO] [stderr] 35 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/transaction/log_var.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match &*self {
[INFO] [stderr] 59 | |             // Use last read value or get written one
[INFO] [stderr] 60 | |             &Read(ref v) | &Write(ref v) | &ReadWrite(_,ref v) => { 
[INFO] [stderr] 61 | |                 return v.clone();
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |             }
[INFO] [stderr] 74 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *self {
[INFO] [stderr] 59 |             // Use last read value or get written one
[INFO] [stderr] 60 |             Read(ref v) | Write(ref v) | ReadWrite(_,ref v) => { 
[INFO] [stderr] 61 |                 return v.clone();
[INFO] [stderr] 62 |             }
[INFO] [stderr] 63 | 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]   --> src/transaction/control_block.rs:32:48
[INFO] [stderr]    |
[INFO] [stderr] 32 |     #[cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))]
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive`
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `transaction::control_block::ControlBlock`
[INFO] [stderr]   --> src/transaction/control_block.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn new() -> ControlBlock {
[INFO] [stderr] 36 | |         ControlBlock {
[INFO] [stderr] 37 | |             thread: thread::current(),
[INFO] [stderr] 38 | |             blocked: AtomicBool::new(true),
[INFO] [stderr] 39 | |         }
[INFO] [stderr] 40 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 31 | impl Default for transaction::control_block::ControlBlock {
[INFO] [stderr] 32 |     fn default() -> Self {
[INFO] [stderr] 33 |         Self::new()
[INFO] [stderr] 34 |     }
[INFO] [stderr] 35 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/transaction/log_var.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match &*self {
[INFO] [stderr] 59 | |             // Use last read value or get written one
[INFO] [stderr] 60 | |             &Read(ref v) | &Write(ref v) | &ReadWrite(_,ref v) => { 
[INFO] [stderr] 61 | |                 return v.clone();
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |             }
[INFO] [stderr] 74 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *self {
[INFO] [stderr] 59 |             // Use last read value or get written one
[INFO] [stderr] 60 |             Read(ref v) | Write(ref v) | ReadWrite(_,ref v) => { 
[INFO] [stderr] 61 |                 return v.clone();
[INFO] [stderr] 62 |             }
[INFO] [stderr] 63 | 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.35s
[INFO] running `"docker" "inspect" "c82aa60f6fc372bbfe789f5845722d808f8b19b6f6f33f8b07839aeda7663c28"`
[INFO] running `"docker" "rm" "-f" "c82aa60f6fc372bbfe789f5845722d808f8b19b6f6f33f8b07839aeda7663c28"`
[INFO] [stdout] c82aa60f6fc372bbfe789f5845722d808f8b19b6f6f33f8b07839aeda7663c28