[INFO] crate stlv 0.1.2 is already in cache [INFO] extracting crate stlv 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/stlv/0.1.2 [INFO] extracting crate stlv 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stlv/0.1.2 [INFO] validating manifest of stlv-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stlv-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stlv-0.1.2 [INFO] finished frobbing stlv-0.1.2 [INFO] frobbed toml for stlv-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/stlv/0.1.2/Cargo.toml [INFO] started frobbing stlv-0.1.2 [INFO] finished frobbing stlv-0.1.2 [INFO] frobbed toml for stlv-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stlv/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stlv-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stlv/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8dc483bab8faffcb7af1940ee756b8ebb21e7ff2ea4cc229e703cabe4ad7cc00 [INFO] running `"docker" "start" "-a" "8dc483bab8faffcb7af1940ee756b8ebb21e7ff2ea4cc229e703cabe4ad7cc00"` [INFO] [stderr] Checking stlv v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning[E0170]: pattern binding `Binary` is named the same as one of the variants of the type `parser::FileFormat` [INFO] [stderr] --> src/lib.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Binary) => println!("Pass: Binary format"), [INFO] [stderr] | ^^^^^^ help: to match on the variant, qualify the path: `parser::FileFormat::Binary` [INFO] [stderr] [INFO] [stderr] warning[E0170]: pattern binding `Text` is named the same as one of the variants of the type `parser::FileFormat` [INFO] [stderr] --> src/lib.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Text) => println!("Pass: Text format"), [INFO] [stderr] | ^^^^ help: to match on the variant, qualify the path: `parser::FileFormat::Text` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `Binary` [INFO] [stderr] --> src/lib.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Binary) => println!("Pass: Binary format"), [INFO] [stderr] | ^^^^^^ help: consider using `_Binary` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `Text` [INFO] [stderr] --> src/lib.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Text) => println!("Pass: Text format"), [INFO] [stderr] | ^^^^ help: consider using `_Text` instead [INFO] [stderr] [INFO] [stderr] warning: constant `bin_stl_file` should have an upper case name such as `BIN_STL_FILE` [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | const bin_stl_file: &str = "/home/vishpat/Downloads/HalfDonut-binary.stl"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant `txt_stl_file` should have an upper case name such as `TXT_STL_FILE` [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | const txt_stl_file: &str = "/home/vishpat/Downloads/HalfDonut.stl"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Binary` should have a snake case name such as `binary` [INFO] [stderr] --> src/lib.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Binary) => println!("Pass: Binary format"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `Text` should have a snake case name such as `text` [INFO] [stderr] --> src/lib.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Text) => println!("Pass: Text format"), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in (*model).iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:33:33 [INFO] [stderr] | [INFO] [stderr] 33 | for triangle in (*model).iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in (*model).iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | for triangle in (*model).iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "8dc483bab8faffcb7af1940ee756b8ebb21e7ff2ea4cc229e703cabe4ad7cc00"` [INFO] running `"docker" "rm" "-f" "8dc483bab8faffcb7af1940ee756b8ebb21e7ff2ea4cc229e703cabe4ad7cc00"` [INFO] [stdout] 8dc483bab8faffcb7af1940ee756b8ebb21e7ff2ea4cc229e703cabe4ad7cc00