[INFO] crate stijl 0.5.2 is already in cache [INFO] extracting crate stijl 0.5.2 into work/ex/clippy-test-run/sources/stable/reg/stijl/0.5.2 [INFO] extracting crate stijl 0.5.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stijl/0.5.2 [INFO] validating manifest of stijl-0.5.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stijl-0.5.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stijl-0.5.2 [INFO] finished frobbing stijl-0.5.2 [INFO] frobbed toml for stijl-0.5.2 written to work/ex/clippy-test-run/sources/stable/reg/stijl/0.5.2/Cargo.toml [INFO] started frobbing stijl-0.5.2 [INFO] finished frobbing stijl-0.5.2 [INFO] frobbed toml for stijl-0.5.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stijl/0.5.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stijl-0.5.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stijl/0.5.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d925abc95cfe8b772f92278fca85689a212ea474b5e652f4a35cff22d04330f5 [INFO] running `"docker" "start" "-a" "d925abc95cfe8b772f92278fca85689a212ea474b5e652f4a35cff22d04330f5"` [INFO] [stderr] Checking tinf v0.14.0 [INFO] [stderr] Checking tvis_util v0.5.2 [INFO] [stderr] Checking stijl v0.5.2 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:114:45 [INFO] [stderr] | [INFO] [stderr] 114 | #![cfg_attr(feature = "cargo-clippy", allow(match_same_arms))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:115:45 [INFO] [stderr] | [INFO] [stderr] 115 | #![cfg_attr(feature = "cargo-clippy", allow(match_bool))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::match_bool` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/term.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:114:45 [INFO] [stderr] | [INFO] [stderr] 114 | #![cfg_attr(feature = "cargo-clippy", allow(match_same_arms))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:115:45 [INFO] [stderr] | [INFO] [stderr] 115 | #![cfg_attr(feature = "cargo-clippy", allow(match_bool))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::match_bool` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/term.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:114:45 [INFO] [stderr] | [INFO] [stderr] 114 | #![cfg_attr(feature = "cargo-clippy", allow(match_same_arms))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:114:45 [INFO] [stderr] | [INFO] [stderr] 114 | #![cfg_attr(feature = "cargo-clippy", allow(match_same_arms))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/term.rs:248:8 [INFO] [stderr] | [INFO] [stderr] 248 | if !desc[cap::bold].is_empty() && !(color && (ncv & 0x20 != 0)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(color && (ncv & 0x20 != 0) || desc[cap::bold].is_empty())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/term.rs:251:8 [INFO] [stderr] | [INFO] [stderr] 251 | if !desc[cap::smul].is_empty() && !(color && (ncv & 0x02 != 0)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(color && (ncv & 0x02 != 0) || desc[cap::smul].is_empty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/term.rs:254:8 [INFO] [stderr] | [INFO] [stderr] 254 | if !desc[cap::smso].is_empty() && !(color && (ncv & 0x01 != 0)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(color && (ncv & 0x01 != 0) || desc[cap::smso].is_empty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/term.rs:248:8 [INFO] [stderr] | [INFO] [stderr] 248 | if !desc[cap::bold].is_empty() && !(color && (ncv & 0x20 != 0)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(color && (ncv & 0x20 != 0) || desc[cap::bold].is_empty())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/term.rs:251:8 [INFO] [stderr] | [INFO] [stderr] 251 | if !desc[cap::smul].is_empty() && !(color && (ncv & 0x02 != 0)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(color && (ncv & 0x02 != 0) || desc[cap::smul].is_empty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/term.rs:254:8 [INFO] [stderr] | [INFO] [stderr] 254 | if !desc[cap::smso].is_empty() && !(color && (ncv & 0x01 != 0)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(color && (ncv & 0x01 != 0) || desc[cap::smso].is_empty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.23s [INFO] running `"docker" "inspect" "d925abc95cfe8b772f92278fca85689a212ea474b5e652f4a35cff22d04330f5"` [INFO] running `"docker" "rm" "-f" "d925abc95cfe8b772f92278fca85689a212ea474b5e652f4a35cff22d04330f5"` [INFO] [stdout] d925abc95cfe8b772f92278fca85689a212ea474b5e652f4a35cff22d04330f5