[INFO] crate sterling 1.0.1 is already in cache [INFO] extracting crate sterling 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/sterling/1.0.1 [INFO] extracting crate sterling 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sterling/1.0.1 [INFO] validating manifest of sterling-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sterling-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sterling-1.0.1 [INFO] finished frobbing sterling-1.0.1 [INFO] frobbed toml for sterling-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/sterling/1.0.1/Cargo.toml [INFO] started frobbing sterling-1.0.1 [INFO] finished frobbing sterling-1.0.1 [INFO] frobbed toml for sterling-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sterling/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sterling-1.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sterling/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5734baa62bbd1cac4fd4d2b6cf096c39e15d8602e3acb9aed2aaf2f684ebc3ab [INFO] running `"docker" "start" "-a" "5734baa62bbd1cac4fd4d2b6cf096c39e15d8602e3acb9aed2aaf2f684ebc3ab"` [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking lazysort v0.2.1 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking sterling v1.0.1 (/opt/crater/workdir) [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/convert.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | match (¤cy).plural { [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `currency.plural` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/convert.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | let rate: &usize = rates.get(&capture[2]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rates[&capture[2]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/convert.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | val = val % currency.rate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= currency.rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | get_rates(currencies.as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `currencies` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | let is_sub_command = match matches.subcommand_name() { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 59 | | Some(_) => true, [INFO] [stderr] 60 | | None => false, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_____________________^ help: try this: `matches.subcommand_name().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/convert.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | match (¤cy).plural { [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `currency.plural` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/convert.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | let rate: &usize = rates.get(&capture[2]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rates[&capture[2]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/convert.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | val = val % currency.rate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= currency.rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | get_rates(currencies.as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `currencies` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | let is_sub_command = match matches.subcommand_name() { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 59 | | Some(_) => true, [INFO] [stderr] 60 | | None => false, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_____________________^ help: try this: `matches.subcommand_name().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.14s [INFO] running `"docker" "inspect" "5734baa62bbd1cac4fd4d2b6cf096c39e15d8602e3acb9aed2aaf2f684ebc3ab"` [INFO] running `"docker" "rm" "-f" "5734baa62bbd1cac4fd4d2b6cf096c39e15d8602e3acb9aed2aaf2f684ebc3ab"` [INFO] [stdout] 5734baa62bbd1cac4fd4d2b6cf096c39e15d8602e3acb9aed2aaf2f684ebc3ab