[INFO] crate stegray 0.0.1 is already in cache [INFO] extracting crate stegray 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/stegray/0.0.1 [INFO] extracting crate stegray 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stegray/0.0.1 [INFO] validating manifest of stegray-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stegray-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stegray-0.0.1 [INFO] finished frobbing stegray-0.0.1 [INFO] frobbed toml for stegray-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/stegray/0.0.1/Cargo.toml [INFO] started frobbing stegray-0.0.1 [INFO] finished frobbing stegray-0.0.1 [INFO] frobbed toml for stegray-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stegray/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stegray-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stegray/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46b3e40cf34ca54ed4420fc1b185cd6bba8ab3d3bf83a3e9c0b60b7547fe2fa1 [INFO] running `"docker" "start" "-a" "46b3e40cf34ca54ed4420fc1b185cd6bba8ab3d3bf83a3e9c0b60b7547fe2fa1"` [INFO] [stderr] Checking stegray v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | shasum: shasum, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shasum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | shasum: shasum, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shasum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_helpers.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return [b1, b2, b3, b4]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[b1, b2, b3, b4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_helpers.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | (((*four_bytes)[0] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*four_bytes)[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_helpers.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | + (((*four_bytes)[1] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*four_bytes)[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_helpers.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | + (((*four_bytes)[2] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*four_bytes)[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((*four_bytes)[3] as u32)` [INFO] [stderr] --> src/bit_helpers.rs:13:11 [INFO] [stderr] | [INFO] [stderr] 13 | + (((*four_bytes)[3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_helpers.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | + (((*four_bytes)[3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*four_bytes)[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/files/mod.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn get_file_string<'a>(path: &'a str) -> String { [INFO] [stderr] 46 | | let mut file = match File::open(&path) { [INFO] [stderr] 47 | | Err(why) => panic!("Couldn't open file because: {}", why.description()), [INFO] [stderr] 48 | | Ok(file) => file, [INFO] [stderr] ... | [INFO] [stderr] 55 | | contents [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_helpers.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return [b1, b2, b3, b4]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[b1, b2, b3, b4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_helpers.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | transform_u32_to_u8_array(120002004_u32), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `120_002_004_u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_helpers.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | 120002004_u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `120_002_004_u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_helpers.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | (((*four_bytes)[0] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*four_bytes)[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_helpers.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | + (((*four_bytes)[1] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*four_bytes)[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_helpers.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | + (((*four_bytes)[2] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*four_bytes)[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((*four_bytes)[3] as u32)` [INFO] [stderr] --> src/bit_helpers.rs:13:11 [INFO] [stderr] | [INFO] [stderr] 13 | + (((*four_bytes)[3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_helpers.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | + (((*four_bytes)[3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*four_bytes)[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/files/mod.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn get_file_string<'a>(path: &'a str) -> String { [INFO] [stderr] 46 | | let mut file = match File::open(&path) { [INFO] [stderr] 47 | | Err(why) => panic!("Couldn't open file because: {}", why.description()), [INFO] [stderr] 48 | | Ok(file) => file, [INFO] [stderr] ... | [INFO] [stderr] 55 | | contents [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "46b3e40cf34ca54ed4420fc1b185cd6bba8ab3d3bf83a3e9c0b60b7547fe2fa1"` [INFO] running `"docker" "rm" "-f" "46b3e40cf34ca54ed4420fc1b185cd6bba8ab3d3bf83a3e9c0b60b7547fe2fa1"` [INFO] [stdout] 46b3e40cf34ca54ed4420fc1b185cd6bba8ab3d3bf83a3e9c0b60b7547fe2fa1