[INFO] crate steganography 1.0.1 is already in cache
[INFO] extracting crate steganography 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/steganography/1.0.1
[INFO] extracting crate steganography 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/steganography/1.0.1
[INFO] validating manifest of steganography-1.0.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of steganography-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing steganography-1.0.1
[INFO] finished frobbing steganography-1.0.1
[INFO] frobbed toml for steganography-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/steganography/1.0.1/Cargo.toml
[INFO] started frobbing steganography-1.0.1
[INFO] finished frobbing steganography-1.0.1
[INFO] frobbed toml for steganography-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/steganography/1.0.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting steganography-1.0.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/steganography/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c205aaed6a84e6f874750b7977393eca8716c65302c19acd9b6e52ccd8d05961
[INFO] running `"docker" "start" "-a" "c205aaed6a84e6f874750b7977393eca8716c65302c19acd9b6e52ccd8d05961"`
[INFO] [stderr]     Checking png v0.12.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking steganography v1.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/encoder.rs:45:3
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return out;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `out`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/util.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     img
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/util.rs:41:15
[INFO] [stderr]    |
[INFO] [stderr] 41 |     let img = open(&Path::new(&filename)).unwrap();
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/encoder.rs:55:4
[INFO] [stderr]    |
[INFO] [stderr] 55 |             pixels = pixels + padding;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixels += padding`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoder.rs:60:33
[INFO] [stderr]    |
[INFO] [stderr] 60 |         let height = (pixels as f64 / width as f64).ceil() as u32;
[INFO] [stderr]    |                                       ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/encoder.rs:67:24
[INFO] [stderr]    |
[INFO] [stderr] 67 |             let mut out_pixel = tmp_pixel.clone();
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tmp_pixel`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/util.rs:12:30
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub fn str_to_bytes<'a>(msg: &'a String) -> &'a [u8] {
[INFO] [stderr]    |                              ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/util.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | / pub fn str_to_bytes<'a>(msg: &'a String) -> &'a [u8] {
[INFO] [stderr] 13 | |     msg.as_bytes()
[INFO] [stderr] 14 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/util.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn file_to_bytes<'a>(mut file: File) -> Vec<u8> {
[INFO] [stderr]    |                      ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/util.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     let _ = img.save(out_path).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/encoder.rs:45:3
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return out;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `out`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/util.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     img
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/util.rs:41:15
[INFO] [stderr]    |
[INFO] [stderr] 41 |     let img = open(&Path::new(&filename)).unwrap();
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/encoder.rs:55:4
[INFO] [stderr]    |
[INFO] [stderr] 55 |             pixels = pixels + padding;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixels += padding`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoder.rs:60:33
[INFO] [stderr]    |
[INFO] [stderr] 60 |         let height = (pixels as f64 / width as f64).ceil() as u32;
[INFO] [stderr]    |                                       ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/encoder.rs:67:24
[INFO] [stderr]    |
[INFO] [stderr] 67 |             let mut out_pixel = tmp_pixel.clone();
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tmp_pixel`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/util.rs:12:30
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub fn str_to_bytes<'a>(msg: &'a String) -> &'a [u8] {
[INFO] [stderr]    |                              ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/util.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | / pub fn str_to_bytes<'a>(msg: &'a String) -> &'a [u8] {
[INFO] [stderr] 13 | |     msg.as_bytes()
[INFO] [stderr] 14 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/util.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn file_to_bytes<'a>(mut file: File) -> Vec<u8> {
[INFO] [stderr]    |                      ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/util.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     let _ = img.save(out_path).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 17.73s
[INFO] running `"docker" "inspect" "c205aaed6a84e6f874750b7977393eca8716c65302c19acd9b6e52ccd8d05961"`
[INFO] running `"docker" "rm" "-f" "c205aaed6a84e6f874750b7977393eca8716c65302c19acd9b6e52ccd8d05961"`
[INFO] [stdout] c205aaed6a84e6f874750b7977393eca8716c65302c19acd9b6e52ccd8d05961