[INFO] crate stdweb-internal-macros 0.2.2 is already in cache [INFO] extracting crate stdweb-internal-macros 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/stdweb-internal-macros/0.2.2 [INFO] extracting crate stdweb-internal-macros 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stdweb-internal-macros/0.2.2 [INFO] validating manifest of stdweb-internal-macros-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stdweb-internal-macros-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stdweb-internal-macros-0.2.2 [INFO] finished frobbing stdweb-internal-macros-0.2.2 [INFO] frobbed toml for stdweb-internal-macros-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/stdweb-internal-macros/0.2.2/Cargo.toml [INFO] started frobbing stdweb-internal-macros-0.2.2 [INFO] finished frobbing stdweb-internal-macros-0.2.2 [INFO] frobbed toml for stdweb-internal-macros-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stdweb-internal-macros/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stdweb-internal-macros-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stdweb-internal-macros/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cde6e23d22256cfb586b4755dc65e25f58b91770b45745fa46f5b4575984bd1a [INFO] running `"docker" "start" "-a" "cde6e23d22256cfb586b4755dc65e25f58b91770b45745fa46f5b4575984bd1a"` [INFO] [stderr] Checking base-x v0.2.4 [INFO] [stderr] Compiling stdweb-internal-macros v0.2.2 (/opt/crater/workdir) [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/macro_js_export.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | const ENCODING_BASE: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/macro_js_export.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | const ENCODING_BASE: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/macro_js_export.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / match &segment.arguments { [INFO] [stderr] 41 | | &syn::PathArguments::None => {}, [INFO] [stderr] 42 | | _ => return None [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | match segment.arguments { [INFO] [stderr] 41 | syn::PathArguments::None => {}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macro_js_export.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / match ty { [INFO] [stderr] 50 | | &syn::Type::Reference( ref ty ) => { [INFO] [stderr] 51 | | assert!( ty.mutability.is_none(), "`mut` bindings are not supported" ); [INFO] [stderr] 52 | | match *ty.elem { [INFO] [stderr] ... | [INFO] [stderr] 75 | | _ => ExportType::Unknown( ty.clone() ) [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *ty { [INFO] [stderr] 50 | syn::Type::Reference( ref ty ) => { [INFO] [stderr] 51 | assert!( ty.mutability.is_none(), "`mut` bindings are not supported" ); [INFO] [stderr] 52 | match *ty.elem { [INFO] [stderr] 53 | syn::Type::Path( ref path ) if match_shallow_path( &path.path ).map( |path| path == "str" ).unwrap_or( false ) => { [INFO] [stderr] 54 | ExportType::StrRef [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/macro_js_export.rs:271:21 [INFO] [stderr] | [INFO] [stderr] 271 | let return_ty = match &decl.output { [INFO] [stderr] | _____________________^ [INFO] [stderr] 272 | | &syn::ReturnType::Default => ExportType::Unit, [INFO] [stderr] 273 | | &syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stderr] 274 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 271 | let return_ty = match decl.output { [INFO] [stderr] 272 | syn::ReturnType::Default => ExportType::Unit, [INFO] [stderr] 273 | syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macro_async_test.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / match return_type { [INFO] [stderr] 7 | | &syn::ReturnType::Default => true, [INFO] [stderr] 8 | | &syn::ReturnType::Type( _, ref ty ) => { [INFO] [stderr] 9 | | match **ty { [INFO] [stderr] ... | [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 6 | match *return_type { [INFO] [stderr] 7 | syn::ReturnType::Default => true, [INFO] [stderr] 8 | syn::ReturnType::Type( _, ref ty ) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/macro_async_test.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / Fallible { [INFO] [stderr] 22 | | callback_ident: syn::Ident, [INFO] [stderr] 23 | | result_ty: syn::Type [INFO] [stderr] 24 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/macro_async_test.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / Fallible { [INFO] [stderr] 22 | | callback_ident: syn::Ident, [INFO] [stderr] 23 | | result_ty: syn::Type [INFO] [stderr] 24 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/macro_async_test.rs:62:8 [INFO] [stderr] | [INFO] [stderr] 62 | if !bound.path.leading_colon.is_none() || [INFO] [stderr] | ________^ [INFO] [stderr] 63 | | bound.path.segments.len() != 1 || [INFO] [stderr] 64 | | bound.path.segments[ 0 ].ident != "FnOnce" [INFO] [stderr] | |__________________________________________________^ help: try: `bound.path.leading_colon.is_some() || bound.path.segments.len() != 1 || bound.path.segments[ 0 ].ident != "FnOnce"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/macro_async_test.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / fn check_decl( decl: &syn::FnDecl ) -> TestKind { [INFO] [stderr] 30 | | assert!( decl.generics.lifetimes().next().is_none(), "Lifetimes are yet not supported" ); [INFO] [stderr] 31 | | assert!( decl.generics.where_clause.is_none(), "`where` clauses are not supported" ); [INFO] [stderr] 32 | | assert!( decl.variadic.is_none(), "Variadic functions are not supported" ); [INFO] [stderr] ... | [INFO] [stderr] 179 | | } [INFO] [stderr] 180 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/macro_js_export.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / match &segment.arguments { [INFO] [stderr] 41 | | &syn::PathArguments::None => {}, [INFO] [stderr] 42 | | _ => return None [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | match segment.arguments { [INFO] [stderr] 41 | syn::PathArguments::None => {}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macro_js_export.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / match ty { [INFO] [stderr] 50 | | &syn::Type::Reference( ref ty ) => { [INFO] [stderr] 51 | | assert!( ty.mutability.is_none(), "`mut` bindings are not supported" ); [INFO] [stderr] 52 | | match *ty.elem { [INFO] [stderr] ... | [INFO] [stderr] 75 | | _ => ExportType::Unknown( ty.clone() ) [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *ty { [INFO] [stderr] 50 | syn::Type::Reference( ref ty ) => { [INFO] [stderr] 51 | assert!( ty.mutability.is_none(), "`mut` bindings are not supported" ); [INFO] [stderr] 52 | match *ty.elem { [INFO] [stderr] 53 | syn::Type::Path( ref path ) if match_shallow_path( &path.path ).map( |path| path == "str" ).unwrap_or( false ) => { [INFO] [stderr] 54 | ExportType::StrRef [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/macro_js_export.rs:271:21 [INFO] [stderr] | [INFO] [stderr] 271 | let return_ty = match &decl.output { [INFO] [stderr] | _____________________^ [INFO] [stderr] 272 | | &syn::ReturnType::Default => ExportType::Unit, [INFO] [stderr] 273 | | &syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stderr] 274 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 271 | let return_ty = match decl.output { [INFO] [stderr] 272 | syn::ReturnType::Default => ExportType::Unit, [INFO] [stderr] 273 | syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macro_async_test.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / match return_type { [INFO] [stderr] 7 | | &syn::ReturnType::Default => true, [INFO] [stderr] 8 | | &syn::ReturnType::Type( _, ref ty ) => { [INFO] [stderr] 9 | | match **ty { [INFO] [stderr] ... | [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 6 | match *return_type { [INFO] [stderr] 7 | syn::ReturnType::Default => true, [INFO] [stderr] 8 | syn::ReturnType::Type( _, ref ty ) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/macro_async_test.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / Fallible { [INFO] [stderr] 22 | | callback_ident: syn::Ident, [INFO] [stderr] 23 | | result_ty: syn::Type [INFO] [stderr] 24 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/macro_async_test.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / Fallible { [INFO] [stderr] 22 | | callback_ident: syn::Ident, [INFO] [stderr] 23 | | result_ty: syn::Type [INFO] [stderr] 24 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/macro_async_test.rs:62:8 [INFO] [stderr] | [INFO] [stderr] 62 | if !bound.path.leading_colon.is_none() || [INFO] [stderr] | ________^ [INFO] [stderr] 63 | | bound.path.segments.len() != 1 || [INFO] [stderr] 64 | | bound.path.segments[ 0 ].ident != "FnOnce" [INFO] [stderr] | |__________________________________________________^ help: try: `bound.path.leading_colon.is_some() || bound.path.segments.len() != 1 || bound.path.segments[ 0 ].ident != "FnOnce"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/macro_async_test.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / fn check_decl( decl: &syn::FnDecl ) -> TestKind { [INFO] [stderr] 30 | | assert!( decl.generics.lifetimes().next().is_none(), "Lifetimes are yet not supported" ); [INFO] [stderr] 31 | | assert!( decl.generics.where_clause.is_none(), "`where` clauses are not supported" ); [INFO] [stderr] 32 | | assert!( decl.variadic.is_none(), "Variadic functions are not supported" ); [INFO] [stderr] ... | [INFO] [stderr] 179 | | } [INFO] [stderr] 180 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.67s [INFO] running `"docker" "inspect" "cde6e23d22256cfb586b4755dc65e25f58b91770b45745fa46f5b4575984bd1a"` [INFO] running `"docker" "rm" "-f" "cde6e23d22256cfb586b4755dc65e25f58b91770b45745fa46f5b4575984bd1a"` [INFO] [stdout] cde6e23d22256cfb586b4755dc65e25f58b91770b45745fa46f5b4575984bd1a