[INFO] crate stderr 0.8.0 is already in cache [INFO] extracting crate stderr 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/stderr/0.8.0 [INFO] extracting crate stderr 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stderr/0.8.0 [INFO] validating manifest of stderr-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stderr-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stderr-0.8.0 [INFO] removed 0 missing tests [INFO] finished frobbing stderr-0.8.0 [INFO] frobbed toml for stderr-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/stderr/0.8.0/Cargo.toml [INFO] started frobbing stderr-0.8.0 [INFO] removed 0 missing tests [INFO] finished frobbing stderr-0.8.0 [INFO] frobbed toml for stderr-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stderr/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stderr-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stderr/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b84ac8b3b9d2fe8032e0711b4d490a0ac38a28f2dcf0944d43fe7ba7a1c0f98 [INFO] running `"docker" "start" "-a" "3b84ac8b3b9d2fe8032e0711b4d490a0ac38a28f2dcf0944d43fe7ba7a1c0f98"` [INFO] [stderr] Checking stderr v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/log/lvl.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | #[allow(unknown_lints,should_implement_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/log/lvl.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | print!("{}\n", i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | mod_path: mod_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mod_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | time_local: time_local, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_local` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | loc: loc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | lvl: lvl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lvl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/log/lvl.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | #[allow(unknown_lints,should_implement_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/log/lvl.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | print!("{}\n", i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | mod_path: mod_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mod_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | time_local: time_local, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_local` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | loc: loc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | lvl: lvl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lvl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/log/lvl.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | #[allow(unknown_lints,should_implement_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/static_mut.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | #[allow(unknown_lints,should_implement_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_from_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/static_mut.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | #[allow(unknown_lints,mut_from_ref)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::mut_from_ref` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/log/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let mut logger = LOGGER.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/log/mod.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | let mut logger = LOGGER.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/static_mut.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | unsafe {self.0.into_inner()} [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/log/lvl.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | #[allow(unknown_lints,should_implement_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/log/lvl.rs:89:23 [INFO] [stderr] | [INFO] [stderr] 89 | const LogLvlStr: &'static str = "Off Fatal Error Warn Info Debug All 0 1 2 3 4 5 6"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/log/mod.rs:202:57 [INFO] [stderr] | [INFO] [stderr] 202 | if mod_path.starts_with(path) && (&mod_path[0..path.len() + 1]).ends_with(':') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=path.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/static_mut.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | #[allow(unknown_lints,should_implement_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_from_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/static_mut.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | #[allow(unknown_lints,mut_from_ref)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::mut_from_ref` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/log/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let mut logger = LOGGER.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/log/mod.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | let mut logger = LOGGER.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/static_mut.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | unsafe {self.0.into_inner()} [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/log/lvl.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/log/lvl.rs:99:16 [INFO] [stderr] | [INFO] [stderr] 99 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/log/mod.rs:202:57 [INFO] [stderr] | [INFO] [stderr] 202 | if mod_path.starts_with(path) && (&mod_path[0..path.len() + 1]).ends_with(':') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=path.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.80s [INFO] running `"docker" "inspect" "3b84ac8b3b9d2fe8032e0711b4d490a0ac38a28f2dcf0944d43fe7ba7a1c0f98"` [INFO] running `"docker" "rm" "-f" "3b84ac8b3b9d2fe8032e0711b4d490a0ac38a28f2dcf0944d43fe7ba7a1c0f98"` [INFO] [stdout] 3b84ac8b3b9d2fe8032e0711b4d490a0ac38a28f2dcf0944d43fe7ba7a1c0f98