[INFO] crate stats-cli 0.0.5 is already in cache [INFO] extracting crate stats-cli 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/stats-cli/0.0.5 [INFO] extracting crate stats-cli 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stats-cli/0.0.5 [INFO] validating manifest of stats-cli-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stats-cli-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stats-cli-0.0.5 [INFO] finished frobbing stats-cli-0.0.5 [INFO] frobbed toml for stats-cli-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/stats-cli/0.0.5/Cargo.toml [INFO] started frobbing stats-cli-0.0.5 [INFO] finished frobbing stats-cli-0.0.5 [INFO] frobbed toml for stats-cli-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stats-cli/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stats-cli-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stats-cli/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a60609dc70a558068c8d55185d06816715de0fb9a10178645ca7a86438929778 [INFO] running `"docker" "start" "-a" "a60609dc70a558068c8d55185d06816715de0fb9a10178645ca7a86438929778"` [INFO] [stderr] Checking stats-cli v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SummStats` [INFO] [stderr] --> src/lib.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Self { [INFO] [stderr] 49 | | SummStats{non_nan: false, count: 0, mean: 0.0, ssd: 0.0, min: f64::INFINITY, max: f64::NEG_INFINITY} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / match self.non_nan { [INFO] [stderr] 91 | | false => None, [INFO] [stderr] 92 | | true => Some(self.min), [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.non_nan { Some(self.min) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / match self.non_nan { [INFO] [stderr] 109 | | false => None, [INFO] [stderr] 110 | | true => Some(self.max), [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.non_nan { Some(self.max) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Percentiles` [INFO] [stderr] --> src/lib.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / pub fn new() -> Self { [INFO] [stderr] 265 | | Percentiles{data: Vec::new(), in_order: Vec::new()} [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 256 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | / match self.in_order.binary_search(&index) { [INFO] [stderr] 323 | | Err(insert) => { [INFO] [stderr] 324 | | let start = if insert == 0 { [INFO] [stderr] 325 | | 0 [INFO] [stderr] ... | [INFO] [stderr] 338 | | _ => (), [INFO] [stderr] 339 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 322 | if let Err(insert) = self.in_order.binary_search(&index) { [INFO] [stderr] 323 | let start = if insert == 0 { [INFO] [stderr] 324 | 0 [INFO] [stderr] 325 | } else { [INFO] [stderr] 326 | self.in_order[insert - 1] + 1 [INFO] [stderr] 327 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:354:46 [INFO] [stderr] | [INFO] [stderr] 354 | pub fn percentile(&mut self, percentile: &f64) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Mode` [INFO] [stderr] --> src/lib.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | / pub fn new() -> Self { [INFO] [stderr] 472 | | Mode{counts: HashMap::new(), count: 0, mode: Vec::new(), mode_count: 0} [INFO] [stderr] 473 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 462 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | write!(output, "}}\n").expect("couldn't write to output"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SummStats` [INFO] [stderr] --> src/lib.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Self { [INFO] [stderr] 49 | | SummStats{non_nan: false, count: 0, mean: 0.0, ssd: 0.0, min: f64::INFINITY, max: f64::NEG_INFINITY} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / match self.non_nan { [INFO] [stderr] 91 | | false => None, [INFO] [stderr] 92 | | true => Some(self.min), [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.non_nan { Some(self.min) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / match self.non_nan { [INFO] [stderr] 109 | | false => None, [INFO] [stderr] 110 | | true => Some(self.max), [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.non_nan { Some(self.max) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Percentiles` [INFO] [stderr] --> src/lib.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / pub fn new() -> Self { [INFO] [stderr] 265 | | Percentiles{data: Vec::new(), in_order: Vec::new()} [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 256 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | / match self.in_order.binary_search(&index) { [INFO] [stderr] 323 | | Err(insert) => { [INFO] [stderr] 324 | | let start = if insert == 0 { [INFO] [stderr] 325 | | 0 [INFO] [stderr] ... | [INFO] [stderr] 338 | | _ => (), [INFO] [stderr] 339 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 322 | if let Err(insert) = self.in_order.binary_search(&index) { [INFO] [stderr] 323 | let start = if insert == 0 { [INFO] [stderr] 324 | 0 [INFO] [stderr] 325 | } else { [INFO] [stderr] 326 | self.in_order[insert - 1] + 1 [INFO] [stderr] 327 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:354:46 [INFO] [stderr] | [INFO] [stderr] 354 | pub fn percentile(&mut self, percentile: &f64) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Mode` [INFO] [stderr] --> src/lib.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | / pub fn new() -> Self { [INFO] [stderr] 472 | | Mode{counts: HashMap::new(), count: 0, mode: Vec::new(), mode_count: 0} [INFO] [stderr] 473 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 462 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | write!(output, "}}\n").expect("couldn't write to output"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / fn main() { [INFO] [stderr] 15 | | let matches = App::new("stats") [INFO] [stderr] 16 | | .version("0.0") [INFO] [stderr] 17 | | .author("Erik Brinkman ") [INFO] [stderr] ... | [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:93:39 [INFO] [stderr] | [INFO] [stderr] 93 | File::open(file_name).expect(&format!("File \"{}\" does not exist", file_name)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("File \"{}\" does not exist", file_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:102:39 [INFO] [stderr] | [INFO] [stderr] 102 | File::open(file_name).expect(&format!("Couldn't open file \"{}\" for writing", file_name)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't open file \"{}\" for writing", file_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:118:37 [INFO] [stderr] | [INFO] [stderr] 118 | let num = token.parse().expect(&format!("Could not parse \"{}\" as float", token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not parse \"{}\" as float", token))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:158:104 [INFO] [stderr] | [INFO] [stderr] 158 | let percentiles: Vec = matches.values_of("percentiles").unwrap().map(|p| p.parse::().expect(&format!("Could not parse \"{}\" as float", p))).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not parse \"{}\" as float", p))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | fn write_tsv(results: &Vec<(String, f64)>, output: &mut Write) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:205:24 [INFO] [stderr] | [INFO] [stderr] 205 | fn write_json(results: &Vec<(String, f64)>, output: &mut Write) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / fn main() { [INFO] [stderr] 15 | | let matches = App::new("stats") [INFO] [stderr] 16 | | .version("0.0") [INFO] [stderr] 17 | | .author("Erik Brinkman ") [INFO] [stderr] ... | [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:93:39 [INFO] [stderr] | [INFO] [stderr] 93 | File::open(file_name).expect(&format!("File \"{}\" does not exist", file_name)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("File \"{}\" does not exist", file_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:102:39 [INFO] [stderr] | [INFO] [stderr] 102 | File::open(file_name).expect(&format!("Couldn't open file \"{}\" for writing", file_name)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't open file \"{}\" for writing", file_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:118:37 [INFO] [stderr] | [INFO] [stderr] 118 | let num = token.parse().expect(&format!("Could not parse \"{}\" as float", token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not parse \"{}\" as float", token))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:158:104 [INFO] [stderr] | [INFO] [stderr] 158 | let percentiles: Vec = matches.values_of("percentiles").unwrap().map(|p| p.parse::().expect(&format!("Could not parse \"{}\" as float", p))).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not parse \"{}\" as float", p))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | fn write_tsv(results: &Vec<(String, f64)>, output: &mut Write) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:205:24 [INFO] [stderr] | [INFO] [stderr] 205 | fn write_json(results: &Vec<(String, f64)>, output: &mut Write) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.92s [INFO] running `"docker" "inspect" "a60609dc70a558068c8d55185d06816715de0fb9a10178645ca7a86438929778"` [INFO] running `"docker" "rm" "-f" "a60609dc70a558068c8d55185d06816715de0fb9a10178645ca7a86438929778"` [INFO] [stdout] a60609dc70a558068c8d55185d06816715de0fb9a10178645ca7a86438929778