[INFO] crate static-http-cache 0.1.0 is already in cache [INFO] extracting crate static-http-cache 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/static-http-cache/0.1.0 [INFO] extracting crate static-http-cache 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/static-http-cache/0.1.0 [INFO] validating manifest of static-http-cache-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of static-http-cache-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing static-http-cache-0.1.0 [INFO] finished frobbing static-http-cache-0.1.0 [INFO] frobbed toml for static-http-cache-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/static-http-cache/0.1.0/Cargo.toml [INFO] started frobbing static-http-cache-0.1.0 [INFO] finished frobbing static-http-cache-0.1.0 [INFO] frobbed toml for static-http-cache-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/static-http-cache/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting static-http-cache-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/static-http-cache/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cdba5b01ea1e0cde64a3bcf7f0fb5611662a7be885373fb4009dcca193965885 [INFO] running `"docker" "start" "-a" "cdba5b01ea1e0cde64a3bcf7f0fb5611662a7be885373fb4009dcca193965885"` [INFO] [stderr] Compiling sqlite3-src v0.2.10 [INFO] [stderr] Checking crypto-hash v0.3.3 [INFO] [stderr] Checking sqlite3-sys v0.12.0 [INFO] [stderr] Checking sqlite v0.23.9 [INFO] [stderr] Checking static-http-cache v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | Transaction{conn: conn, committed: false} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | Transaction{conn: conn, committed: false} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:110:40 [INFO] [stderr] | [INFO] [stderr] 110 | let parent = path.parent().unwrap_or(path::Path::new(".")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| path::Path::new("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:115:58 [INFO] [stderr] | [INFO] [stderr] 115 | parent.canonicalize()?.join(path.file_name().unwrap_or(ffi::OsStr::new(""))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ffi::OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/db.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | |x| Ok(x), [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:110:40 [INFO] [stderr] | [INFO] [stderr] 110 | let parent = path.parent().unwrap_or(path::Path::new(".")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| path::Path::new("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:115:58 [INFO] [stderr] | [INFO] [stderr] 115 | parent.canonicalize()?.join(path.file_name().unwrap_or(ffi::OsStr::new(""))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ffi::OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/db.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | |x| Ok(x), [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/urlcat.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | .map(|x| Ok(x)) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.36s [INFO] running `"docker" "inspect" "cdba5b01ea1e0cde64a3bcf7f0fb5611662a7be885373fb4009dcca193965885"` [INFO] running `"docker" "rm" "-f" "cdba5b01ea1e0cde64a3bcf7f0fb5611662a7be885373fb4009dcca193965885"` [INFO] [stdout] cdba5b01ea1e0cde64a3bcf7f0fb5611662a7be885373fb4009dcca193965885