[INFO] crate stateright 0.2.0 is already in cache [INFO] extracting crate stateright 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/stateright/0.2.0 [INFO] extracting crate stateright 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stateright/0.2.0 [INFO] validating manifest of stateright-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stateright-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stateright-0.2.0 [INFO] finished frobbing stateright-0.2.0 [INFO] frobbed toml for stateright-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/stateright/0.2.0/Cargo.toml [INFO] started frobbing stateright-0.2.0 [INFO] finished frobbing stateright-0.2.0 [INFO] frobbed toml for stateright-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stateright/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stateright-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stateright/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe203f36179567ba89cc8c498cabdbb844fc86199f2e30c2913bbf34c3e1f6ee [INFO] running `"docker" "start" "-a" "fe203f36179567ba89cc8c498cabdbb844fc86199f2e30c2913bbf34c3e1f6ee"` [INFO] [stderr] Checking stateright v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actor/mod.rs:385:17 [INFO] [stderr] | [INFO] [stderr] 385 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actor/mod.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/actor/mod.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | / match self { [INFO] [stderr] 254 | | $($advance)* [INFO] [stderr] 255 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 360 | / actor! { [INFO] [stderr] 361 | | Cfg { Pinger { max_nat: u32, ponger_id: Id } , Ponger { max_nat: u32 } } [INFO] [stderr] 362 | | State { PingerState(u32), PongerState(u32) } [INFO] [stderr] 363 | | Msg { Ping(u32), Pong(u32) } [INFO] [stderr] ... | [INFO] [stderr] 401 | | } [INFO] [stderr] 402 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/actor/mod.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | / if let &State::PingerState(actor_value) = state { [INFO] [stderr] 375 | | if let Msg::Pong(msg_value) = msg { [INFO] [stderr] 376 | | if actor_value == msg_value && actor_value < max_nat { [INFO] [stderr] 377 | | return ActorResult::advance(state, |action, state, outputs| { [INFO] [stderr] ... | [INFO] [stderr] 383 | | } [INFO] [stderr] 384 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 374 | if let State::PingerState(actor_value) = *state { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/actor/mod.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | / if let &State::PongerState(actor_value) = state { [INFO] [stderr] 389 | | if let Msg::Ping(msg_value) = msg { [INFO] [stderr] 390 | | if actor_value == msg_value && actor_value < max_nat { [INFO] [stderr] 391 | | return ActorResult::advance(state, |action, state, outputs| { [INFO] [stderr] ... | [INFO] [stderr] 397 | | } [INFO] [stderr] 398 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 388 | if let State::PongerState(actor_value) = *state { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/actor/mod.rs:425:49 [INFO] [stderr] | [INFO] [stderr] 425 | actor_states: states.iter().map(|s| Arc::new(s)).collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Arc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:416:55 [INFO] [stderr] | [INFO] [stderr] 416 | fn invariant(equation: &LinearEquation, solution: &(Wrapping, Wrapping)) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `(Wrapping, Wrapping)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/paxos.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> examples/paxos.rs:214:37 [INFO] [stderr] | [INFO] [stderr] 214 | desired_value: ('A' as u8 + i) as char [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> examples/paxos.rs:223:48 [INFO] [stderr] | [INFO] [stderr] 223 | [v] => 'A' <= *v && *v <= ('A' as u8 + client_count - 1) as char, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `port` [INFO] [stderr] --> examples/paxos.rs:240:35 [INFO] [stderr] | [INFO] [stderr] 240 | let id0 = (localhost, port + 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/wor.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> examples/wor.rs:97:58 [INFO] [stderr] | [INFO] [stderr] 97 | server_ids: vec![0], desired_value: ('A' as u8 + i) as char [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> examples/wor.rs:106:48 [INFO] [stderr] | [INFO] [stderr] 106 | [v] => 'A' <= *v && *v <= ('A' as u8 + client_count - 1) as char, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.20s [INFO] running `"docker" "inspect" "fe203f36179567ba89cc8c498cabdbb844fc86199f2e30c2913bbf34c3e1f6ee"` [INFO] running `"docker" "rm" "-f" "fe203f36179567ba89cc8c498cabdbb844fc86199f2e30c2913bbf34c3e1f6ee"` [INFO] [stdout] fe203f36179567ba89cc8c498cabdbb844fc86199f2e30c2913bbf34c3e1f6ee