[INFO] crate stamm 0.2.0 is already in cache [INFO] extracting crate stamm 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/stamm/0.2.0 [INFO] extracting crate stamm 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stamm/0.2.0 [INFO] validating manifest of stamm-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stamm-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stamm-0.2.0 [INFO] finished frobbing stamm-0.2.0 [INFO] frobbed toml for stamm-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/stamm/0.2.0/Cargo.toml [INFO] started frobbing stamm-0.2.0 [INFO] finished frobbing stamm-0.2.0 [INFO] frobbed toml for stamm-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stamm/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stamm-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stamm/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec7005a8514cc71e643cb5581715ce4126ffb91272d57d35bfad1e1b2e066298 [INFO] running `"docker" "start" "-a" "ec7005a8514cc71e643cb5581715ce4126ffb91272d57d35bfad1e1b2e066298"` [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking stamm v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/randforest.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | number_of_trees: number_of_trees, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_trees` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/randforest.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | size_of_subset_per_training: size_of_subset_per_training, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_of_subset_per_training` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numerictree.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | min_subset_size: min_subset_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_subset_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numerictree.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | max_depth: max_depth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/randforest.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | number_of_trees: number_of_trees, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_trees` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/randforest.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | size_of_subset_per_training: size_of_subset_per_training, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_of_subset_per_training` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numerictree.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | min_subset_size: min_subset_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_subset_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numerictree.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | max_depth: max_depth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return (a, b); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/randforest.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return f64::from(*self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f64::from(*self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/randforest.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return (sum as f64) / (tree_results.len() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(sum as f64) / (tree_results.len() as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/randforest.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | tree [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/randforest.rs:186:28 [INFO] [stderr] | [INFO] [stderr] 186 | let tree = self.tree_param.learn_tree(self.learn_function, &subset[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numerictree.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return -(rel * ln!(rel) + (1f64 - rel) * ln!(1f64 - rel)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `-(rel * ln!(rel) + (1f64 - rel) * ln!(1f64 - rel))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/numerictree.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/numerictree.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | let res = ((set_l.len() as f64) * self.set_impurity.impurity(set_l) + [INFO] [stderr] | ___________________^ [INFO] [stderr] 144 | | (set_r.len() as f64) * self.set_impurity.impurity(set_r)) / [INFO] [stderr] 145 | | size; [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/numerictree.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/numerictree.rs:157:35 [INFO] [stderr] | [INFO] [stderr] 157 | let res = rng.gen_range(self.min_nr, self.max_nr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numerictree.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | return NumericLeafParam { probability: prob }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NumericLeafParam { probability: prob }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/numerictree.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | tree [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/numerictree.rs:239:20 [INFO] [stderr] | [INFO] [stderr] 239 | let tree = self.tree_param.learn_tree(self.func, &dataref[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return (a, b); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/randforest.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return f64::from(*self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f64::from(*self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/randforest.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return (sum as f64) / (tree_results.len() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(sum as f64) / (tree_results.len() as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/randforest.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | tree [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/randforest.rs:186:28 [INFO] [stderr] | [INFO] [stderr] 186 | let tree = self.tree_param.learn_tree(self.learn_function, &subset[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numerictree.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return -(rel * ln!(rel) + (1f64 - rel) * ln!(1f64 - rel)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `-(rel * ln!(rel) + (1f64 - rel) * ln!(1f64 - rel))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/numerictree.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/numerictree.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | let res = ((set_l.len() as f64) * self.set_impurity.impurity(set_l) + [INFO] [stderr] | ___________________^ [INFO] [stderr] 144 | | (set_r.len() as f64) * self.set_impurity.impurity(set_r)) / [INFO] [stderr] 145 | | size; [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/numerictree.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/numerictree.rs:157:35 [INFO] [stderr] | [INFO] [stderr] 157 | let res = rng.gen_range(self.min_nr, self.max_nr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numerictree.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | return NumericLeafParam { probability: prob }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NumericLeafParam { probability: prob }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/numerictree.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | tree [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/numerictree.rs:239:20 [INFO] [stderr] | [INFO] [stderr] 239 | let tree = self.tree_param.learn_tree(self.func, &dataref[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tree.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | -> (Vec<(&'a Self::Data, &'a Self::Truth)>, Vec<(&'a Self::Data, &'a Self::Truth)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::TreeParameters` [INFO] [stderr] --> src/tree.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> TreeParameters { [INFO] [stderr] 124 | | TreeParameters {} [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused label `'l` [INFO] [stderr] --> src/tree.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / 'l: loop { [INFO] [stderr] 159 | | match *node { [INFO] [stderr] 160 | | Node::Leaf(ref param) => return Some(param), [INFO] [stderr] 161 | | Node::Interior { [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/tree.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / if self.root.is_none() { [INFO] [stderr] 155 | | return None; [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.root?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tree.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | assert!(subset.is_empty() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!subset.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tree.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | assert!(false == impurity.is_nan()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!impurity.is_nan()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/numerictree.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | let rel = (abs as f64) / (set.len() as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(abs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/numerictree.rs:174:20 [INFO] [stderr] | [INFO] [stderr] 174 | let prob = (truth as f64) / (size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(truth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tree.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | -> (Vec<(&'a Self::Data, &'a Self::Truth)>, Vec<(&'a Self::Data, &'a Self::Truth)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::TreeParameters` [INFO] [stderr] --> src/tree.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> TreeParameters { [INFO] [stderr] 124 | | TreeParameters {} [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused label `'l` [INFO] [stderr] --> src/tree.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / 'l: loop { [INFO] [stderr] 159 | | match *node { [INFO] [stderr] 160 | | Node::Leaf(ref param) => return Some(param), [INFO] [stderr] 161 | | Node::Interior { [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/tree.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / if self.root.is_none() { [INFO] [stderr] 155 | | return None; [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.root?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tree.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | assert!(subset.is_empty() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!subset.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tree.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | assert!(false == impurity.is_nan()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!impurity.is_nan()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/numerictree.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | let rel = (abs as f64) / (set.len() as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(abs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/numerictree.rs:174:20 [INFO] [stderr] | [INFO] [stderr] 174 | let prob = (truth as f64) / (size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(truth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/numeric_tree_example.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | (x as f64, numerictree::NumericTruth::NotInClass) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/numeric_tree_example.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | (x as f64, numerictree::NumericTruth::InClass) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.55s [INFO] running `"docker" "inspect" "ec7005a8514cc71e643cb5581715ce4126ffb91272d57d35bfad1e1b2e066298"` [INFO] running `"docker" "rm" "-f" "ec7005a8514cc71e643cb5581715ce4126ffb91272d57d35bfad1e1b2e066298"` [INFO] [stdout] ec7005a8514cc71e643cb5581715ce4126ffb91272d57d35bfad1e1b2e066298