[INFO] crate stag 0.3.0 is already in cache [INFO] extracting crate stag 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/stag/0.3.0 [INFO] extracting crate stag 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stag/0.3.0 [INFO] validating manifest of stag-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stag-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stag-0.3.0 [INFO] finished frobbing stag-0.3.0 [INFO] frobbed toml for stag-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/stag/0.3.0/Cargo.toml [INFO] started frobbing stag-0.3.0 [INFO] finished frobbing stag-0.3.0 [INFO] frobbed toml for stag-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stag/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stag-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stag/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 68d2e4ca5460db21815aca74b747f4d2e535a6f085f99632bd3d3671fcd50c15 [INFO] running `"docker" "start" "-a" "68d2e4ca5460db21815aca74b747f4d2e535a6f085f99632bd3d3671fcd50c15"` [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking stag v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rgba.rs:66:33 [INFO] [stderr] | [INFO] [stderr] 66 | / { [INFO] [stderr] 67 | | if rng.gen() [INFO] [stderr] 68 | | { [INFO] [stderr] 69 | | px.data[3] += 1; [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | if rng.gen() [INFO] [stderr] 67 | { [INFO] [stderr] 68 | px.data[3] += 1; [INFO] [stderr] 69 | } [INFO] [stderr] 70 | else [INFO] [stderr] 71 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rgba.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | / { [INFO] [stderr] 91 | | if rng.gen() [INFO] [stderr] 92 | | { [INFO] [stderr] 93 | | px.data[3] += 1; [INFO] [stderr] ... | [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | if rng.gen() [INFO] [stderr] 91 | { [INFO] [stderr] 92 | px.data[3] += 1; [INFO] [stderr] 93 | } [INFO] [stderr] 94 | else [INFO] [stderr] 95 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rgba.rs:128:33 [INFO] [stderr] | [INFO] [stderr] 128 | / { [INFO] [stderr] 129 | | if rng.gen() [INFO] [stderr] 130 | | { [INFO] [stderr] 131 | | *val += 1; [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | if rng.gen() [INFO] [stderr] 129 | { [INFO] [stderr] 130 | *val += 1; [INFO] [stderr] 131 | } [INFO] [stderr] 132 | else [INFO] [stderr] 133 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rgba.rs:152:33 [INFO] [stderr] | [INFO] [stderr] 152 | / { [INFO] [stderr] 153 | | if rng.gen() [INFO] [stderr] 154 | | { [INFO] [stderr] 155 | | *val += 1; [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 152 | if rng.gen() [INFO] [stderr] 153 | { [INFO] [stderr] 154 | *val += 1; [INFO] [stderr] 155 | } [INFO] [stderr] 156 | else [INFO] [stderr] 157 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / { [INFO] [stderr] 52 | | if *source % 2 == 1 [INFO] [stderr] 53 | | { [INFO] [stderr] 54 | | if *source == 255 [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | if *source % 2 == 1 [INFO] [stderr] 52 | { [INFO] [stderr] 53 | if *source == 255 [INFO] [stderr] 54 | { [INFO] [stderr] 55 | *source = 254; [INFO] [stderr] 56 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / { [INFO] [stderr] 39 | | if rng.gen() [INFO] [stderr] 40 | | { [INFO] [stderr] 41 | | *source += 1; [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | if rng.gen() [INFO] [stderr] 39 | { [INFO] [stderr] 40 | *source += 1; [INFO] [stderr] 41 | } [INFO] [stderr] 42 | else [INFO] [stderr] 43 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / { [INFO] [stderr] 60 | | if rng.gen() [INFO] [stderr] 61 | | { [INFO] [stderr] 62 | | *source += 1; [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | if rng.gen() [INFO] [stderr] 60 | { [INFO] [stderr] 61 | *source += 1; [INFO] [stderr] 62 | } [INFO] [stderr] 63 | else [INFO] [stderr] 64 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rgba.rs:66:33 [INFO] [stderr] | [INFO] [stderr] 66 | / { [INFO] [stderr] 67 | | if rng.gen() [INFO] [stderr] 68 | | { [INFO] [stderr] 69 | | px.data[3] += 1; [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | if rng.gen() [INFO] [stderr] 67 | { [INFO] [stderr] 68 | px.data[3] += 1; [INFO] [stderr] 69 | } [INFO] [stderr] 70 | else [INFO] [stderr] 71 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rgba.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | / { [INFO] [stderr] 91 | | if rng.gen() [INFO] [stderr] 92 | | { [INFO] [stderr] 93 | | px.data[3] += 1; [INFO] [stderr] ... | [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | if rng.gen() [INFO] [stderr] 91 | { [INFO] [stderr] 92 | px.data[3] += 1; [INFO] [stderr] 93 | } [INFO] [stderr] 94 | else [INFO] [stderr] 95 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rgba.rs:128:33 [INFO] [stderr] | [INFO] [stderr] 128 | / { [INFO] [stderr] 129 | | if rng.gen() [INFO] [stderr] 130 | | { [INFO] [stderr] 131 | | *val += 1; [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | if rng.gen() [INFO] [stderr] 129 | { [INFO] [stderr] 130 | *val += 1; [INFO] [stderr] 131 | } [INFO] [stderr] 132 | else [INFO] [stderr] 133 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rgba.rs:152:33 [INFO] [stderr] | [INFO] [stderr] 152 | / { [INFO] [stderr] 153 | | if rng.gen() [INFO] [stderr] 154 | | { [INFO] [stderr] 155 | | *val += 1; [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 152 | if rng.gen() [INFO] [stderr] 153 | { [INFO] [stderr] 154 | *val += 1; [INFO] [stderr] 155 | } [INFO] [stderr] 156 | else [INFO] [stderr] 157 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / { [INFO] [stderr] 52 | | if *source % 2 == 1 [INFO] [stderr] 53 | | { [INFO] [stderr] 54 | | if *source == 255 [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | if *source % 2 == 1 [INFO] [stderr] 52 | { [INFO] [stderr] 53 | if *source == 255 [INFO] [stderr] 54 | { [INFO] [stderr] 55 | *source = 254; [INFO] [stderr] 56 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / { [INFO] [stderr] 39 | | if rng.gen() [INFO] [stderr] 40 | | { [INFO] [stderr] 41 | | *source += 1; [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | if rng.gen() [INFO] [stderr] 39 | { [INFO] [stderr] 40 | *source += 1; [INFO] [stderr] 41 | } [INFO] [stderr] 42 | else [INFO] [stderr] 43 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / { [INFO] [stderr] 60 | | if rng.gen() [INFO] [stderr] 61 | | { [INFO] [stderr] 62 | | *source += 1; [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | if rng.gen() [INFO] [stderr] 60 | { [INFO] [stderr] 61 | *source += 1; [INFO] [stderr] 62 | } [INFO] [stderr] 63 | else [INFO] [stderr] 64 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rgba.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | .zip(payload.iter().map(|x| *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `payload.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rgb.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | .zip(payload.iter().map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `payload.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/gray_alpha.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | .zip(payload.iter().map(|x| *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `payload.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rgba.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | .zip(payload.iter().map(|x| *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `payload.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rgb.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | .zip(payload.iter().map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `payload.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/gray_alpha.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | .zip(payload.iter().map(|x| *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `payload.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.26s [INFO] running `"docker" "inspect" "68d2e4ca5460db21815aca74b747f4d2e535a6f085f99632bd3d3671fcd50c15"` [INFO] running `"docker" "rm" "-f" "68d2e4ca5460db21815aca74b747f4d2e535a6f085f99632bd3d3671fcd50c15"` [INFO] [stdout] 68d2e4ca5460db21815aca74b747f4d2e535a6f085f99632bd3d3671fcd50c15