[INFO] crate stack-vm 0.3.0 is already in cache [INFO] extracting crate stack-vm 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/stack-vm/0.3.0 [INFO] extracting crate stack-vm 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stack-vm/0.3.0 [INFO] validating manifest of stack-vm-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stack-vm-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stack-vm-0.3.0 [INFO] finished frobbing stack-vm-0.3.0 [INFO] frobbed toml for stack-vm-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/stack-vm/0.3.0/Cargo.toml [INFO] started frobbing stack-vm-0.3.0 [INFO] finished frobbing stack-vm-0.3.0 [INFO] frobbed toml for stack-vm-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stack-vm/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stack-vm-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stack-vm/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bed1b833b0d5fb0eaba1b6532d4740113f8b264a4aa1d362eb1c2b05c1eeb8f3 [INFO] running `"docker" "start" "-a" "bed1b833b0d5fb0eaba1b6532d4740113f8b264a4aa1d362eb1c2b05c1eeb8f3"` [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Checking stack-vm v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | op_code: op_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `op_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | arity: arity, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | fun: fun [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | return_address: return_address [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | code: code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | instruction_table: instruction_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | constants: constants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | call_stack: call_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `call_stack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/from_byte_code.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/from_byte_code.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | code: code, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/from_byte_code.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/from_byte_code.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | labels: labels [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/mod.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/mod.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | code: code, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/mod.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/mod.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | labels: labels [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | op_code: op_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `op_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | arity: arity, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | fun: fun [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | return_address: return_address [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | code: code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | instruction_table: instruction_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | constants: constants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | call_stack: call_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `call_stack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/from_byte_code.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/from_byte_code.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | code: code, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/from_byte_code.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/from_byte_code.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | labels: labels [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/mod.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/mod.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | code: code, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/mod.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/mod.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | labels: labels [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `builder::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/builder.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / impl<'a, T: fmt::Debug + PartialEq> Builder<'a, T> { [INFO] [stderr] 42 | | /// Create a new `Builder` from an `InstructionTable`. [INFO] [stderr] 43 | | pub fn new(instruction_table: &'a InstructionTable) -> Builder { [INFO] [stderr] 44 | | let mut labels = WriteOnceTable::new(); [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/builder.rs:63:14 [INFO] [stderr] | [INFO] [stderr] 63 | .expect(&format!("Unable to find instruction with name {:?}", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to find instruction with name {:?}", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/builder.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | ip = ip + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/builder.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | .expect(&format!("Unable to find instruction with op code {}", op_code)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to find instruction with op code {}", op_code))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/builder.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | ip = ip + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/builder.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | ip = ip + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `write_once_table::WriteOnceTable` [INFO] [stderr] --> src/write_once_table.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> WriteOnceTable { [INFO] [stderr] 35 | | WriteOnceTable(HashMap::new()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/write_once_table.rs:46:52 [INFO] [stderr] | [INFO] [stderr] 46 | self.0.keys().for_each(|ref k| result.push(k.clone())); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 46 | self.0.keys().for_each(|ref k| result.push(&(*k).clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 46 | self.0.keys().for_each(|ref k| result.push(&std::string::String::clone(k))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `write_many_table::WriteManyTable` [INFO] [stderr] --> src/write_many_table.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() ->WriteManyTable { [INFO] [stderr] 34 | | WriteManyTable(HashMap::new()) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stack::Stack` [INFO] [stderr] --> src/stack.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Stack { [INFO] [stderr] 28 | | Stack(vec![]) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | machine.ip = machine.ip + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `machine.ip += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/machine.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | .expect(&format!("Unable to find instruction with op code {}", op_code)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to find instruction with op code {}", op_code))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | machine.ip = machine.ip + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `machine.ip += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/machine.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | .expect(&format!("Constant data is not present at index {}.", idx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Constant data is not present at index {}.", idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/machine.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | .expect(&format!("Attempt to jump to unknown label {}", label)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Attempt to jump to unknown label {}", label))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `instruction_table::InstructionTable` [INFO] [stderr] --> src/instruction_table.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> InstructionTable { [INFO] [stderr] 19 | | InstructionTable(HashMap::new()) [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/instruction_table.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | let instr = self.0.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/code/debug.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | ip = ip + 2; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/code/debug.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | ip = ip + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `stack-vm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `builder::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/builder.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / impl<'a, T: fmt::Debug + PartialEq> Builder<'a, T> { [INFO] [stderr] 42 | | /// Create a new `Builder` from an `InstructionTable`. [INFO] [stderr] 43 | | pub fn new(instruction_table: &'a InstructionTable) -> Builder { [INFO] [stderr] 44 | | let mut labels = WriteOnceTable::new(); [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/builder.rs:63:14 [INFO] [stderr] | [INFO] [stderr] 63 | .expect(&format!("Unable to find instruction with name {:?}", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to find instruction with name {:?}", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/builder.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | ip = ip + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/builder.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | .expect(&format!("Unable to find instruction with op code {}", op_code)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to find instruction with op code {}", op_code))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/builder.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | ip = ip + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/builder.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | ip = ip + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `write_once_table::WriteOnceTable` [INFO] [stderr] --> src/write_once_table.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> WriteOnceTable { [INFO] [stderr] 35 | | WriteOnceTable(HashMap::new()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/write_once_table.rs:46:52 [INFO] [stderr] | [INFO] [stderr] 46 | self.0.keys().for_each(|ref k| result.push(k.clone())); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 46 | self.0.keys().for_each(|ref k| result.push(&(*k).clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 46 | self.0.keys().for_each(|ref k| result.push(&std::string::String::clone(k))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `write_many_table::WriteManyTable` [INFO] [stderr] --> src/write_many_table.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() ->WriteManyTable { [INFO] [stderr] 34 | | WriteManyTable(HashMap::new()) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stack::Stack` [INFO] [stderr] --> src/stack.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Stack { [INFO] [stderr] 28 | | Stack(vec![]) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | machine.ip = machine.ip + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `machine.ip += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/machine.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | .expect(&format!("Unable to find instruction with op code {}", op_code)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to find instruction with op code {}", op_code))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | machine.ip = machine.ip + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `machine.ip += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/machine.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | .expect(&format!("Constant data is not present at index {}.", idx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Constant data is not present at index {}.", idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/machine.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | .expect(&format!("Attempt to jump to unknown label {}", label)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Attempt to jump to unknown label {}", label))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/machine.rs:184:19 [INFO] [stderr] | [INFO] [stderr] 184 | let arg = machine.code.data.get(args[0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `machine.code.data[args[0]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `instruction_table::InstructionTable` [INFO] [stderr] --> src/instruction_table.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> InstructionTable { [INFO] [stderr] 19 | | InstructionTable(HashMap::new()) [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/instruction_table.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | let instr = self.0.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/code/debug.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | ip = ip + 2; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/code/debug.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | ip = ip + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/acceptance/arithmetic.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(result, 9.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/acceptance/arithmetic.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(result, 9.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/acceptance/arithmetic.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | assert_eq!(result, 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/acceptance/arithmetic.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | assert_eq!(result, 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/acceptance/arithmetic.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | assert_eq!(result, 0.75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/acceptance/arithmetic.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | assert_eq!(result, 0.75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/acceptance/arithmetic.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(result, 12.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/acceptance/arithmetic.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(result, 12.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/acceptance/functions.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match self { [INFO] [stderr] 25 | | &Operand::I(i) => Some(i), [INFO] [stderr] 26 | | _ => None [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | Operand::I(i) => Some(i), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/acceptance/functions.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &Operand::S(ref s) => Some(s), [INFO] [stderr] 33 | | _ => None [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Operand::S(ref s) => Some(s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `stack-vm`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bed1b833b0d5fb0eaba1b6532d4740113f8b264a4aa1d362eb1c2b05c1eeb8f3"` [INFO] running `"docker" "rm" "-f" "bed1b833b0d5fb0eaba1b6532d4740113f8b264a4aa1d362eb1c2b05c1eeb8f3"` [INFO] [stdout] bed1b833b0d5fb0eaba1b6532d4740113f8b264a4aa1d362eb1c2b05c1eeb8f3