[INFO] crate sstable 0.6.2 is already in cache [INFO] extracting crate sstable 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/sstable/0.6.2 [INFO] extracting crate sstable 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sstable/0.6.2 [INFO] validating manifest of sstable-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sstable-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sstable-0.6.2 [INFO] finished frobbing sstable-0.6.2 [INFO] frobbed toml for sstable-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/sstable/0.6.2/Cargo.toml [INFO] started frobbing sstable-0.6.2 [INFO] finished frobbing sstable-0.6.2 [INFO] frobbed toml for sstable-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sstable/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sstable-0.6.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sstable/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 983c088878a182cab5c2ec9274a89d09ac9a406ede2f293471106dc28d699143 [INFO] running `"docker" "start" "-a" "983c088878a182cab5c2ec9274a89d09ac9a406ede2f293471106dc28d699143"` [INFO] [stderr] Checking time-test v0.2.1 [INFO] [stderr] Checking sstable v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block_builder.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | restarts: restarts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `restarts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockhandle.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockhandle.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | bits_per_key: bits_per_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_builder.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_builder.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | cache_id: cache_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | footer: footer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `footer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | indexblock: indexblock, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indexblock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return self.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return self.list.count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | return self.cap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / return Status { [INFO] [stderr] 67 | | code: code, [INFO] [stderr] 68 | | err: err, [INFO] [stderr] 69 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Status { [INFO] [stderr] 67 | code: code, [INFO] [stderr] 68 | err: err, [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | const BLOOM_SEED: u32 = 0xbc9f1d34; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbc9f_1d34` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let m: u32 = 0xc6a4a793; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc6a4_a793` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:130:25 [INFO] [stderr] | [INFO] [stderr] 130 | const MASK_DELTA: u32 = 0xa282ead8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa282_ead8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return sep; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/table_reader.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return self.footer.meta_index.offset(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.footer.meta_index.offset()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/table_reader.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | iter [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/table_reader.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | let iter = TableIterator { [INFO] [stderr] | ____________________^ [INFO] [stderr] 156 | | current_block: None, [INFO] [stderr] 157 | | current_block_off: 0, [INFO] [stderr] 158 | | index_block: self.indexblock.iter(), [INFO] [stderr] 159 | | table: self.clone(), [INFO] [stderr] 160 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block_builder.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | restarts: restarts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `restarts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockhandle.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockhandle.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | bits_per_key: bits_per_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_builder.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_builder.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | cache_id: cache_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | footer: footer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `footer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | indexblock: indexblock, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indexblock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/block_builder.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn last_key<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 40 | | &self.last_key [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filter::NoFilterPolicy` [INFO] [stderr] --> src/filter.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> NoFilterPolicy { [INFO] [stderr] 40 | | NoFilterPolicy [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:95:55 [INFO] [stderr] | [INFO] [stderr] 95 | let mut h: u32 = BLOOM_SEED ^ (limit as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | h = (h as u64 + w as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | h = (h as u64 + w as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in data[ix..].iter().enumerate()` or similar iterators [INFO] [stderr] --> src/filter.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | for b in data[ix..].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:113:39 [INFO] [stderr] | [INFO] [stderr] 113 | h = h.overflowing_add((*b as u32) << (8 * i)).0; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:152:33 [INFO] [stderr] | [INFO] [stderr] 152 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/filter.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if filter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:178:18 [INFO] [stderr] | [INFO] [stderr] 178 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:178:29 [INFO] [stderr] | [INFO] [stderr] 178 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/filter_block.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let fbase = data[data.len() - 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[data.len() - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/table_block.rs:69:58 [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(ctype) = options::int_to_compressiontype(compress[0] as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(compress[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cmp.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let mut sep = Vec::from(&a[0..diff_at + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=diff_at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `to`. [INFO] [stderr] --> src/table_builder.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | for i in s1 + s2..FOOTER_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for in to.iter_mut().take(FOOTER_LENGTH).skip(s1 + s2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/table_builder.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | for i in FOOTER_LENGTH..FULL_FOOTER_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `to[FOOTER_LENGTH..FULL_FOOTER_LENGTH].clone_from_slice(&MAGIC_FOOTER_ENCODED[0..(FULL_FOOTER_LENGTH - FOOTER_LENGTH)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table_builder.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | self.dst.write(&data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table_builder.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | self.dst.write(&[ctype as u8; TABLE_BLOCK_COMPRESS_LEN])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sstable`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return self.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return self.list.count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | return self.cap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / return Status { [INFO] [stderr] 67 | | code: code, [INFO] [stderr] 68 | | err: err, [INFO] [stderr] 69 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Status { [INFO] [stderr] 67 | code: code, [INFO] [stderr] 68 | err: err, [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | const BLOOM_SEED: u32 = 0xbc9f1d34; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbc9f_1d34` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let m: u32 = 0xc6a4a793; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc6a4_a793` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:287:40 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(fp.bloom_hash(&d1), 0xef1345c4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xef13_45c4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:288:40 [INFO] [stderr] | [INFO] [stderr] 288 | assert_eq!(fp.bloom_hash(&d2), 0x5b663814); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5b66_3814` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:289:40 [INFO] [stderr] | [INFO] [stderr] 289 | assert_eq!(fp.bloom_hash(&d3), 0x323c078f); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x323c_078f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:290:40 [INFO] [stderr] | [INFO] [stderr] 290 | assert_eq!(fp.bloom_hash(&d4), 0xed21633a); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xed21_633a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:130:25 [INFO] [stderr] | [INFO] [stderr] 130 | const MASK_DELTA: u32 = 0xa282ead8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa282_ead8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return sep; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/table_reader.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return self.footer.meta_index.offset(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.footer.meta_index.offset()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/table_reader.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | iter [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/table_reader.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | let iter = TableIterator { [INFO] [stderr] | ____________________^ [INFO] [stderr] 156 | | current_block: None, [INFO] [stderr] 157 | | current_block_off: 0, [INFO] [stderr] 158 | | index_block: self.indexblock.iter(), [INFO] [stderr] 159 | | table: self.clone(), [INFO] [stderr] 160 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_util.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / return TestSSIter { [INFO] [stderr] 16 | | v: c, [INFO] [stderr] 17 | | ix: 0, [INFO] [stderr] 18 | | init: false, [INFO] [stderr] 19 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | TestSSIter { [INFO] [stderr] 16 | v: c, [INFO] [stderr] 17 | ix: 0, [INFO] [stderr] 18 | init: false, [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:312:14 [INFO] [stderr] | [INFO] [stderr] 312 | ("key1".as_bytes(), "value1".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:312:33 [INFO] [stderr] | [INFO] [stderr] 312 | ("key1".as_bytes(), "value1".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:314:17 [INFO] [stderr] | [INFO] [stderr] 314 | "loooooooooooooooooooooooooooooooooongerkey1".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"loooooooooooooooooooooooooooooooooongerkey1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:315:17 [INFO] [stderr] | [INFO] [stderr] 315 | "shrtvl1".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"shrtvl1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:317:14 [INFO] [stderr] | [INFO] [stderr] 317 | ("medium length key 1".as_bytes(), "some value 2".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"medium length key 1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:317:48 [INFO] [stderr] | [INFO] [stderr] 317 | ("medium length key 1".as_bytes(), "some value 2".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"some value 2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:318:14 [INFO] [stderr] | [INFO] [stderr] 318 | ("prefix_key1".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:318:40 [INFO] [stderr] | [INFO] [stderr] 318 | ("prefix_key1".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:319:14 [INFO] [stderr] | [INFO] [stderr] 319 | ("prefix_key2".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:319:40 [INFO] [stderr] | [INFO] [stderr] 319 | ("prefix_key2".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:320:14 [INFO] [stderr] | [INFO] [stderr] 320 | ("prefix_key3".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:320:40 [INFO] [stderr] | [INFO] [stderr] 320 | ("prefix_key3".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:396:19 [INFO] [stderr] | [INFO] [stderr] 396 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:396:47 [INFO] [stderr] | [INFO] [stderr] 396 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:405:19 [INFO] [stderr] | [INFO] [stderr] 405 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:405:47 [INFO] [stderr] | [INFO] [stderr] 405 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:419:17 [INFO] [stderr] | [INFO] [stderr] 419 | "prefix_key2".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | block.seek(&"prefix_key2".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:446:17 [INFO] [stderr] | [INFO] [stderr] 446 | "prefix_key2".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:447:17 [INFO] [stderr] | [INFO] [stderr] 447 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:451:21 [INFO] [stderr] | [INFO] [stderr] 451 | block.seek(&"prefix_key0".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:456:17 [INFO] [stderr] | [INFO] [stderr] 456 | "prefix_key1".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:457:17 [INFO] [stderr] | [INFO] [stderr] 457 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:461:21 [INFO] [stderr] | [INFO] [stderr] 461 | block.seek(&"key1".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:465:19 [INFO] [stderr] | [INFO] [stderr] 465 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:465:47 [INFO] [stderr] | [INFO] [stderr] 465 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:468:21 [INFO] [stderr] | [INFO] [stderr] 468 | block.seek(&"prefix_key3".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:473:17 [INFO] [stderr] | [INFO] [stderr] 473 | "prefix_key3".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:474:17 [INFO] [stderr] | [INFO] [stderr] 474 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:478:21 [INFO] [stderr] | [INFO] [stderr] 478 | block.seek(&"prefix_key8".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key8"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/block.rs:488:39 [INFO] [stderr] | [INFO] [stderr] 488 | for block_restart_interval in vec![2, 6, 10] { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2, 6, 10]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:507:21 [INFO] [stderr] | [INFO] [stderr] 507 | "prefix_key3".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:508:21 [INFO] [stderr] | [INFO] [stderr] 508 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/block_builder.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn last_key<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 40 | | &self.last_key [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:120:14 [INFO] [stderr] | [INFO] [stderr] 120 | ("key1".as_bytes(), "value1".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | ("key1".as_bytes(), "value1".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | "loooooooooooooooooooooooooooooooooongerkey1".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"loooooooooooooooooooooooooooooooooongerkey1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | "shrtvl1".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"shrtvl1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:125:14 [INFO] [stderr] | [INFO] [stderr] 125 | ("medium length key 1".as_bytes(), "some value 2".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"medium length key 1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:125:48 [INFO] [stderr] | [INFO] [stderr] 125 | ("medium length key 1".as_bytes(), "some value 2".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"some value 2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:126:14 [INFO] [stderr] | [INFO] [stderr] 126 | ("prefix_key1".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:126:40 [INFO] [stderr] | [INFO] [stderr] 126 | ("prefix_key1".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:127:14 [INFO] [stderr] | [INFO] [stderr] 127 | ("prefix_key2".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:127:40 [INFO] [stderr] | [INFO] [stderr] 127 | ("prefix_key2".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:128:14 [INFO] [stderr] | [INFO] [stderr] 128 | ("prefix_key3".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:128:40 [INFO] [stderr] | [INFO] [stderr] 128 | ("prefix_key3".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:354:20 [INFO] [stderr] | [INFO] [stderr] 354 | assert_eq!(lru._testing_head_ref().map(|r| (*r)).unwrap(), 244); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:358:20 [INFO] [stderr] | [INFO] [stderr] 358 | assert_eq!(lru._testing_head_ref().map(|r| (*r)).unwrap(), 56); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:362:20 [INFO] [stderr] | [INFO] [stderr] 362 | assert_eq!(lru._testing_head_ref().map(|r| (*r)).unwrap(), 244); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:366:20 [INFO] [stderr] | [INFO] [stderr] 366 | assert_eq!(lru._testing_head_ref().map(|r| (*r)).unwrap(), 22); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `handles` [INFO] [stderr] --> src/cache.rs:389:18 [INFO] [stderr] | [INFO] [stderr] 389 | for i in 0..9 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 389 | for (i, ) in handles.iter().enumerate().take(9) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:391:24 [INFO] [stderr] | [INFO] [stderr] 391 | assert_eq!(lru._testing_head_ref().map(|x| *x), Some(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:402:20 [INFO] [stderr] | [INFO] [stderr] 402 | assert_eq!(lru._testing_head_ref().map(|x| *x), Some(3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filter::NoFilterPolicy` [INFO] [stderr] --> src/filter.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> NoFilterPolicy { [INFO] [stderr] 40 | | NoFilterPolicy [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:95:55 [INFO] [stderr] | [INFO] [stderr] 95 | let mut h: u32 = BLOOM_SEED ^ (limit as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | h = (h as u64 + w as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | h = (h as u64 + w as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in data[ix..].iter().enumerate()` or similar iterators [INFO] [stderr] --> src/filter.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | for b in data[ix..].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:113:39 [INFO] [stderr] | [INFO] [stderr] 113 | h = h.overflowing_add((*b as u32) << (8 * i)).0; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:152:33 [INFO] [stderr] | [INFO] [stderr] 152 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/filter.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if filter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:178:18 [INFO] [stderr] | [INFO] [stderr] 178 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:178:29 [INFO] [stderr] | [INFO] [stderr] 178 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | "abc123def456".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc123def456"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | "xxx111xxx222".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xxx111xxx222"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | "ab00cd00ab".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab00cd00ab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | "908070605040302010".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"908070605040302010"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/filter_block.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let fbase = data[data.len() - 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[data.len() - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | "abcd".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | "efgh".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"efgh"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | "ijkl".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ijkl"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | "mnopqrstuvwxyz".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"mnopqrstuvwxyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | "xsb".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xsb"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | "9sad".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"9sad"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | "assssaaaass".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"assssaaaass"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/table_block.rs:69:58 [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(ctype) = options::int_to_compressiontype(compress[0] as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(compress[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cmp.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let mut sep = Vec::from(&a[0..diff_at + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=diff_at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:88:49 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(DefaultCmp.find_shortest_sep("abcd".as_bytes(), "abcf".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:88:68 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(DefaultCmp.find_shortest_sep("abcd".as_bytes(), "abcf".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | "abce".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abce"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(DefaultCmp.find_shortest_sep("abc".as_bytes(), "acd".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:90:67 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(DefaultCmp.find_shortest_sep("abc".as_bytes(), "acd".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"acd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:92:49 [INFO] [stderr] | [INFO] [stderr] 92 | assert_eq!(DefaultCmp.find_shortest_sep("abcdefghi".as_bytes(), "abcffghi".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcdefghi"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:92:73 [INFO] [stderr] | [INFO] [stderr] 92 | assert_eq!(DefaultCmp.find_shortest_sep("abcdefghi".as_bytes(), "abcffghi".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcffghi"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:93:20 [INFO] [stderr] | [INFO] [stderr] 93 | "abce".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abce"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:94:49 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(DefaultCmp.find_shortest_sep("a".as_bytes(), "a".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:94:65 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(DefaultCmp.find_shortest_sep("a".as_bytes(), "a".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | "a".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:96:49 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(DefaultCmp.find_shortest_sep("a".as_bytes(), "b".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:96:65 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(DefaultCmp.find_shortest_sep("a".as_bytes(), "b".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:98:49 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(DefaultCmp.find_shortest_sep("abc".as_bytes(), "zzz".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:98:67 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(DefaultCmp.find_shortest_sep("abc".as_bytes(), "zzz".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | "b".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:100:49 [INFO] [stderr] | [INFO] [stderr] 100 | assert_eq!(DefaultCmp.find_shortest_sep("yyy".as_bytes(), "z".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"yyy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:100:67 [INFO] [stderr] | [INFO] [stderr] 100 | assert_eq!(DefaultCmp.find_shortest_sep("yyy".as_bytes(), "z".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"z"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:102:49 [INFO] [stderr] | [INFO] [stderr] 102 | assert_eq!(DefaultCmp.find_shortest_sep("".as_bytes(), "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:102:64 [INFO] [stderr] | [INFO] [stderr] 102 | assert_eq!(DefaultCmp.find_shortest_sep("".as_bytes(), "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:103:20 [INFO] [stderr] | [INFO] [stderr] 103 | "".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:108:47 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(DefaultCmp.find_short_succ("abcd".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | "b".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:110:47 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(DefaultCmp.find_short_succ("zzzz".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | "{".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `to`. [INFO] [stderr] --> src/table_builder.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | for i in s1 + s2..FOOTER_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for in to.iter_mut().take(FOOTER_LENGTH).skip(s1 + s2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/table_builder.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | for i in FOOTER_LENGTH..FULL_FOOTER_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `to[FOOTER_LENGTH..FULL_FOOTER_LENGTH].clone_from_slice(&MAGIC_FOOTER_ENCODED[0..(FULL_FOOTER_LENGTH - FOOTER_LENGTH)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table_builder.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | self.dst.write(&data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table_builder.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | self.dst.write(&[ctype as u8; TABLE_BLOCK_COMPRESS_LEN])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in SSIteratorIter::wrap(&mut iter).enumerate()` or similar iterators [INFO] [stderr] --> src/table_reader.rs:411:23 [INFO] [stderr] | [INFO] [stderr] 411 | for (k, _) in SSIteratorIter::wrap(&mut iter) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/table_reader.rs:417:48 [INFO] [stderr] | [INFO] [stderr] 417 | assert_eq!(137, table.approx_offset_of("{aa".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{aa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/table_reader.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | / loop { [INFO] [stderr] 502 | | if let Some((k, _)) = iter.next() { [INFO] [stderr] 503 | | assert!(filter_reader.key_may_match(iter.current_block_off, &k)); [INFO] [stderr] 504 | | assert!(!filter_reader.key_may_match(iter.current_block_off, b"somerandomkey")); [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((k, _)) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/table_reader.rs:606:19 [INFO] [stderr] | [INFO] [stderr] 606 | iter.seek("{{{".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{{{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/table_reader.rs:637:27 [INFO] [stderr] | [INFO] [stderr] 637 | assert!(table.get("zz{".as_bytes()).unwrap().is_none()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zz{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/test_util.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn test_iterator_properties(mut it: It) { [INFO] [stderr] 94 | | assert!(!it.valid()); [INFO] [stderr] 95 | | assert!(it.advance()); [INFO] [stderr] 96 | | assert!(it.valid()); [INFO] [stderr] ... | [INFO] [stderr] 131 | | assert!(!it.valid()); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:141:32 [INFO] [stderr] | [INFO] [stderr] 141 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | ("abd".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | ("abd".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"deg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:147:29 [INFO] [stderr] | [INFO] [stderr] 147 | Some((Vec::from("abc".as_bytes()), Vec::from("def".as_bytes()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:147:58 [INFO] [stderr] | [INFO] [stderr] 147 | Some((Vec::from("abc".as_bytes()), Vec::from("def".as_bytes()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:158:36 [INFO] [stderr] | [INFO] [stderr] 158 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:159:18 [INFO] [stderr] | [INFO] [stderr] 159 | ("abd".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:159:36 [INFO] [stderr] | [INFO] [stderr] 159 | ("abd".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"deg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | ("abe".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:160:36 [INFO] [stderr] | [INFO] [stderr] 160 | ("abe".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"deg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | ("abf".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:161:36 [INFO] [stderr] | [INFO] [stderr] 161 | ("abf".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"deg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sstable`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "983c088878a182cab5c2ec9274a89d09ac9a406ede2f293471106dc28d699143"` [INFO] running `"docker" "rm" "-f" "983c088878a182cab5c2ec9274a89d09ac9a406ede2f293471106dc28d699143"` [INFO] [stdout] 983c088878a182cab5c2ec9274a89d09ac9a406ede2f293471106dc28d699143