[INFO] crate ssh-keys 0.1.3 is already in cache [INFO] extracting crate ssh-keys 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/ssh-keys/0.1.3 [INFO] extracting crate ssh-keys 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ssh-keys/0.1.3 [INFO] validating manifest of ssh-keys-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ssh-keys-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ssh-keys-0.1.3 [INFO] finished frobbing ssh-keys-0.1.3 [INFO] frobbed toml for ssh-keys-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/ssh-keys/0.1.3/Cargo.toml [INFO] started frobbing ssh-keys-0.1.3 [INFO] finished frobbing ssh-keys-0.1.3 [INFO] frobbed toml for ssh-keys-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ssh-keys/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ssh-keys-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ssh-keys/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9793fa9c041ee80fa835154b1990ca6d62f7bad07183ad944ace1e87165a2bd4 [INFO] running `"docker" "start" "-a" "9793fa9c041ee80fa835154b1990ca6d62f7bad07183ad944ace1e87165a2bd4"` [INFO] [stderr] Checking ssh-keys v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/openssh.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | let q = items.read_big_int()?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/openssh.rs:157:33 [INFO] [stderr] | [INFO] [stderr] 157 | let q = pcur.read_bytes()?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openssh.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openssh.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/openssh.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | let q = items.read_big_int()?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/openssh.rs:157:33 [INFO] [stderr] | [INFO] [stderr] 157 | let q = pcur.read_bytes()?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openssh.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openssh.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / return Ok(vec![PrivateKey::Rsa { [INFO] [stderr] 105 | | n: n.to_vec(), e: e.to_vec(), d: d.to_vec(), [INFO] [stderr] 106 | | iqmp: iqmp.to_vec(), [INFO] [stderr] 107 | | p: p.to_vec(), q: q.to_vec(), [INFO] [stderr] 108 | | }]); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 104 | Ok(vec![PrivateKey::Rsa { [INFO] [stderr] 105 | n: n.to_vec(), e: e.to_vec(), d: d.to_vec(), [INFO] [stderr] 106 | iqmp: iqmp.to_vec(), [INFO] [stderr] 107 | p: p.to_vec(), q: q.to_vec(), [INFO] [stderr] 108 | }]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | _ => return Err(Error::UnsupportedType(kind.to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnsupportedType(kind.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | return Ok(BigEndian::read_u32(&cur[..4])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BigEndian::read_u32(&cur[..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | return Ok(&cur[4..len+4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(&cur[4..len+4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | return Ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | return Ok(data[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / return Ok(vec![PrivateKey::Rsa { [INFO] [stderr] 105 | | n: n.to_vec(), e: e.to_vec(), d: d.to_vec(), [INFO] [stderr] 106 | | iqmp: iqmp.to_vec(), [INFO] [stderr] 107 | | p: p.to_vec(), q: q.to_vec(), [INFO] [stderr] 108 | | }]); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 104 | Ok(vec![PrivateKey::Rsa { [INFO] [stderr] 105 | n: n.to_vec(), e: e.to_vec(), d: d.to_vec(), [INFO] [stderr] 106 | iqmp: iqmp.to_vec(), [INFO] [stderr] 107 | p: p.to_vec(), q: q.to_vec(), [INFO] [stderr] 108 | }]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | _ => return Err(Error::UnsupportedType(kind.to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnsupportedType(kind.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | return Ok(BigEndian::read_u32(&cur[..4])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BigEndian::read_u32(&cur[..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | return Ok(&cur[4..len+4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(&cur[4..len+4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | return Ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/openssh.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | return Ok(data[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/stdimpls.rs:95:53 [INFO] [stderr] | [INFO] [stderr] 95 | (&Ed25519(ref d1), &Ed25519(ref d2)) => &d1[..] == &d2[..], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 95 | (&Ed25519(ref d1), &Ed25519(ref d2)) => d1[..] == d2[..], [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/conversion.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | / match self { [INFO] [stderr] 8 | | &PrivateKey::Ed25519(data) => { [INFO] [stderr] 9 | | let mut ar = [0u8; 32]; [INFO] [stderr] 10 | | ar.copy_from_slice(&data[32..]); [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 7 | match *self { [INFO] [stderr] 8 | PrivateKey::Ed25519(data) => { [INFO] [stderr] 9 | let mut ar = [0u8; 32]; [INFO] [stderr] 10 | ar.copy_from_slice(&data[32..]); [INFO] [stderr] 11 | PublicKey::Ed25519(ar) [INFO] [stderr] 12 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/openssh.rs:40:8 [INFO] [stderr] | [INFO] [stderr] 40 | if int_kind != int_kind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 5)` [INFO] [stderr] --> src/openssh.rs:252:20 [INFO] [stderr] | [INFO] [stderr] 252 | if byte != (0 << 6) | (1 << 5) | 16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2` [INFO] [stderr] --> src/openssh.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | if byte != (0 << 6) | (0 << 5) | 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `|` [INFO] [stderr] --> src/openssh.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | if byte != (0 << 6) | (0 << 5) | 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0 << 5)` [INFO] [stderr] --> src/openssh.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | if byte != (0 << 6) | (0 << 5) | 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0 << 6)` [INFO] [stderr] --> src/openssh.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | if byte != (0 << 6) | (0 << 5) | 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ssh-keys`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/stdimpls.rs:95:53 [INFO] [stderr] | [INFO] [stderr] 95 | (&Ed25519(ref d1), &Ed25519(ref d2)) => &d1[..] == &d2[..], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 95 | (&Ed25519(ref d1), &Ed25519(ref d2)) => d1[..] == d2[..], [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/conversion.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | / match self { [INFO] [stderr] 8 | | &PrivateKey::Ed25519(data) => { [INFO] [stderr] 9 | | let mut ar = [0u8; 32]; [INFO] [stderr] 10 | | ar.copy_from_slice(&data[32..]); [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 7 | match *self { [INFO] [stderr] 8 | PrivateKey::Ed25519(data) => { [INFO] [stderr] 9 | let mut ar = [0u8; 32]; [INFO] [stderr] 10 | ar.copy_from_slice(&data[32..]); [INFO] [stderr] 11 | PublicKey::Ed25519(ar) [INFO] [stderr] 12 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/openssh.rs:40:8 [INFO] [stderr] | [INFO] [stderr] 40 | if int_kind != int_kind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 5)` [INFO] [stderr] --> src/openssh.rs:252:20 [INFO] [stderr] | [INFO] [stderr] 252 | if byte != (0 << 6) | (1 << 5) | 16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2` [INFO] [stderr] --> src/openssh.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | if byte != (0 << 6) | (0 << 5) | 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `|` [INFO] [stderr] --> src/openssh.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | if byte != (0 << 6) | (0 << 5) | 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0 << 5)` [INFO] [stderr] --> src/openssh.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | if byte != (0 << 6) | (0 << 5) | 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0 << 6)` [INFO] [stderr] --> src/openssh.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | if byte != (0 << 6) | (0 << 5) | 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ssh-keys`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9793fa9c041ee80fa835154b1990ca6d62f7bad07183ad944ace1e87165a2bd4"` [INFO] running `"docker" "rm" "-f" "9793fa9c041ee80fa835154b1990ca6d62f7bad07183ad944ace1e87165a2bd4"` [INFO] [stdout] 9793fa9c041ee80fa835154b1990ca6d62f7bad07183ad944ace1e87165a2bd4