[INFO] crate ssd1325 0.1.0 is already in cache
[INFO] extracting crate ssd1325 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ssd1325/0.1.0
[INFO] extracting crate ssd1325 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ssd1325/0.1.0
[INFO] validating manifest of ssd1325-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ssd1325-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ssd1325-0.1.0
[INFO] finished frobbing ssd1325-0.1.0
[INFO] frobbed toml for ssd1325-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ssd1325/0.1.0/Cargo.toml
[INFO] started frobbing ssd1325-0.1.0
[INFO] finished frobbing ssd1325-0.1.0
[INFO] frobbed toml for ssd1325-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ssd1325/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ssd1325-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ssd1325/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 092d4b977092c58dcc61945fdb168505f8024caa3b39b26606b09f5cb543e6a3
[INFO] running `"docker" "start" "-a" "092d4b977092c58dcc61945fdb168505f8024caa3b39b26606b09f5cb543e6a3"`
[INFO] [stderr]     Checking ssd1325 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:196:7
[INFO] [stderr]     |
[INFO] [stderr] 196 |       transport: transport,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:197:7
[INFO] [stderr]     |
[INFO] [stderr] 197 |       control_channel: control_channel,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_channel`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:196:7
[INFO] [stderr]     |
[INFO] [stderr] 196 |       transport: transport,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:197:7
[INFO] [stderr]     |
[INFO] [stderr] 197 |       control_channel: control_channel,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_channel`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:206:27
[INFO] [stderr]     |
[INFO] [stderr] 206 |     const INIT_SEQUENCE: &'static [u8] = &[
[INFO] [stderr]     |                          -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:257:28
[INFO] [stderr]     |
[INFO] [stderr] 257 |     const CLEAR_SEQUENCE: &'static [u8] = &[
[INFO] [stderr]     |                           -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:294:36
[INFO] [stderr]     |
[INFO] [stderr] 294 |     const BLIT_PREAMBLE_SEQUENCE: &'static [u8] = &[
[INFO] [stderr]     |                                   -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:151:5
[INFO] [stderr]     |
[INFO] [stderr] 151 | /     match self {
[INFO] [stderr] 152 | |       &DisplayError::WriteFailed =>
[INFO] [stderr] 153 | |         "write failed: unable to send complete sequence to display",
[INFO] [stderr] 154 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 151 |     match *self {
[INFO] [stderr] 152 |       DisplayError::WriteFailed =>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:206:27
[INFO] [stderr]     |
[INFO] [stderr] 206 |     const INIT_SEQUENCE: &'static [u8] = &[
[INFO] [stderr]     |                          -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:257:28
[INFO] [stderr]     |
[INFO] [stderr] 257 |     const CLEAR_SEQUENCE: &'static [u8] = &[
[INFO] [stderr]     |                           -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:294:36
[INFO] [stderr]     |
[INFO] [stderr] 294 |     const BLIT_PREAMBLE_SEQUENCE: &'static [u8] = &[
[INFO] [stderr]     |                                   -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:378:31
[INFO] [stderr]     |
[INFO] [stderr] 378 |     unpack_pixels_for_display(0b00000000, &mut buffer);
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:380:31
[INFO] [stderr]     |
[INFO] [stderr] 380 |     unpack_pixels_for_display(0b00001111, &mut buffer);
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b0000_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:382:31
[INFO] [stderr]     |
[INFO] [stderr] 382 |     unpack_pixels_for_display(0b11110000, &mut buffer);
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b1111_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:384:31
[INFO] [stderr]     |
[INFO] [stderr] 384 |     unpack_pixels_for_display(0b10100110, &mut buffer);
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b1010_0110`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:386:31
[INFO] [stderr]     |
[INFO] [stderr] 386 |     unpack_pixels_for_display(0b01100101, &mut buffer);
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b0110_0101`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:393:7
[INFO] [stderr]     |
[INFO] [stderr] 393 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |       ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:393:19
[INFO] [stderr]     |
[INFO] [stderr] 393 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                   ^^^^^^^^^^ help: consider: `0b0000_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:393:31
[INFO] [stderr]     |
[INFO] [stderr] 393 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b1111_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:393:43
[INFO] [stderr]     |
[INFO] [stderr] 393 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b1010_0110`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:394:7
[INFO] [stderr]     |
[INFO] [stderr] 394 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |       ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:394:19
[INFO] [stderr]     |
[INFO] [stderr] 394 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                   ^^^^^^^^^^ help: consider: `0b0000_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:394:31
[INFO] [stderr]     |
[INFO] [stderr] 394 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b1111_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:394:43
[INFO] [stderr]     |
[INFO] [stderr] 394 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b1010_0110`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:395:7
[INFO] [stderr]     |
[INFO] [stderr] 395 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |       ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:395:19
[INFO] [stderr]     |
[INFO] [stderr] 395 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                   ^^^^^^^^^^ help: consider: `0b0000_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:395:31
[INFO] [stderr]     |
[INFO] [stderr] 395 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b1111_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:395:43
[INFO] [stderr]     |
[INFO] [stderr] 395 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b1010_0110`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:396:7
[INFO] [stderr]     |
[INFO] [stderr] 396 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |       ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:396:19
[INFO] [stderr]     |
[INFO] [stderr] 396 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                   ^^^^^^^^^^ help: consider: `0b0000_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:396:31
[INFO] [stderr]     |
[INFO] [stderr] 396 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                               ^^^^^^^^^^ help: consider: `0b1111_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:396:43
[INFO] [stderr]     |
[INFO] [stderr] 396 |       0b00000000, 0b00001111, 0b11110000, 0b10100110,
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b1010_0110`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:268:5
[INFO] [stderr]     |
[INFO] [stderr] 268 | /     match on {
[INFO] [stderr] 269 | |       true =>
[INFO] [stderr] 270 | |         self.write_sequence(DisplayMode::Command, &[commands::DISPLAYON]),
[INFO] [stderr] 271 | |       false =>
[INFO] [stderr] 272 | |         self.write_sequence(DisplayMode::Command, &[commands::DISPLAYOFF]),
[INFO] [stderr] 273 | |     }
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if on { self.write_sequence(DisplayMode::Command, &[commands::DISPLAYON]) } else { self.write_sequence(DisplayMode::Command, &[commands::DISPLAYOFF]) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:278:5
[INFO] [stderr]     |
[INFO] [stderr] 278 | /     match inverted {
[INFO] [stderr] 279 | |       true =>
[INFO] [stderr] 280 | |         self.write_sequence(DisplayMode::Command, &[commands::INVERTDISPLAY]),
[INFO] [stderr] 281 | |       false =>
[INFO] [stderr] 282 | |         self.write_sequence(DisplayMode::Command, &[commands::NORMALDISPLAY]),
[INFO] [stderr] 283 | |     }
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if inverted { self.write_sequence(DisplayMode::Command, &[commands::INVERTDISPLAY]) } else { self.write_sequence(DisplayMode::Command, &[commands::NORMALDISPLAY]) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:338:49
[INFO] [stderr]     |
[INFO] [stderr] 338 |       let sent = transport.write(bytes).map_err(|e| Box::new(e))?;
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^ help: remove closure as shown: `Box::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `unpacked`.
[INFO] [stderr]    --> src/lib.rs:354:12
[INFO] [stderr]     |
[INFO] [stderr] 354 |   for i in 0..4 {
[INFO] [stderr]     |            ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 354 |   for <item> in unpacked.iter_mut().take(4) {
[INFO] [stderr]     |       ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:151:5
[INFO] [stderr]     |
[INFO] [stderr] 151 | /     match self {
[INFO] [stderr] 152 | |       &DisplayError::WriteFailed =>
[INFO] [stderr] 153 | |         "write failed: unable to send complete sequence to display",
[INFO] [stderr] 154 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 151 |     match *self {
[INFO] [stderr] 152 |       DisplayError::WriteFailed =>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:268:5
[INFO] [stderr]     |
[INFO] [stderr] 268 | /     match on {
[INFO] [stderr] 269 | |       true =>
[INFO] [stderr] 270 | |         self.write_sequence(DisplayMode::Command, &[commands::DISPLAYON]),
[INFO] [stderr] 271 | |       false =>
[INFO] [stderr] 272 | |         self.write_sequence(DisplayMode::Command, &[commands::DISPLAYOFF]),
[INFO] [stderr] 273 | |     }
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if on { self.write_sequence(DisplayMode::Command, &[commands::DISPLAYON]) } else { self.write_sequence(DisplayMode::Command, &[commands::DISPLAYOFF]) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:278:5
[INFO] [stderr]     |
[INFO] [stderr] 278 | /     match inverted {
[INFO] [stderr] 279 | |       true =>
[INFO] [stderr] 280 | |         self.write_sequence(DisplayMode::Command, &[commands::INVERTDISPLAY]),
[INFO] [stderr] 281 | |       false =>
[INFO] [stderr] 282 | |         self.write_sequence(DisplayMode::Command, &[commands::NORMALDISPLAY]),
[INFO] [stderr] 283 | |     }
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if inverted { self.write_sequence(DisplayMode::Command, &[commands::INVERTDISPLAY]) } else { self.write_sequence(DisplayMode::Command, &[commands::NORMALDISPLAY]) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:338:49
[INFO] [stderr]     |
[INFO] [stderr] 338 |       let sent = transport.write(bytes).map_err(|e| Box::new(e))?;
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^ help: remove closure as shown: `Box::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `unpacked`.
[INFO] [stderr]    --> src/lib.rs:354:12
[INFO] [stderr]     |
[INFO] [stderr] 354 |   for i in 0..4 {
[INFO] [stderr]     |            ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 354 |   for <item> in unpacked.iter_mut().take(4) {
[INFO] [stderr]     |       ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.64s
[INFO] running `"docker" "inspect" "092d4b977092c58dcc61945fdb168505f8024caa3b39b26606b09f5cb543e6a3"`
[INFO] running `"docker" "rm" "-f" "092d4b977092c58dcc61945fdb168505f8024caa3b39b26606b09f5cb543e6a3"`
[INFO] [stdout] 092d4b977092c58dcc61945fdb168505f8024caa3b39b26606b09f5cb543e6a3