[INFO] crate srv-shim 0.1.2 is already in cache [INFO] extracting crate srv-shim 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/srv-shim/0.1.2 [INFO] extracting crate srv-shim 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/srv-shim/0.1.2 [INFO] validating manifest of srv-shim-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of srv-shim-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing srv-shim-0.1.2 [INFO] finished frobbing srv-shim-0.1.2 [INFO] frobbed toml for srv-shim-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/srv-shim/0.1.2/Cargo.toml [INFO] started frobbing srv-shim-0.1.2 [INFO] finished frobbing srv-shim-0.1.2 [INFO] frobbed toml for srv-shim-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/srv-shim/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting srv-shim-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/srv-shim/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f94933bb70543e7786c3a50a441dbbe57d301317b0f301a92a3900602368901f [INFO] running `"docker" "start" "-a" "f94933bb70543e7786c3a50a441dbbe57d301317b0f301a92a3900602368901f"` [INFO] [stderr] Checking plumber v0.0.6 [INFO] [stderr] Checking srv-shim v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/srvhook.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / iph.get(&ip).map(|h| { [INFO] [stderr] 57 | | srv_mapper(h).map( |(new_port, new_ip)| { [INFO] [stderr] 58 | | unsafe { [INFO] [stderr] 59 | | // only override host and IP for AF_INET [INFO] [stderr] ... | [INFO] [stderr] 68 | | }); [INFO] [stderr] 69 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(h) = iph.get(&ip) { srv_mapper(h).map( |(new_port, new_ip)| { [INFO] [stderr] 57 | unsafe { [INFO] [stderr] 58 | // only override host and IP for AF_INET [INFO] [stderr] 59 | if (*address).sa_family == 2 { [INFO] [stderr] 60 | (*address).sa_data = [INFO] [stderr] 61 | port_ip_to_sa_data(new_port, new_ip); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/srvhook.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | / srv_mapper(h).map( |(new_port, new_ip)| { [INFO] [stderr] 58 | | unsafe { [INFO] [stderr] 59 | | // only override host and IP for AF_INET [INFO] [stderr] 60 | | if (*address).sa_family == 2 { [INFO] [stderr] ... | [INFO] [stderr] 67 | | Err(e) [INFO] [stderr] 68 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | (self.real_connect)(socket, address, len) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:91:40 [INFO] [stderr] | [INFO] [stderr] 91 | (self.real_sendto)(socket, msg, msglen, flags, dest_addr) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:91:60 [INFO] [stderr] | [INFO] [stderr] 91 | (self.real_sendto)(socket, msg, msglen, flags, dest_addr) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:97:45 [INFO] [stderr] | [INFO] [stderr] 97 | let c_str = unsafe { CStr::from_ptr(node) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | *res = ai_buf; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:141:41 [INFO] [stderr] | [INFO] [stderr] 141 | (self.real_getaddrinfo)(node, service, hints, res) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:141:47 [INFO] [stderr] | [INFO] [stderr] 141 | (self.real_getaddrinfo)(node, service, hints, res) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:141:56 [INFO] [stderr] | [INFO] [stderr] 141 | (self.real_getaddrinfo)(node, service, hints, res) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:141:63 [INFO] [stderr] | [INFO] [stderr] 141 | (self.real_getaddrinfo)(node, service, hints, res) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/srvhook.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | if node_str.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/srvhook.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | / mem::transmute( [INFO] [stderr] 115 | | libc::malloc(mem::size_of::() as size_t) [INFO] [stderr] 116 | | ); [INFO] [stderr] | |_____________________^ help: try: `libc::malloc(mem::size_of::() as size_t) as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/srvhook.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | / mem::transmute( [INFO] [stderr] 124 | | libc::malloc(mem::size_of::() as size_t) [INFO] [stderr] 125 | | ); [INFO] [stderr] | |_____________________^ help: try: `libc::malloc(mem::size_of::() as size_t) as *mut libc::addrinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/srvhook.rs:133:35 [INFO] [stderr] | [INFO] [stderr] 133 | ai_canonname: 0 as *mut i8, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/srvhook.rs:134:30 [INFO] [stderr] | [INFO] [stderr] 134 | ai_next: 0 as *mut addrinfo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `srv-shim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/srvhook.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / iph.get(&ip).map(|h| { [INFO] [stderr] 57 | | srv_mapper(h).map( |(new_port, new_ip)| { [INFO] [stderr] 58 | | unsafe { [INFO] [stderr] 59 | | // only override host and IP for AF_INET [INFO] [stderr] ... | [INFO] [stderr] 68 | | }); [INFO] [stderr] 69 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(h) = iph.get(&ip) { srv_mapper(h).map( |(new_port, new_ip)| { [INFO] [stderr] 57 | unsafe { [INFO] [stderr] 58 | // only override host and IP for AF_INET [INFO] [stderr] 59 | if (*address).sa_family == 2 { [INFO] [stderr] 60 | (*address).sa_data = [INFO] [stderr] 61 | port_ip_to_sa_data(new_port, new_ip); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/srvhook.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | / srv_mapper(h).map( |(new_port, new_ip)| { [INFO] [stderr] 58 | | unsafe { [INFO] [stderr] 59 | | // only override host and IP for AF_INET [INFO] [stderr] 60 | | if (*address).sa_family == 2 { [INFO] [stderr] ... | [INFO] [stderr] 67 | | Err(e) [INFO] [stderr] 68 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | (self.real_connect)(socket, address, len) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:91:40 [INFO] [stderr] | [INFO] [stderr] 91 | (self.real_sendto)(socket, msg, msglen, flags, dest_addr) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:91:60 [INFO] [stderr] | [INFO] [stderr] 91 | (self.real_sendto)(socket, msg, msglen, flags, dest_addr) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:97:45 [INFO] [stderr] | [INFO] [stderr] 97 | let c_str = unsafe { CStr::from_ptr(node) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | *res = ai_buf; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:141:41 [INFO] [stderr] | [INFO] [stderr] 141 | (self.real_getaddrinfo)(node, service, hints, res) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:141:47 [INFO] [stderr] | [INFO] [stderr] 141 | (self.real_getaddrinfo)(node, service, hints, res) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:141:56 [INFO] [stderr] | [INFO] [stderr] 141 | (self.real_getaddrinfo)(node, service, hints, res) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/srvhook.rs:141:63 [INFO] [stderr] | [INFO] [stderr] 141 | (self.real_getaddrinfo)(node, service, hints, res) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/srvhook.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | if node_str.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/srvhook.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | / mem::transmute( [INFO] [stderr] 115 | | libc::malloc(mem::size_of::() as size_t) [INFO] [stderr] 116 | | ); [INFO] [stderr] | |_____________________^ help: try: `libc::malloc(mem::size_of::() as size_t) as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/srvhook.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | / mem::transmute( [INFO] [stderr] 124 | | libc::malloc(mem::size_of::() as size_t) [INFO] [stderr] 125 | | ); [INFO] [stderr] | |_____________________^ help: try: `libc::malloc(mem::size_of::() as size_t) as *mut libc::addrinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/srvhook.rs:133:35 [INFO] [stderr] | [INFO] [stderr] 133 | ai_canonname: 0 as *mut i8, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/srvhook.rs:134:30 [INFO] [stderr] | [INFO] [stderr] 134 | ai_next: 0 as *mut addrinfo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `srv-shim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f94933bb70543e7786c3a50a441dbbe57d301317b0f301a92a3900602368901f"` [INFO] running `"docker" "rm" "-f" "f94933bb70543e7786c3a50a441dbbe57d301317b0f301a92a3900602368901f"` [INFO] [stdout] f94933bb70543e7786c3a50a441dbbe57d301317b0f301a92a3900602368901f