[INFO] crate srp 0.3.0 is already in cache [INFO] extracting crate srp 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/srp/0.3.0 [INFO] extracting crate srp 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/srp/0.3.0 [INFO] validating manifest of srp-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of srp-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing srp-0.3.0 [INFO] finished frobbing srp-0.3.0 [INFO] frobbed toml for srp-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/srp/0.3.0/Cargo.toml [INFO] started frobbing srp-0.3.0 [INFO] finished frobbing srp-0.3.0 [INFO] frobbed toml for srp-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/srp/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting srp-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/srp/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d04d5a0d2df80477d59cdbe9f8a0673619e69da9d0c97b46b587960007ccfb46 [INFO] running `"docker" "start" "-a" "d04d5a0d2df80477d59cdbe9f8a0673619e69da9d0c97b46b587960007ccfb46"` [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking srp v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/client.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | let v = if b_pub > &interm { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/client.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let s = powm(&v, &(&self.a + (u * x) % n), n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | server_proof: server_proof, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/server.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let d = Default::default(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/server.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | let t = (&a_pub * powm(&v, &u, ¶ms.n)) % ¶ms.n; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/server.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | let s = powm(&t, &b, ¶ms.n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/client.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | let v = if b_pub > &interm { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/client.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let s = powm(&v, &(&self.a + (u * x) % n), n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | server_proof: server_proof, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/server.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let d = Default::default(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/server.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | let t = (&a_pub * powm(&v, &u, ¶ms.n)) % ¶ms.n; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/server.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | let s = powm(&t, &b, ¶ms.n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/client.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | let v = if b_pub > &interm { [INFO] [stderr] | ^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `interm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tools.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | exp = exp >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `exp >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/client.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | let v = if b_pub > &interm { [INFO] [stderr] | ^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `interm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tools.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | exp = exp >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `exp >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.31s [INFO] running `"docker" "inspect" "d04d5a0d2df80477d59cdbe9f8a0673619e69da9d0c97b46b587960007ccfb46"` [INFO] running `"docker" "rm" "-f" "d04d5a0d2df80477d59cdbe9f8a0673619e69da9d0c97b46b587960007ccfb46"` [INFO] [stdout] d04d5a0d2df80477d59cdbe9f8a0673619e69da9d0c97b46b587960007ccfb46