[INFO] crate squark-stdweb 0.5.0 is already in cache [INFO] extracting crate squark-stdweb 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/squark-stdweb/0.5.0 [INFO] extracting crate squark-stdweb 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/squark-stdweb/0.5.0 [INFO] validating manifest of squark-stdweb-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of squark-stdweb-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing squark-stdweb-0.5.0 [INFO] finished frobbing squark-stdweb-0.5.0 [INFO] frobbed toml for squark-stdweb-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/squark-stdweb/0.5.0/Cargo.toml [INFO] started frobbing squark-stdweb-0.5.0 [INFO] finished frobbing squark-stdweb-0.5.0 [INFO] frobbed toml for squark-stdweb-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/squark-stdweb/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting squark-stdweb-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/squark-stdweb/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7dbee1a8e323498c770dc4ba22a4fda064b7f70ae51e7a120286520fe8f4fb9f [INFO] running `"docker" "start" "-a" "7dbee1a8e323498c770dc4ba22a4fda064b7f70ae51e7a120286520fe8f4fb9f"` [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking squark v0.5.1 [INFO] [stderr] Checking squark-stdweb v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / match value { [INFO] [stderr] 97 | | &AttributeValue::Bool(ref b) => { [INFO] [stderr] 98 | | js! { @{el.clone()}[@{name}] = @{b} }; [INFO] [stderr] 99 | | el.set_attribute(name, &b.to_string()) [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *value { [INFO] [stderr] 97 | AttributeValue::Bool(ref b) => { [INFO] [stderr] 98 | js! { @{el.clone()}[@{name}] = @{b} }; [INFO] [stderr] 99 | el.set_attribute(name, &b.to_string()) [INFO] [stderr] 100 | .expect("Failet to set bool attirbute"); [INFO] [stderr] 101 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in el.children.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | for child in el.children { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | pos.push(i.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:222:36 [INFO] [stderr] | [INFO] [stderr] 222 | fn remove_attached(&self, pos: &Position) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change `pos.clone()` to [INFO] [stderr] | [INFO] [stderr] 223 | let mut max = pos.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: change `pos.clone()` to [INFO] [stderr] | [INFO] [stderr] 227 | let range = (Included(pos.to_owned()), Excluded(max)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / match value { [INFO] [stderr] 97 | | &AttributeValue::Bool(ref b) => { [INFO] [stderr] 98 | | js! { @{el.clone()}[@{name}] = @{b} }; [INFO] [stderr] 99 | | el.set_attribute(name, &b.to_string()) [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *value { [INFO] [stderr] 97 | AttributeValue::Bool(ref b) => { [INFO] [stderr] 98 | js! { @{el.clone()}[@{name}] = @{b} }; [INFO] [stderr] 99 | el.set_attribute(name, &b.to_string()) [INFO] [stderr] 100 | .expect("Failet to set bool attirbute"); [INFO] [stderr] 101 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:250:73 [INFO] [stderr] | [INFO] [stderr] 250 | fn set_handler(&self, el: &web::Element, name: &str, id: &str, pos: &Position) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:276:14 [INFO] [stderr] | [INFO] [stderr] 276 | .or_insert(HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in el.children.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | for child in el.children { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | pos.push(i.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:222:36 [INFO] [stderr] | [INFO] [stderr] 222 | fn remove_attached(&self, pos: &Position) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change `pos.clone()` to [INFO] [stderr] | [INFO] [stderr] 223 | let mut max = pos.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: change `pos.clone()` to [INFO] [stderr] | [INFO] [stderr] 227 | let range = (Included(pos.to_owned()), Excluded(max)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:250:73 [INFO] [stderr] | [INFO] [stderr] 250 | fn set_handler(&self, el: &web::Element, name: &str, id: &str, pos: &Position) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:276:14 [INFO] [stderr] | [INFO] [stderr] 276 | .or_insert(HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.80s [INFO] running `"docker" "inspect" "7dbee1a8e323498c770dc4ba22a4fda064b7f70ae51e7a120286520fe8f4fb9f"` [INFO] running `"docker" "rm" "-f" "7dbee1a8e323498c770dc4ba22a4fda064b7f70ae51e7a120286520fe8f4fb9f"` [INFO] [stdout] 7dbee1a8e323498c770dc4ba22a4fda064b7f70ae51e7a120286520fe8f4fb9f