[INFO] crate sputnikvm-stateful 0.11.0-beta.0 is already in cache [INFO] extracting crate sputnikvm-stateful 0.11.0-beta.0 into work/ex/clippy-test-run/sources/stable/reg/sputnikvm-stateful/0.11.0-beta.0 [INFO] extracting crate sputnikvm-stateful 0.11.0-beta.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sputnikvm-stateful/0.11.0-beta.0 [INFO] validating manifest of sputnikvm-stateful-0.11.0-beta.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sputnikvm-stateful-0.11.0-beta.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sputnikvm-stateful-0.11.0-beta.0 [INFO] finished frobbing sputnikvm-stateful-0.11.0-beta.0 [INFO] frobbed toml for sputnikvm-stateful-0.11.0-beta.0 written to work/ex/clippy-test-run/sources/stable/reg/sputnikvm-stateful/0.11.0-beta.0/Cargo.toml [INFO] started frobbing sputnikvm-stateful-0.11.0-beta.0 [INFO] finished frobbing sputnikvm-stateful-0.11.0-beta.0 [INFO] frobbed toml for sputnikvm-stateful-0.11.0-beta.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sputnikvm-stateful/0.11.0-beta.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sputnikvm-stateful-0.11.0-beta.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sputnikvm-stateful/0.11.0-beta.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eecc7f0bec9c42eac9edf166b18242cdd7ba4756c5f54ba9c2d233975bdf5859 [INFO] running `"docker" "start" "-a" "eecc7f0bec9c42eac9edf166b18242cdd7ba4756c5f54ba9c2d233975bdf5859"` [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking etcommon-hexutil v0.2.4 [INFO] [stderr] Checking elastic-array-plus v0.10.0 [INFO] [stderr] Compiling secp256k1-plus v0.5.7 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking bn-plus v0.4.4 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking arrayvec v0.3.25 [INFO] [stderr] Checking etcommon-rlp v0.2.4 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking digest v0.6.2 [INFO] [stderr] Checking sha3 v0.6.0 [INFO] [stderr] Checking ripemd160 v0.6.0 [INFO] [stderr] Checking sha2 v0.6.0 [INFO] [stderr] Checking etcommon-bigint v0.2.10 [INFO] [stderr] Checking etcommon-block-core v0.3.0 [INFO] [stderr] Checking etcommon-trie v0.4.0 [INFO] [stderr] Checking etcommon-bloom v0.2.1 [INFO] [stderr] Checking etcommon-trie v0.3.11 [INFO] [stderr] Checking etcommon-block v0.5.1 [INFO] [stderr] Checking sputnikvm v0.11.0-beta.0 [INFO] [stderr] Checking sputnikvm-precompiled-modexp v0.11.0-beta.0 [INFO] [stderr] Checking sputnikvm-precompiled-bn128 v0.11.0-beta.0 [INFO] [stderr] Checking sputnikvm-stateful v0.11.0-beta.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:152:48 [INFO] [stderr] | [INFO] [stderr] 152 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] Checking sputnikvm-network-classic v0.11.0-beta.0 [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:152:48 [INFO] [stderr] | [INFO] [stderr] 152 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/parallel.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:152:48 [INFO] [stderr] | [INFO] [stderr] 152 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/parallel.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self { [INFO] [stderr] 62 | | &SendableAccountChange::Full { [INFO] [stderr] 63 | | address, [INFO] [stderr] 64 | | .. [INFO] [stderr] ... | [INFO] [stderr] 71 | | &SendableAccountChange::Nonexist(address) => address, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *self { [INFO] [stderr] 62 | SendableAccountChange::Full { [INFO] [stderr] 63 | address, [INFO] [stderr] 64 | .. [INFO] [stderr] 65 | } => address, [INFO] [stderr] 66 | SendableAccountChange::IncreaseBalance(address, _) => address, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/parallel.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/parallel.rs:214:48 [INFO] [stderr] | [INFO] [stderr] 214 | let accounts: Vec = vm.accounts().map(|v| v.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vm.accounts().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:152:48 [INFO] [stderr] | [INFO] [stderr] 152 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/genesis.rs:100:34 [INFO] [stderr] | [INFO] [stderr] 100 | gas_limit: Gas::from(100000u64), [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/genesis.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | trie.insert_raw(Keccak256::digest("doe".as_bytes()).as_slice().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"doe"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/genesis.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | "reindeer".as_bytes().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"reindeer"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/genesis.rs:50:39 [INFO] [stderr] | [INFO] [stderr] 50 | trie.insert_raw(Keccak256::digest("dog".as_bytes()).as_slice().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dog"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/genesis.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | "puppy".as_bytes().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"puppy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/genesis.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | trie.insert_raw(Keccak256::digest("dogglesworth".as_bytes()).as_slice().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dogglesworth"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/genesis.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | "cat".as_bytes().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cat"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.75s [INFO] running `"docker" "inspect" "eecc7f0bec9c42eac9edf166b18242cdd7ba4756c5f54ba9c2d233975bdf5859"` [INFO] running `"docker" "rm" "-f" "eecc7f0bec9c42eac9edf166b18242cdd7ba4756c5f54ba9c2d233975bdf5859"` [INFO] [stdout] eecc7f0bec9c42eac9edf166b18242cdd7ba4756c5f54ba9c2d233975bdf5859