[INFO] crate sputnikvm 0.11.0-beta.0 is already in cache [INFO] extracting crate sputnikvm 0.11.0-beta.0 into work/ex/clippy-test-run/sources/stable/reg/sputnikvm/0.11.0-beta.0 [INFO] extracting crate sputnikvm 0.11.0-beta.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sputnikvm/0.11.0-beta.0 [INFO] validating manifest of sputnikvm-0.11.0-beta.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sputnikvm-0.11.0-beta.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sputnikvm-0.11.0-beta.0 [INFO] finished frobbing sputnikvm-0.11.0-beta.0 [INFO] frobbed toml for sputnikvm-0.11.0-beta.0 written to work/ex/clippy-test-run/sources/stable/reg/sputnikvm/0.11.0-beta.0/Cargo.toml [INFO] started frobbing sputnikvm-0.11.0-beta.0 [INFO] finished frobbing sputnikvm-0.11.0-beta.0 [INFO] frobbed toml for sputnikvm-0.11.0-beta.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sputnikvm/0.11.0-beta.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sputnikvm-0.11.0-beta.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sputnikvm/0.11.0-beta.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9d8127b0dc7405e406d9be64a75303112383bcc48a7abc5ed19016333d807b6 [INFO] running `"docker" "start" "-a" "c9d8127b0dc7405e406d9be64a75303112383bcc48a7abc5ed19016333d807b6"` [INFO] [stderr] Checking etcommon-rlp v0.2.4 [INFO] [stderr] Checking etcommon-bigint v0.2.10 [INFO] [stderr] Checking etcommon-block-core v0.3.0 [INFO] [stderr] Checking etcommon-trie v0.4.0 [INFO] [stderr] Checking etcommon-bloom v0.2.1 [INFO] [stderr] Checking etcommon-block v0.5.1 [INFO] [stderr] Checking sputnikvm v0.11.0-beta.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval/cost.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 63 | | if value != M256::zero() && state.account_state.storage_read(address, index).unwrap() == M256::zero() { [INFO] [stderr] 64 | | G_SSET.into() [INFO] [stderr] 65 | | } else { [INFO] [stderr] 66 | | G_SRESET.into() [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | } else if value != M256::zero() && state.account_state.storage_read(address, index).unwrap() == M256::zero() { [INFO] [stderr] 63 | G_SSET.into() [INFO] [stderr] 64 | } else { [INFO] [stderr] 65 | G_SRESET.into() [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval/cost.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | if orig == current { [INFO] [stderr] 53 | | if orig == M256::zero() { [INFO] [stderr] 54 | | G_SSET.into() [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if orig == current { [INFO] [stderr] 52 | if orig == M256::zero() { [INFO] [stderr] 53 | G_SSET.into() [INFO] [stderr] 54 | } else { [INFO] [stderr] 55 | G_SRESET.into() [INFO] [stderr] 56 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval/cost.rs:331:20 [INFO] [stderr] | [INFO] [stderr] 331 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 332 | | if value == M256::zero() && state.account_state.storage_read(address, index).unwrap() != M256::zero() { [INFO] [stderr] 333 | | R_SRESET [INFO] [stderr] 334 | | } else { [INFO] [stderr] 335 | | 0 [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 331 | } else if value == M256::zero() && state.account_state.storage_read(address, index).unwrap() != M256::zero() { [INFO] [stderr] 332 | R_SRESET [INFO] [stderr] 333 | } else { [INFO] [stderr] 334 | 0 [INFO] [stderr] 335 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/eval/run/bitwise.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | shifted [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/eval/run/bitwise.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | let shifted = value.1 >> shift as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/eval/lifecycle.rs:93:48 [INFO] [stderr] | [INFO] [stderr] 93 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `single_match` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:333:48 [INFO] [stderr] | [INFO] [stderr] 333 | #[cfg_attr(feature = "cargo-clippy", allow(single_match))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::single_match` [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/eval/lifecycle.rs:93:48 [INFO] [stderr] | [INFO] [stderr] 93 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval/cost.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 63 | | if value != M256::zero() && state.account_state.storage_read(address, index).unwrap() == M256::zero() { [INFO] [stderr] 64 | | G_SSET.into() [INFO] [stderr] 65 | | } else { [INFO] [stderr] 66 | | G_SRESET.into() [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | } else if value != M256::zero() && state.account_state.storage_read(address, index).unwrap() == M256::zero() { [INFO] [stderr] 63 | G_SSET.into() [INFO] [stderr] 64 | } else { [INFO] [stderr] 65 | G_SRESET.into() [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval/cost.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | if orig == current { [INFO] [stderr] 53 | | if orig == M256::zero() { [INFO] [stderr] 54 | | G_SSET.into() [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if orig == current { [INFO] [stderr] 52 | if orig == M256::zero() { [INFO] [stderr] 53 | G_SSET.into() [INFO] [stderr] 54 | } else { [INFO] [stderr] 55 | G_SRESET.into() [INFO] [stderr] 56 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval/cost.rs:331:20 [INFO] [stderr] | [INFO] [stderr] 331 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 332 | | if value == M256::zero() && state.account_state.storage_read(address, index).unwrap() != M256::zero() { [INFO] [stderr] 333 | | R_SRESET [INFO] [stderr] 334 | | } else { [INFO] [stderr] 335 | | 0 [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 331 | } else if value == M256::zero() && state.account_state.storage_read(address, index).unwrap() != M256::zero() { [INFO] [stderr] 332 | R_SRESET [INFO] [stderr] 333 | } else { [INFO] [stderr] 334 | 0 [INFO] [stderr] 335 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/eval/run/bitwise.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | shifted [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/eval/run/bitwise.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | let shifted = value.1 >> shift as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/eval/lifecycle.rs:93:48 [INFO] [stderr] | [INFO] [stderr] 93 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `single_match` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:333:48 [INFO] [stderr] | [INFO] [stderr] 333 | #[cfg_attr(feature = "cargo-clippy", allow(single_match))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::single_match` [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/eval/lifecycle.rs:93:48 [INFO] [stderr] | [INFO] [stderr] 93 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/eval/mod.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | InvokeCall(Context, (U256, U256)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/eval/mod.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | InvokeCall(Context, (U256, U256)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/eval/mod.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | InvokeCall(Context, (U256, U256)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/eval/mod.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | InvokeCall(Context, (U256, U256)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/commit/account.rs:391:22 [INFO] [stderr] | [INFO] [stderr] 391 | .or_insert(Storage::new(address, true)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Storage::new(address, true))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/commit/account.rs:545:14 [INFO] [stderr] | [INFO] [stderr] 545 | .or_insert(Storage::new(address, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Storage::new(address, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:188:41 [INFO] [stderr] | [INFO] [stderr] 188 | self.action.address(self.caller.unwrap_or(system_address!()), self.nonce) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:233:41 [INFO] [stderr] | [INFO] [stderr] 233 | caller: self.caller.unwrap_or(system_address!()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:239:36 [INFO] [stderr] | [INFO] [stderr] 239 | origin: origin.unwrap_or(self.caller.unwrap_or(system_address!())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.caller.unwrap_or(system_address!()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:239:58 [INFO] [stderr] | [INFO] [stderr] 239 | origin: origin.unwrap_or(self.caller.unwrap_or(system_address!())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:254:41 [INFO] [stderr] | [INFO] [stderr] 254 | caller: self.caller.unwrap_or(system_address!()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:260:36 [INFO] [stderr] | [INFO] [stderr] 260 | origin: origin.unwrap_or(self.caller.unwrap_or(system_address!())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.caller.unwrap_or(system_address!()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:260:58 [INFO] [stderr] | [INFO] [stderr] 260 | origin: origin.unwrap_or(self.caller.unwrap_or(system_address!())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/eval/mod.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | InvokeCall(Context, (U256, U256)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/eval/mod.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | InvokeCall(Context, (U256, U256)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/eval/mod.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | InvokeCall(Context, (U256, U256)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/eval/mod.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | InvokeCall(Context, (U256, U256)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/commit/account.rs:391:22 [INFO] [stderr] | [INFO] [stderr] 391 | .or_insert(Storage::new(address, true)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Storage::new(address, true))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/commit/account.rs:545:14 [INFO] [stderr] | [INFO] [stderr] 545 | .or_insert(Storage::new(address, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Storage::new(address, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:188:41 [INFO] [stderr] | [INFO] [stderr] 188 | self.action.address(self.caller.unwrap_or(system_address!()), self.nonce) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:233:41 [INFO] [stderr] | [INFO] [stderr] 233 | caller: self.caller.unwrap_or(system_address!()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:239:36 [INFO] [stderr] | [INFO] [stderr] 239 | origin: origin.unwrap_or(self.caller.unwrap_or(system_address!())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.caller.unwrap_or(system_address!()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:239:58 [INFO] [stderr] | [INFO] [stderr] 239 | origin: origin.unwrap_or(self.caller.unwrap_or(system_address!())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:254:41 [INFO] [stderr] | [INFO] [stderr] 254 | caller: self.caller.unwrap_or(system_address!()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:260:36 [INFO] [stderr] | [INFO] [stderr] 260 | origin: origin.unwrap_or(self.caller.unwrap_or(system_address!())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.caller.unwrap_or(system_address!()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transaction.rs:260:58 [INFO] [stderr] | [INFO] [stderr] 260 | origin: origin.unwrap_or(self.caller.unwrap_or(system_address!())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| system_address!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.98s [INFO] running `"docker" "inspect" "c9d8127b0dc7405e406d9be64a75303112383bcc48a7abc5ed19016333d807b6"` [INFO] running `"docker" "rm" "-f" "c9d8127b0dc7405e406d9be64a75303112383bcc48a7abc5ed19016333d807b6"` [INFO] [stdout] c9d8127b0dc7405e406d9be64a75303112383bcc48a7abc5ed19016333d807b6