[INFO] crate spurs 0.1.4 is already in cache [INFO] extracting crate spurs 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/spurs/0.1.4 [INFO] extracting crate spurs 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spurs/0.1.4 [INFO] validating manifest of spurs-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spurs-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spurs-0.1.4 [INFO] finished frobbing spurs-0.1.4 [INFO] frobbed toml for spurs-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/spurs/0.1.4/Cargo.toml [INFO] started frobbing spurs-0.1.4 [INFO] finished frobbing spurs-0.1.4 [INFO] frobbed toml for spurs-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spurs/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spurs-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spurs/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79259f5e17769e1af61a56777498cd608dff2c46f29071f449058d4bcf9da3a3 [INFO] running `"docker" "start" "-a" "79259f5e17769e1af61a56777498cd608dff2c46f29071f449058d4bcf9da3a3"` [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Checking ssh2 v0.3.3 [INFO] [stderr] Checking spurs v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | tcp: tcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tcp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | tcp: tcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tcp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ssh.rs:296:37 [INFO] [stderr] | [INFO] [stderr] 296 | .trim_right_matches("\u{0}"); [INFO] [stderr] | ^^^^^^^ help: try using a char instead: `'\u{0}'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ssh.rs:315:37 [INFO] [stderr] | [INFO] [stderr] 315 | .trim_right_matches("\u{0}"); [INFO] [stderr] | ^^^^^^^ help: try using a char instead: `'\u{0}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ssh.rs:327:22 [INFO] [stderr] | [INFO] [stderr] 327 | cmd: cmd.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/util.rs:293:12 [INFO] [stderr] | [INFO] [stderr] 293 | devs: &HashSet, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 291 | pub fn get_dev_sizes( [INFO] [stderr] 292 | shell: &SshShell, [INFO] [stderr] 293 | devs: &HashSet, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/util.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / size? [INFO] [stderr] 304 | | .stdout [INFO] [stderr] 305 | | .lines() [INFO] [stderr] 306 | | .skip(1) [INFO] [stderr] 307 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ssh.rs:296:37 [INFO] [stderr] | [INFO] [stderr] 296 | .trim_right_matches("\u{0}"); [INFO] [stderr] | ^^^^^^^ help: try using a char instead: `'\u{0}'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ssh.rs:315:37 [INFO] [stderr] | [INFO] [stderr] 315 | .trim_right_matches("\u{0}"); [INFO] [stderr] | ^^^^^^^ help: try using a char instead: `'\u{0}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ssh.rs:327:22 [INFO] [stderr] | [INFO] [stderr] 327 | cmd: cmd.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/util.rs:293:12 [INFO] [stderr] | [INFO] [stderr] 293 | devs: &HashSet, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 291 | pub fn get_dev_sizes( [INFO] [stderr] 292 | shell: &SshShell, [INFO] [stderr] 293 | devs: &HashSet, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/util.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / size? [INFO] [stderr] 304 | | .stdout [INFO] [stderr] 305 | | .lines() [INFO] [stderr] 306 | | .skip(1) [INFO] [stderr] 307 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.94s [INFO] running `"docker" "inspect" "79259f5e17769e1af61a56777498cd608dff2c46f29071f449058d4bcf9da3a3"` [INFO] running `"docker" "rm" "-f" "79259f5e17769e1af61a56777498cd608dff2c46f29071f449058d4bcf9da3a3"` [INFO] [stdout] 79259f5e17769e1af61a56777498cd608dff2c46f29071f449058d4bcf9da3a3