[INFO] crate spsheet 0.1.0 is already in cache [INFO] extracting crate spsheet 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/spsheet/0.1.0 [INFO] extracting crate spsheet 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spsheet/0.1.0 [INFO] validating manifest of spsheet-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spsheet-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spsheet-0.1.0 [INFO] finished frobbing spsheet-0.1.0 [INFO] frobbed toml for spsheet-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/spsheet/0.1.0/Cargo.toml [INFO] started frobbing spsheet-0.1.0 [INFO] finished frobbing spsheet-0.1.0 [INFO] frobbed toml for spsheet-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spsheet/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spsheet-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spsheet/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be60b6db151bceeccc23882427be618e522c4e66389186a1f93a9e324985be59 [INFO] running `"docker" "start" "-a" "be60b6db151bceeccc23882427be618e522c4e66389186a1f93a9e324985be59"` [INFO] [stderr] Checking spsheet v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/lib.rs:97:41 [INFO] [stderr] | [INFO] [stderr] 97 | column_to_index(val.slice_unchecked(0, index)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/lib.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | val.slice_unchecked(index, val.len()).parse::().unwrap() - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/lib.rs:97:41 [INFO] [stderr] | [INFO] [stderr] 97 | column_to_index(val.slice_unchecked(0, index)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/lib.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | val.slice_unchecked(index, val.len()).parse::().unwrap() - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | index = index + alphabet.find(c).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index += alphabet.find(c).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / match val.find(i) { [INFO] [stderr] 83 | | Some(n) => { [INFO] [stderr] 84 | | if index > n { [INFO] [stderr] 85 | | index = n; [INFO] [stderr] ... | [INFO] [stderr] 88 | | None => {} [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(n) = val.find(i) { [INFO] [stderr] 83 | if index > n { [INFO] [stderr] 84 | index = n; [INFO] [stderr] 85 | } [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Book` [INFO] [stderr] --> src/lib.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn new() -> Book { [INFO] [stderr] 117 | | Book { [INFO] [stderr] 118 | | sheets: Vec::new() [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:225:12 [INFO] [stderr] | [INFO] [stderr] 225 | if self.get_rows().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.get_rows().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | index = index + alphabet.find(c).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index += alphabet.find(c).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / match val.find(i) { [INFO] [stderr] 83 | | Some(n) => { [INFO] [stderr] 84 | | if index > n { [INFO] [stderr] 85 | | index = n; [INFO] [stderr] ... | [INFO] [stderr] 88 | | None => {} [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(n) = val.find(i) { [INFO] [stderr] 83 | if index > n { [INFO] [stderr] 84 | index = n; [INFO] [stderr] 85 | } [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Book` [INFO] [stderr] --> src/lib.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn new() -> Book { [INFO] [stderr] 117 | | Book { [INFO] [stderr] 118 | | sheets: Vec::new() [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:225:12 [INFO] [stderr] | [INFO] [stderr] 225 | if self.get_rows().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.get_rows().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> tests/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_sheet1` [INFO] [stderr] --> tests/lib.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | fn make_sheet1() -> Sheet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_sheet2` [INFO] [stderr] --> tests/lib.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | fn make_sheet2() -> Sheet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_sheet3` [INFO] [stderr] --> tests/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | fn make_sheet3() -> Sheet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_sheet4` [INFO] [stderr] --> tests/lib.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | fn make_sheet4() -> Sheet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_book` [INFO] [stderr] --> tests/lib.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | fn make_book() -> Book { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/lib.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | for i in vec![0,1,26,27,28,100,101,102] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0,1,26,27,28,100,101,102]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/lib.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in vec!["A", "B", "Z", "AA", "AB", "ZZ", "AAA", "AAB", "ABC"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["A", "B", "Z", "AA", "AB", "ZZ", "AAA", "AAB", "ABC"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.32s [INFO] running `"docker" "inspect" "be60b6db151bceeccc23882427be618e522c4e66389186a1f93a9e324985be59"` [INFO] running `"docker" "rm" "-f" "be60b6db151bceeccc23882427be618e522c4e66389186a1f93a9e324985be59"` [INFO] [stdout] be60b6db151bceeccc23882427be618e522c4e66389186a1f93a9e324985be59