[INFO] crate sprite-gen 0.1.4 is already in cache
[INFO] extracting crate sprite-gen 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/sprite-gen/0.1.4
[INFO] extracting crate sprite-gen 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sprite-gen/0.1.4
[INFO] validating manifest of sprite-gen-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sprite-gen-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sprite-gen-0.1.4
[INFO] finished frobbing sprite-gen-0.1.4
[INFO] frobbed toml for sprite-gen-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/sprite-gen/0.1.4/Cargo.toml
[INFO] started frobbing sprite-gen-0.1.4
[INFO] finished frobbing sprite-gen-0.1.4
[INFO] frobbed toml for sprite-gen-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sprite-gen/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sprite-gen-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sprite-gen/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 04584c66ed3a4e20ca6afd3d86cb6478be97deb2e627b9ea40fc9315995722c8
[INFO] running `"docker" "start" "-a" "04584c66ed3a4e20ca6afd3d86cb6478be97deb2e627b9ea40fc9315995722c8"`
[INFO] [stderr]     Checking hsl v0.1.1
[INFO] [stderr]     Checking sprite-gen v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return colored;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `colored`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:186:14
[INFO] [stderr]     |
[INFO] [stderr] 186 |         _ => 0xFFFFFFFF
[INFO] [stderr]     |              ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:192:27
[INFO] [stderr]     |
[INFO] [stderr] 192 |     let mut result = vec![0xFFFFFFFF; mask.len()];
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return colored;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `colored`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:186:14
[INFO] [stderr]     |
[INFO] [stderr] 186 |         _ => 0xFFFFFFFF
[INFO] [stderr]     |              ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:192:27
[INFO] [stderr]     |
[INFO] [stderr] 192 |     let mut result = vec![0xFFFFFFFF; mask.len()];
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]   --> src/lib.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 |     let mut mask: Vec<i8> = mask_buffer.iter().cloned().collect();
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:109:29
[INFO] [stderr]     |
[INFO] [stderr] 109 |       let colored: Vec<u32> = match options.colored {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 110 | |         true => color_output(&mask, (mask_width, mask_height), &options, &mut rng),
[INFO] [stderr] 111 | |         false => onebit_output(&mask)
[INFO] [stderr] 112 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if options.colored { color_output(&mask, (mask_width, mask_height), &options, &mut rng) } else { onebit_output(&mask) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:201:19
[INFO] [stderr]     |
[INFO] [stderr] 201 |       let uv_size = match is_vertical_gradient {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 202 | |         true => (mask_size.1, mask_size.0),
[INFO] [stderr] 203 | |         false => mask_size
[INFO] [stderr] 204 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if is_vertical_gradient { (mask_size.1, mask_size.0) } else { mask_size }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:214:25
[INFO] [stderr]     |
[INFO] [stderr] 214 |               let index = match is_vertical_gradient {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 215 | |                 true => v + u * mask_size.0,
[INFO] [stderr] 216 | |                 false => u + v * mask_size.0
[INFO] [stderr] 217 | |             };
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if is_vertical_gradient { v + u * mask_size.0 } else { u + v * mask_size.0 }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:235:26
[INFO] [stderr]     |
[INFO] [stderr] 235 |                 rgb.0 = (rgb.0 as f64 * options.edge_brightness) as u8;
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try: `f64::from(rgb.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:236:26
[INFO] [stderr]     |
[INFO] [stderr] 236 |                 rgb.1 = (rgb.1 as f64 * options.edge_brightness) as u8;
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try: `f64::from(rgb.1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:237:26
[INFO] [stderr]     |
[INFO] [stderr] 237 |                 rgb.2 = (rgb.2 as f64 * options.edge_brightness) as u8;
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try: `f64::from(rgb.2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:240:30
[INFO] [stderr]     |
[INFO] [stderr] 240 |             result[index] = ((rgb.0 as u32) << 16) | ((rgb.1 as u32) << 8) | (rgb.2 as u32);
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^ help: try: `u32::from(rgb.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:240:55
[INFO] [stderr]     |
[INFO] [stderr] 240 |             result[index] = ((rgb.0 as u32) << 16) | ((rgb.1 as u32) << 8) | (rgb.2 as u32);
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^ help: try: `u32::from(rgb.1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:240:78
[INFO] [stderr]     |
[INFO] [stderr] 240 |             result[index] = ((rgb.0 as u32) << 16) | ((rgb.1 as u32) << 8) | (rgb.2 as u32);
[INFO] [stderr]     |                                                                              ^^^^^^^^^^^^^^ help: try: `u32::from(rgb.2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]   --> src/lib.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 |     let mut mask: Vec<i8> = mask_buffer.iter().cloned().collect();
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:109:29
[INFO] [stderr]     |
[INFO] [stderr] 109 |       let colored: Vec<u32> = match options.colored {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 110 | |         true => color_output(&mask, (mask_width, mask_height), &options, &mut rng),
[INFO] [stderr] 111 | |         false => onebit_output(&mask)
[INFO] [stderr] 112 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if options.colored { color_output(&mask, (mask_width, mask_height), &options, &mut rng) } else { onebit_output(&mask) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:201:19
[INFO] [stderr]     |
[INFO] [stderr] 201 |       let uv_size = match is_vertical_gradient {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 202 | |         true => (mask_size.1, mask_size.0),
[INFO] [stderr] 203 | |         false => mask_size
[INFO] [stderr] 204 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if is_vertical_gradient { (mask_size.1, mask_size.0) } else { mask_size }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:214:25
[INFO] [stderr]     |
[INFO] [stderr] 214 |               let index = match is_vertical_gradient {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 215 | |                 true => v + u * mask_size.0,
[INFO] [stderr] 216 | |                 false => u + v * mask_size.0
[INFO] [stderr] 217 | |             };
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if is_vertical_gradient { v + u * mask_size.0 } else { u + v * mask_size.0 }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:235:26
[INFO] [stderr]     |
[INFO] [stderr] 235 |                 rgb.0 = (rgb.0 as f64 * options.edge_brightness) as u8;
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try: `f64::from(rgb.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:236:26
[INFO] [stderr]     |
[INFO] [stderr] 236 |                 rgb.1 = (rgb.1 as f64 * options.edge_brightness) as u8;
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try: `f64::from(rgb.1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:237:26
[INFO] [stderr]     |
[INFO] [stderr] 237 |                 rgb.2 = (rgb.2 as f64 * options.edge_brightness) as u8;
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try: `f64::from(rgb.2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:240:30
[INFO] [stderr]     |
[INFO] [stderr] 240 |             result[index] = ((rgb.0 as u32) << 16) | ((rgb.1 as u32) << 8) | (rgb.2 as u32);
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^ help: try: `u32::from(rgb.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:240:55
[INFO] [stderr]     |
[INFO] [stderr] 240 |             result[index] = ((rgb.0 as u32) << 16) | ((rgb.1 as u32) << 8) | (rgb.2 as u32);
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^ help: try: `u32::from(rgb.1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:240:78
[INFO] [stderr]     |
[INFO] [stderr] 240 |             result[index] = ((rgb.0 as u32) << 16) | ((rgb.1 as u32) << 8) | (rgb.2 as u32);
[INFO] [stderr]     |                                                                              ^^^^^^^^^^^^^^ help: try: `u32::from(rgb.2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.31s
[INFO] running `"docker" "inspect" "04584c66ed3a4e20ca6afd3d86cb6478be97deb2e627b9ea40fc9315995722c8"`
[INFO] running `"docker" "rm" "-f" "04584c66ed3a4e20ca6afd3d86cb6478be97deb2e627b9ea40fc9315995722c8"`
[INFO] [stdout] 04584c66ed3a4e20ca6afd3d86cb6478be97deb2e627b9ea40fc9315995722c8