[INFO] crate spotrust 0.0.5 is already in cache
[INFO] extracting crate spotrust 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/spotrust/0.0.5
[INFO] extracting crate spotrust 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spotrust/0.0.5
[INFO] validating manifest of spotrust-0.0.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of spotrust-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing spotrust-0.0.5
[INFO] finished frobbing spotrust-0.0.5
[INFO] frobbed toml for spotrust-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/spotrust/0.0.5/Cargo.toml
[INFO] started frobbing spotrust-0.0.5
[INFO] finished frobbing spotrust-0.0.5
[INFO] frobbed toml for spotrust-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spotrust/0.0.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting spotrust-0.0.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spotrust/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 62fdab179677018f5aa94e3b9c926fcf62adf0392ceac4f6c5fe4197ab6723f3
[INFO] running `"docker" "start" "-a" "62fdab179677018f5aa94e3b9c926fcf62adf0392ceac4f6c5fe4197ab6723f3"`
[INFO] [stderr]     Checking spotrust v0.0.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/token.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         cid: cid,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `cid`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/token.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         cs: cs,
[INFO] [stderr]    |         ^^^^^^ help: replace it with: `cs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/token.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         cid: cid,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `cid`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/token.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         cs: cs,
[INFO] [stderr]    |         ^^^^^^ help: replace it with: `cs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return Some(imgvec[0].clone());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(imgvec[0].clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return Some(imgvec[0].clone());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(imgvec[0].clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/token.rs:8:32
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn construct_headers_auth(cid: &String, cs: &String) -> Headers {
[INFO] [stderr]   |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/token.rs:8:45
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn construct_headers_auth(cid: &String, cs: &String) -> Headers {
[INFO] [stderr]   |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/utils.rs:6:5
[INFO] [stderr]    |
[INFO] [stderr] 6  | /     match re.is_match(&s) {
[INFO] [stderr] 7  | |         true => {
[INFO] [stderr] 8  | |             let raw = s.clone();
[INFO] [stderr] 9  | |             let v: Vec<&str> = s.split(':').collect();
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |         false => None,
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]    |
[INFO] [stderr] 6  |     if re.is_match(&s) {
[INFO] [stderr] 7  | let raw = s.clone();
[INFO] [stderr] 8  | let v: Vec<&str> = s.split(':').collect();
[INFO] [stderr] 9  | let t: UriType = match v[1] {
[INFO] [stderr] 10 |     "track" => UriType::Track,
[INFO] [stderr] 11 |     "album" => UriType::Album,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:53:34
[INFO] [stderr]    |
[INFO] [stderr] 53 | pub fn get_largest_image(imgvec: &Vec<SpotifyImage>) -> Option<SpotifyImage> {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^ help: change this to: `&[SpotifyImage]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/utils.rs:54:8
[INFO] [stderr]    |
[INFO] [stderr] 54 |     if imgvec.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!imgvec.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/token.rs:8:32
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn construct_headers_auth(cid: &String, cs: &String) -> Headers {
[INFO] [stderr]   |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/token.rs:8:45
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn construct_headers_auth(cid: &String, cs: &String) -> Headers {
[INFO] [stderr]   |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/utils.rs:6:5
[INFO] [stderr]    |
[INFO] [stderr] 6  | /     match re.is_match(&s) {
[INFO] [stderr] 7  | |         true => {
[INFO] [stderr] 8  | |             let raw = s.clone();
[INFO] [stderr] 9  | |             let v: Vec<&str> = s.split(':').collect();
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |         false => None,
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]    |
[INFO] [stderr] 6  |     if re.is_match(&s) {
[INFO] [stderr] 7  | let raw = s.clone();
[INFO] [stderr] 8  | let v: Vec<&str> = s.split(':').collect();
[INFO] [stderr] 9  | let t: UriType = match v[1] {
[INFO] [stderr] 10 |     "track" => UriType::Track,
[INFO] [stderr] 11 |     "album" => UriType::Album,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:53:34
[INFO] [stderr]    |
[INFO] [stderr] 53 | pub fn get_largest_image(imgvec: &Vec<SpotifyImage>) -> Option<SpotifyImage> {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^ help: change this to: `&[SpotifyImage]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/utils.rs:54:8
[INFO] [stderr]    |
[INFO] [stderr] 54 |     if imgvec.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!imgvec.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.87s
[INFO] running `"docker" "inspect" "62fdab179677018f5aa94e3b9c926fcf62adf0392ceac4f6c5fe4197ab6723f3"`
[INFO] running `"docker" "rm" "-f" "62fdab179677018f5aa94e3b9c926fcf62adf0392ceac4f6c5fe4197ab6723f3"`
[INFO] [stdout] 62fdab179677018f5aa94e3b9c926fcf62adf0392ceac4f6c5fe4197ab6723f3