[INFO] crate spoolq 0.2.3 is already in cache [INFO] extracting crate spoolq 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/spoolq/0.2.3 [INFO] extracting crate spoolq 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spoolq/0.2.3 [INFO] validating manifest of spoolq-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spoolq-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spoolq-0.2.3 [INFO] finished frobbing spoolq-0.2.3 [INFO] frobbed toml for spoolq-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/spoolq/0.2.3/Cargo.toml [INFO] started frobbing spoolq-0.2.3 [INFO] finished frobbing spoolq-0.2.3 [INFO] frobbed toml for spoolq-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spoolq/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spoolq-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spoolq/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e5425279391e6da3a0d640328bb2ce815496f0e8e9022c39e7940bf266d1e9b [INFO] running `"docker" "start" "-a" "9e5425279391e6da3a0d640328bb2ce815496f0e8e9022c39e7940bf266d1e9b"` [INFO] [stderr] Checking textnonce v0.4.1 [INFO] [stderr] Checking spoolq v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:90:20 [INFO] [stderr] | [INFO] [stderr] 90 | if result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | if let Some(_) = p.extension() { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 113 | | continue; [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________________- help: try this: `if p.extension().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | / match self { [INFO] [stderr] 244 | | &mut Cleanup::Dir(ref path) => { [INFO] [stderr] 245 | | match std::fs::remove_dir_all(path) { [INFO] [stderr] 246 | | Ok(_) => {} [INFO] [stderr] ... | [INFO] [stderr] 251 | | } [INFO] [stderr] 252 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 243 | match *self { [INFO] [stderr] 244 | Cleanup::Dir(ref path) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:90:20 [INFO] [stderr] | [INFO] [stderr] 90 | if result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | if let Some(_) = p.extension() { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 113 | | continue; [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________________- help: try this: `if p.extension().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | / match self { [INFO] [stderr] 244 | | &mut Cleanup::Dir(ref path) => { [INFO] [stderr] 245 | | match std::fs::remove_dir_all(path) { [INFO] [stderr] 246 | | Ok(_) => {} [INFO] [stderr] ... | [INFO] [stderr] 251 | | } [INFO] [stderr] 252 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 243 | match *self { [INFO] [stderr] 244 | Cleanup::Dir(ref path) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:327:33 [INFO] [stderr] | [INFO] [stderr] 327 | Ok(Some(ref foo)) => foo.i == 111, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.59s [INFO] running `"docker" "inspect" "9e5425279391e6da3a0d640328bb2ce815496f0e8e9022c39e7940bf266d1e9b"` [INFO] running `"docker" "rm" "-f" "9e5425279391e6da3a0d640328bb2ce815496f0e8e9022c39e7940bf266d1e9b"` [INFO] [stdout] 9e5425279391e6da3a0d640328bb2ce815496f0e8e9022c39e7940bf266d1e9b