[INFO] crate split_by 0.2.2 is already in cache [INFO] extracting crate split_by 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/split_by/0.2.2 [INFO] extracting crate split_by 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/split_by/0.2.2 [INFO] validating manifest of split_by-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of split_by-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing split_by-0.2.2 [INFO] finished frobbing split_by-0.2.2 [INFO] frobbed toml for split_by-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/split_by/0.2.2/Cargo.toml [INFO] started frobbing split_by-0.2.2 [INFO] finished frobbing split_by-0.2.2 [INFO] frobbed toml for split_by-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/split_by/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting split_by-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/split_by/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] adc7784d322b94226f6d935dba5490e4da4dd36e8a53abca81c4491c16d4881b [INFO] running `"docker" "start" "-a" "adc7784d322b94226f6d935dba5490e4da4dd36e8a53abca81c4491c16d4881b"` [INFO] [stderr] Checking split_by v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grow.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grow.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/grow.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn drain<'a>(&'a mut self, amount: usize) -> Drain<'a, u8> { [INFO] [stderr] 22 | | // TODO: add overflow check [INFO] [stderr] 23 | | self.read_pos -= amount; [INFO] [stderr] 24 | | self.deq.drain(..amount) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/grow.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn drain_all<'a>(&'a mut self) -> Drain<'a, u8> { [INFO] [stderr] 30 | | self.read_pos = 0; [INFO] [stderr] 31 | | self.deq.drain(..) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | if rest.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | let i = g.iter().map(|&v| v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `g.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:79:37 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(v) => if v.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/grow.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn drain<'a>(&'a mut self, amount: usize) -> Drain<'a, u8> { [INFO] [stderr] 22 | | // TODO: add overflow check [INFO] [stderr] 23 | | self.read_pos -= amount; [INFO] [stderr] 24 | | self.deq.drain(..amount) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/grow.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn drain_all<'a>(&'a mut self) -> Drain<'a, u8> { [INFO] [stderr] 30 | | self.read_pos = 0; [INFO] [stderr] 31 | | self.deq.drain(..) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | if rest.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | let i = g.iter().map(|&v| v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `g.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:79:37 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(v) => if v.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | assert!("==1==2==3==4==5==6==7==8".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![b'1', b'2', b'3', b'4', b'5', b'6', b'7', b'8']); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"==1==2==3==4==5==6==7==8"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:143:87 [INFO] [stderr] | [INFO] [stderr] 143 | assert!("==1==2==3==4==5==6==7==8".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![b'1', b'2', b'3', b'4', b'5', b'6', b'7', b'8']); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | assert!("1==2==3==4==5==6==7==8==".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![b'1', b'2', b'3', b'4', b'5', b'6', b'7', b'8']); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1==2==3==4==5==6==7==8=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:147:87 [INFO] [stderr] | [INFO] [stderr] 147 | assert!("1==2==3==4==5==6==7==8==".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![b'1', b'2', b'3', b'4', b'5', b'6', b'7', b'8']); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | assert!("1==2==3==4==5==6==7==8".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![b'1', b'2', b'3', b'4', b'5', b'6', b'7', b'8']); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1==2==3==4==5==6==7==8"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:151:85 [INFO] [stderr] | [INFO] [stderr] 151 | assert!("1==2==3==4==5==6==7==8".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![b'1', b'2', b'3', b'4', b'5', b'6', b'7', b'8']); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | assert!("1====2==3==4==5==6==7==8".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![b'1', b'2', b'3', b'4', b'5', b'6', b'7', b'8']); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1====2==3==4==5==6==7==8"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:155:87 [INFO] [stderr] | [INFO] [stderr] 155 | assert!("1====2==3==4==5==6==7==8".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![b'1', b'2', b'3', b'4', b'5', b'6', b'7', b'8']); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | assert!("".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:159:63 [INFO] [stderr] | [INFO] [stderr] 159 | assert!("".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | assert!("==".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:163:65 [INFO] [stderr] | [INFO] [stderr] 163 | assert!("==".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | assert!("12345678".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec!["12345678".as_bytes()].iter().map(|f|f[0]).collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"12345678"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:167:71 [INFO] [stderr] | [INFO] [stderr] 167 | assert!("12345678".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec!["12345678".as_bytes()].iter().map(|f|f[0]).collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:167:142 [INFO] [stderr] | [INFO] [stderr] 167 | assert!("12345678".as_bytes().split_by(&AcAutomaton::new(vec!["==".as_bytes()])).map(|f| f.unwrap()[0]).collect::>() == vec!["12345678".as_bytes()].iter().map(|f|f[0]).collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"12345678"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "adc7784d322b94226f6d935dba5490e4da4dd36e8a53abca81c4491c16d4881b"` [INFO] running `"docker" "rm" "-f" "adc7784d322b94226f6d935dba5490e4da4dd36e8a53abca81c4491c16d4881b"` [INFO] [stdout] adc7784d322b94226f6d935dba5490e4da4dd36e8a53abca81c4491c16d4881b