[INFO] crate spinner 0.4.0 is already in cache
[INFO] extracting crate spinner 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/spinner/0.4.0
[INFO] extracting crate spinner 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spinner/0.4.0
[INFO] validating manifest of spinner-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of spinner-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing spinner-0.4.0
[INFO] finished frobbing spinner-0.4.0
[INFO] frobbed toml for spinner-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/spinner/0.4.0/Cargo.toml
[INFO] started frobbing spinner-0.4.0
[INFO] finished frobbing spinner-0.4.0
[INFO] frobbed toml for spinner-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spinner/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting spinner-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spinner/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9699e2386978842d54d7ca75f00d352551b23819a43e16a41e5b5bbe5ecc6fc6
[INFO] running `"docker" "start" "-a" "9699e2386978842d54d7ca75f00d352551b23819a43e16a41e5b5bbe5ecc6fc6"`
[INFO] [stderr]     Checking spinner v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:251:13
[INFO] [stderr]     |
[INFO] [stderr] 251 |             msg: msg,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:306:13
[INFO] [stderr]     |
[INFO] [stderr] 306 |             rx: rx,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `rx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:251:13
[INFO] [stderr]     |
[INFO] [stderr] 251 |             msg: msg,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:306:13
[INFO] [stderr]     |
[INFO] [stderr] 306 |             rx: rx,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `rx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/menu.rs:193:24
[INFO] [stderr]     |
[INFO] [stderr] 193 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 194 | |                     if item.is_optional() {
[INFO] [stderr] 195 | |                         "(Optional) ".into()
[INFO] [stderr] 196 | |                     } else {
[INFO] [stderr] 197 | |                         String::new()
[INFO] [stderr] 198 | |                     }
[INFO] [stderr] 199 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 193 |                 } else if item.is_optional() {
[INFO] [stderr] 194 |     "(Optional) ".into()
[INFO] [stderr] 195 | } else {
[INFO] [stderr] 196 |     String::new()
[INFO] [stderr] 197 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/menu.rs:193:24
[INFO] [stderr]     |
[INFO] [stderr] 193 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 194 | |                     if item.is_optional() {
[INFO] [stderr] 195 | |                         "(Optional) ".into()
[INFO] [stderr] 196 | |                     } else {
[INFO] [stderr] 197 | |                         String::new()
[INFO] [stderr] 198 | |                     }
[INFO] [stderr] 199 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 193 |                 } else if item.is_optional() {
[INFO] [stderr] 194 |     "(Optional) ".into()
[INFO] [stderr] 195 | } else {
[INFO] [stderr] 196 |     String::new()
[INFO] [stderr] 197 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `BufRead`
[INFO] [stderr]  --> src/menu.rs:1:30
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::io::{stdin, stdout, BufRead, Read, Write};
[INFO] [stderr]   |                              ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Read`
[INFO] [stderr]  --> src/menu.rs:1:39
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::io::{stdin, stdout, BufRead, Read, Write};
[INFO] [stderr]   |                                       ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/menu.rs:46:9
[INFO] [stderr]    |
[INFO] [stderr] 46 | /         match self {
[INFO] [stderr] 47 | |             &MenuValue::Text(ref s) => s.fmt(f),
[INFO] [stderr] 48 | |             &MenuValue::Integer(ref s) => s.fmt(f),
[INFO] [stderr] 49 | |             &MenuValue::Float(ref s) => s.fmt(f)
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |         match *self {
[INFO] [stderr] 47 |             MenuValue::Text(ref s) => s.fmt(f),
[INFO] [stderr] 48 |             MenuValue::Integer(ref s) => s.fmt(f),
[INFO] [stderr] 49 |             MenuValue::Float(ref s) => s.fmt(f)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/menu.rs:183:17
[INFO] [stderr]     |
[INFO] [stderr] 183 |             let ref mut item = self.items[i];
[INFO] [stderr]     |             ----^^^^^^^^^^^^----------------- help: try: `let item = &mut self.items[i];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/menu.rs:212:17
[INFO] [stderr]     |
[INFO] [stderr] 212 |                 i = i + 1;
[INFO] [stderr]     |                 ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/menu.rs:220:13
[INFO] [stderr]     |
[INFO] [stderr] 220 |             i = i + 1;
[INFO] [stderr]     |             ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `BufRead`
[INFO] [stderr]  --> src/menu.rs:1:30
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::io::{stdin, stdout, BufRead, Read, Write};
[INFO] [stderr]   |                              ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Read`
[INFO] [stderr]  --> src/menu.rs:1:39
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::io::{stdin, stdout, BufRead, Read, Write};
[INFO] [stderr]   |                                       ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/menu.rs:46:9
[INFO] [stderr]    |
[INFO] [stderr] 46 | /         match self {
[INFO] [stderr] 47 | |             &MenuValue::Text(ref s) => s.fmt(f),
[INFO] [stderr] 48 | |             &MenuValue::Integer(ref s) => s.fmt(f),
[INFO] [stderr] 49 | |             &MenuValue::Float(ref s) => s.fmt(f)
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |         match *self {
[INFO] [stderr] 47 |             MenuValue::Text(ref s) => s.fmt(f),
[INFO] [stderr] 48 |             MenuValue::Integer(ref s) => s.fmt(f),
[INFO] [stderr] 49 |             MenuValue::Float(ref s) => s.fmt(f)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/menu.rs:183:17
[INFO] [stderr]     |
[INFO] [stderr] 183 |             let ref mut item = self.items[i];
[INFO] [stderr]     |             ----^^^^^^^^^^^^----------------- help: try: `let item = &mut self.items[i];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/menu.rs:212:17
[INFO] [stderr]     |
[INFO] [stderr] 212 |                 i = i + 1;
[INFO] [stderr]     |                 ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/menu.rs:220:13
[INFO] [stderr]     |
[INFO] [stderr] 220 |             i = i + 1;
[INFO] [stderr]     |             ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.93s
[INFO] running `"docker" "inspect" "9699e2386978842d54d7ca75f00d352551b23819a43e16a41e5b5bbe5ecc6fc6"`
[INFO] running `"docker" "rm" "-f" "9699e2386978842d54d7ca75f00d352551b23819a43e16a41e5b5bbe5ecc6fc6"`
[INFO] [stdout] 9699e2386978842d54d7ca75f00d352551b23819a43e16a41e5b5bbe5ecc6fc6