[INFO] crate spilo 0.0.0 is already in cache [INFO] extracting crate spilo 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/spilo/0.0.0 [INFO] extracting crate spilo 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spilo/0.0.0 [INFO] validating manifest of spilo-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spilo-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spilo-0.0.0 [INFO] finished frobbing spilo-0.0.0 [INFO] frobbed toml for spilo-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/spilo/0.0.0/Cargo.toml [INFO] started frobbing spilo-0.0.0 [INFO] finished frobbing spilo-0.0.0 [INFO] frobbed toml for spilo-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spilo/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spilo-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spilo/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb5fdf6155b83e33d1faaef7eff5e93827f5aaad0b15d47feab0cf751cb83714 [INFO] running `"docker" "start" "-a" "bb5fdf6155b83e33d1faaef7eff5e93827f5aaad0b15d47feab0cf751cb83714"` [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking irc v0.13.6 [INFO] [stderr] Checking spilo v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'failure::Fail::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/main.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | let report = e.causes().skip(1).fold(format!("{}", e), |acc, err| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Fail::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/main.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | let report = e.causes().skip(1).fold(format!("{}", e), |acc, err| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/main.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | let (writer, reader) = socket.framed( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Fail::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/main.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | let report = e.causes().skip(1).fold(format!("FOR {}: {}", baddr, e), |acc, err| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/main.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | let (writer, reader) = socket.framed( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Fail::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/main.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | let report = e.causes().skip(1).fold(format!("FOR {}: {}", baddr, e), |acc, err| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:86:69 [INFO] [stderr] | [INFO] [stderr] 86 | let mut chans = local_client.list_channels().unwrap_or_else(|| Vec::new()).iter().fold( [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:93:12 [INFO] [stderr] | [INFO] [stderr] 93 | if chans.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chans.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:86:69 [INFO] [stderr] | [INFO] [stderr] 86 | let mut chans = local_client.list_channels().unwrap_or_else(|| Vec::new()).iter().fold( [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:93:12 [INFO] [stderr] | [INFO] [stderr] 93 | if chans.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chans.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | let baddr = baddr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `baddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | let baddr = baddr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `baddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:268:12 [INFO] [stderr] | [INFO] [stderr] 268 | if self.buffer.is_ready() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.buffer.is_ready()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:268:12 [INFO] [stderr] | [INFO] [stderr] 268 | if self.buffer.is_ready() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.buffer.is_ready()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.59s [INFO] running `"docker" "inspect" "bb5fdf6155b83e33d1faaef7eff5e93827f5aaad0b15d47feab0cf751cb83714"` [INFO] running `"docker" "rm" "-f" "bb5fdf6155b83e33d1faaef7eff5e93827f5aaad0b15d47feab0cf751cb83714"` [INFO] [stdout] bb5fdf6155b83e33d1faaef7eff5e93827f5aaad0b15d47feab0cf751cb83714