[INFO] crate spidev 0.3.0 is already in cache [INFO] extracting crate spidev 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/spidev/0.3.0 [INFO] extracting crate spidev 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spidev/0.3.0 [INFO] validating manifest of spidev-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spidev-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spidev-0.3.0 [INFO] finished frobbing spidev-0.3.0 [INFO] frobbed toml for spidev-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/spidev/0.3.0/Cargo.toml [INFO] started frobbing spidev-0.3.0 [INFO] finished frobbing spidev-0.3.0 [INFO] frobbed toml for spidev-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spidev/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spidev-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spidev/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 409bf86253028b56cb62b033f8273ef823b8f63cac309d665d62e941a88c2610 [INFO] running `"docker" "start" "-a" "409bf86253028b56cb62b033f8273ef823b8f63cac309d665d62e941a88c2610"` [INFO] [stderr] Checking spidev v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | Ok(Spidev { devfile: devfile }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `devfile` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | Ok(Spidev { devfile: devfile }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `devfile` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/spidevioctl.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | if (mode.bits & 0xFFFFFF00) != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FF00` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/spidevioctl.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | if (mode.bits & 0xFFFFFF00) != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FF00` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/spidevioctl.rs:118:31 [INFO] [stderr] | [INFO] [stderr] 118 | const SPI_IOC_MAGIC: u8 = 'k' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'k' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SpidevOptions` [INFO] [stderr] --> src/lib.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> SpidevOptions { [INFO] [stderr] 150 | | SpidevOptions { [INFO] [stderr] 151 | | bits_per_word: None, [INFO] [stderr] 152 | | max_speed_hz: None, [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/spidevioctl.rs:118:31 [INFO] [stderr] | [INFO] [stderr] 118 | const SPI_IOC_MAGIC: u8 = 'k' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'k' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SpidevOptions` [INFO] [stderr] --> src/lib.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> SpidevOptions { [INFO] [stderr] 150 | | SpidevOptions { [INFO] [stderr] 151 | | bits_per_word: None, [INFO] [stderr] 152 | | max_speed_hz: None, [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> examples/spidev-hello.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | spidev.write(&[0xAA, 0x00, 0x01, 0x02, 0x04]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> examples/spidev-hello.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | spidev.read(&mut buf).unwrap(); // read 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `spidev`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "409bf86253028b56cb62b033f8273ef823b8f63cac309d665d62e941a88c2610"` [INFO] running `"docker" "rm" "-f" "409bf86253028b56cb62b033f8273ef823b8f63cac309d665d62e941a88c2610"` [INFO] [stdout] 409bf86253028b56cb62b033f8273ef823b8f63cac309d665d62e941a88c2610