[INFO] crate spider 1.1.1 is already in cache [INFO] extracting crate spider 1.1.1 into work/ex/clippy-test-run/sources/stable/reg/spider/1.1.1 [INFO] extracting crate spider 1.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spider/1.1.1 [INFO] validating manifest of spider-1.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spider-1.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spider-1.1.1 [INFO] finished frobbing spider-1.1.1 [INFO] frobbed toml for spider-1.1.1 written to work/ex/clippy-test-run/sources/stable/reg/spider/1.1.1/Cargo.toml [INFO] started frobbing spider-1.1.1 [INFO] finished frobbing spider-1.1.1 [INFO] frobbed toml for spider-1.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spider/1.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spider-1.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spider/1.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63982f0480277d0d65f161e740ef0f1976459670595acb34aeaa748f9cec5069 [INFO] running `"docker" "start" "-a" "63982f0480277d0d65f161e740ef0f1976459670595acb34aeaa748f9cec5069"` [INFO] [stderr] Checking utf-8 v0.6.0 [INFO] [stderr] Checking cssparser v0.5.8 [INFO] [stderr] Checking quickersort v2.2.0 [INFO] [stderr] Compiling string_cache v0.2.29 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Compiling html5ever v0.5.4 [INFO] [stderr] Checking tendril v0.2.4 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking selectors v0.5.9 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking scraper v0.4.0 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking robotparser v0.10.2 [INFO] [stderr] Checking spider v1.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/website.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | links: links, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `links` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/website.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | links: links, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `links` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/website.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/website.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | while self.links.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.links.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/website.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | / match worker.join() { [INFO] [stderr] 85 | | Ok(page) => { [INFO] [stderr] 86 | | // get links founded on [INFO] [stderr] 87 | | for link_founded in page.links(&self.domain) { [INFO] [stderr] ... | [INFO] [stderr] 99 | | Err(_) => (), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Ok(page) = worker.join() { [INFO] [stderr] 85 | // get links founded on [INFO] [stderr] 86 | for link_founded in page.links(&self.domain) { [INFO] [stderr] 87 | // add only links not already vistited [INFO] [stderr] 88 | if !self.links_visited.contains(&link_founded) { [INFO] [stderr] 89 | new_links.push(link_founded); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/website.rs:112:36 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn is_allowed(&self, link: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/page.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / match element.value().attr("href") { [INFO] [stderr] 59 | | Some(href) => { [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | // Keep only links for this domains [INFO] [stderr] ... | [INFO] [stderr] 68 | | None => (), [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let Some(href) = element.value().attr("href") { [INFO] [stderr] 59 | [INFO] [stderr] 60 | // Keep only links for this domains [INFO] [stderr] 61 | match href.find('/') { [INFO] [stderr] 62 | Some(0) => urls.push(format!("{}{}", domain, href)), [INFO] [stderr] 63 | Some(_) => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `configuration::Configuration` [INFO] [stderr] --> src/configuration.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | Self { [INFO] [stderr] 22 | | respect_robots_txt: false, [INFO] [stderr] 23 | | verbose: false, [INFO] [stderr] 24 | | blacklist_url: Vec::new(), [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/website.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/website.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | while self.links.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.links.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/website.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | / match worker.join() { [INFO] [stderr] 85 | | Ok(page) => { [INFO] [stderr] 86 | | // get links founded on [INFO] [stderr] 87 | | for link_founded in page.links(&self.domain) { [INFO] [stderr] ... | [INFO] [stderr] 99 | | Err(_) => (), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Ok(page) = worker.join() { [INFO] [stderr] 85 | // get links founded on [INFO] [stderr] 86 | for link_founded in page.links(&self.domain) { [INFO] [stderr] 87 | // add only links not already vistited [INFO] [stderr] 88 | if !self.links_visited.contains(&link_founded) { [INFO] [stderr] 89 | new_links.push(link_founded); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/website.rs:112:36 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn is_allowed(&self, link: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/page.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / match element.value().attr("href") { [INFO] [stderr] 59 | | Some(href) => { [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | // Keep only links for this domains [INFO] [stderr] ... | [INFO] [stderr] 68 | | None => (), [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let Some(href) = element.value().attr("href") { [INFO] [stderr] 59 | [INFO] [stderr] 60 | // Keep only links for this domains [INFO] [stderr] 61 | match href.find('/') { [INFO] [stderr] 62 | Some(0) => urls.push(format!("{}{}", domain, href)), [INFO] [stderr] 63 | Some(_) => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `configuration::Configuration` [INFO] [stderr] --> src/configuration.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | Self { [INFO] [stderr] 22 | | respect_robots_txt: false, [INFO] [stderr] 23 | | verbose: false, [INFO] [stderr] 24 | | blacklist_url: Vec::new(), [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `"docker" "inspect" "63982f0480277d0d65f161e740ef0f1976459670595acb34aeaa748f9cec5069"` [INFO] running `"docker" "rm" "-f" "63982f0480277d0d65f161e740ef0f1976459670595acb34aeaa748f9cec5069"` [INFO] [stdout] 63982f0480277d0d65f161e740ef0f1976459670595acb34aeaa748f9cec5069