[INFO] crate specs-static 0.2.0 is already in cache [INFO] extracting crate specs-static 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/specs-static/0.2.0 [INFO] extracting crate specs-static 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/specs-static/0.2.0 [INFO] validating manifest of specs-static-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of specs-static-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing specs-static-0.2.0 [INFO] finished frobbing specs-static-0.2.0 [INFO] frobbed toml for specs-static-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/specs-static/0.2.0/Cargo.toml [INFO] started frobbing specs-static-0.2.0 [INFO] finished frobbing specs-static-0.2.0 [INFO] frobbed toml for specs-static-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/specs-static/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting specs-static-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/specs-static/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 522048aff35e31987f9a73c445e2067b6484caf203443c1c7ed4bee78a39e8fc [INFO] running `"docker" "start" "-a" "522048aff35e31987f9a73c445e2067b6484caf203443c1c7ed4bee78a39e8fc"` [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking specs v0.11.2 [INFO] [stderr] Checking specs-static v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / match self.bitset.contains(id.id()) { [INFO] [stderr] 81 | | true => unsafe { Some(self.data.get(id.id())) }, [INFO] [stderr] 82 | | false => None, [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.bitset.contains(id.id()) unsafe { Some(self.data.get(id.id())) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / match self.bitset.contains(id.id()) { [INFO] [stderr] 91 | | true => unsafe { Some(self.data.get_mut(id.id())) }, [INFO] [stderr] 92 | | false => None, [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.bitset.contains(id.id()) unsafe { Some(self.data.get_mut(id.id())) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | let old = match self.bitset.add(id.id()) { [INFO] [stderr] | ___________________^ [INFO] [stderr] 101 | | true => unsafe { Some(self.data.remove(id.id())) }, [INFO] [stderr] 102 | | false => None, [INFO] [stderr] 103 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.bitset.add(id.id()) unsafe { Some(self.data.remove(id.id())) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self.bitset.remove(id.id()) { [INFO] [stderr] 115 | | true => unsafe { Some(self.data.remove(id.id())) }, [INFO] [stderr] 116 | | false => None, [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.bitset.remove(id.id()) unsafe { Some(self.data.remove(id.id())) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / match self.bitset.contains(id.id()) { [INFO] [stderr] 81 | | true => unsafe { Some(self.data.get(id.id())) }, [INFO] [stderr] 82 | | false => None, [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.bitset.contains(id.id()) unsafe { Some(self.data.get(id.id())) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / match self.bitset.contains(id.id()) { [INFO] [stderr] 91 | | true => unsafe { Some(self.data.get_mut(id.id())) }, [INFO] [stderr] 92 | | false => None, [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.bitset.contains(id.id()) unsafe { Some(self.data.get_mut(id.id())) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | let old = match self.bitset.add(id.id()) { [INFO] [stderr] | ___________________^ [INFO] [stderr] 101 | | true => unsafe { Some(self.data.remove(id.id())) }, [INFO] [stderr] 102 | | false => None, [INFO] [stderr] 103 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.bitset.add(id.id()) unsafe { Some(self.data.remove(id.id())) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self.bitset.remove(id.id()) { [INFO] [stderr] 115 | | true => unsafe { Some(self.data.remove(id.id())) }, [INFO] [stderr] 116 | | false => None, [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.bitset.remove(id.id()) unsafe { Some(self.data.remove(id.id())) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> examples/basic.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | d.dispatch(&mut w.res); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.45s [INFO] running `"docker" "inspect" "522048aff35e31987f9a73c445e2067b6484caf203443c1c7ed4bee78a39e8fc"` [INFO] running `"docker" "rm" "-f" "522048aff35e31987f9a73c445e2067b6484caf203443c1c7ed4bee78a39e8fc"` [INFO] [stdout] 522048aff35e31987f9a73c445e2067b6484caf203443c1c7ed4bee78a39e8fc