[INFO] crate specs-hierarchy 0.3.0 is already in cache
[INFO] extracting crate specs-hierarchy 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/specs-hierarchy/0.3.0
[INFO] extracting crate specs-hierarchy 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/specs-hierarchy/0.3.0
[INFO] validating manifest of specs-hierarchy-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of specs-hierarchy-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing specs-hierarchy-0.3.0
[INFO] finished frobbing specs-hierarchy-0.3.0
[INFO] frobbed toml for specs-hierarchy-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/specs-hierarchy/0.3.0/Cargo.toml
[INFO] started frobbing specs-hierarchy-0.3.0
[INFO] finished frobbing specs-hierarchy-0.3.0
[INFO] frobbed toml for specs-hierarchy-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/specs-hierarchy/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting specs-hierarchy-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/specs-hierarchy/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bd300ae691d9fff90be66a8471060c3105e4e6aab49fdafafc9cb51bf87b91a0
[INFO] running `"docker" "start" "-a" "bd300ae691d9fff90be66a8471060c3105e4e6aab49fdafafc9cb51bf87b91a0"`
[INFO] [stderr]    Compiling nonzero_signed v1.0.3
[INFO] [stderr]     Checking crossbeam-deque v0.5.2
[INFO] [stderr]     Checking crossbeam-channel v0.2.6
[INFO] [stderr]     Checking crossbeam v0.4.1
[INFO] [stderr]     Checking specs v0.14.3
[INFO] [stderr]     Checking specs-hierarchy v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:173:5
[INFO] [stderr]     |
[INFO] [stderr] 173 | /     pub fn all_children_iter<'a>(&'a self, entity: Entity) -> SubHierarchyIterator<'a, P> {
[INFO] [stderr] 174 | |         SubHierarchyIterator::new(self, entity)
[INFO] [stderr] 175 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 35
[INFO] [stderr]    --> src/lib.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 193 | /     pub fn maintain(&mut self, data: ParentData<P>)
[INFO] [stderr] 194 | |     where
[INFO] [stderr] 195 | |         P: Component + Parent,
[INFO] [stderr] 196 | |         P::Storage: Tracked,
[INFO] [stderr] ...   |
[INFO] [stderr] 405 | |         }
[INFO] [stderr] 406 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:299:18
[INFO] [stderr]     |
[INFO] [stderr] 299 |                 .unwrap_or(self.sorted.len());
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.sorted.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:295:45
[INFO] [stderr]     |
[INFO] [stderr] 295 |                         .map(|child_entity| self.entities.get(&child_entity.id()).unwrap())
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.entities[&child_entity.id()]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HierarchySystem<P>`
[INFO] [stderr]    --> src/lib.rs:547:5
[INFO] [stderr]     |
[INFO] [stderr] 547 | /     pub fn new() -> Self {
[INFO] [stderr] 548 | |         HierarchySystem { m: PhantomData }
[INFO] [stderr] 549 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 542 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:173:5
[INFO] [stderr]     |
[INFO] [stderr] 173 | /     pub fn all_children_iter<'a>(&'a self, entity: Entity) -> SubHierarchyIterator<'a, P> {
[INFO] [stderr] 174 | |         SubHierarchyIterator::new(self, entity)
[INFO] [stderr] 175 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 35
[INFO] [stderr]    --> src/lib.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 193 | /     pub fn maintain(&mut self, data: ParentData<P>)
[INFO] [stderr] 194 | |     where
[INFO] [stderr] 195 | |         P: Component + Parent,
[INFO] [stderr] 196 | |         P::Storage: Tracked,
[INFO] [stderr] ...   |
[INFO] [stderr] 405 | |         }
[INFO] [stderr] 406 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:299:18
[INFO] [stderr]     |
[INFO] [stderr] 299 |                 .unwrap_or(self.sorted.len());
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.sorted.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:295:45
[INFO] [stderr]     |
[INFO] [stderr] 295 |                         .map(|child_entity| self.entities.get(&child_entity.id()).unwrap())
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.entities[&child_entity.id()]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HierarchySystem<P>`
[INFO] [stderr]    --> src/lib.rs:547:5
[INFO] [stderr]     |
[INFO] [stderr] 547 | /     pub fn new() -> Self {
[INFO] [stderr] 548 | |         HierarchySystem { m: PhantomData }
[INFO] [stderr] 549 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 542 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:602:20
[INFO] [stderr]     |
[INFO] [stderr] 602 |               if let Err(_) = world.delete_entity(entity) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 603 | |                 println!("Failed removed entity");
[INFO] [stderr] 604 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if world.delete_entity(entity).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `run_now` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:626:24
[INFO] [stderr]     |
[INFO] [stderr] 626 |         system.run_now(&mut world.res);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `run_now` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:631:24
[INFO] [stderr]     |
[INFO] [stderr] 631 |         system.run_now(&mut world.res);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `run_now` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:639:24
[INFO] [stderr]     |
[INFO] [stderr] 639 |         system.run_now(&mut world.res);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `run_now` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:668:24
[INFO] [stderr]     |
[INFO] [stderr] 668 |         system.run_now(&mut world.res);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `run_now` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:697:24
[INFO] [stderr]     |
[INFO] [stderr] 697 |         system.run_now(&mut world.res);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference
[INFO] [stderr]   --> examples/sort.rs:47:25
[INFO] [stderr]    |
[INFO] [stderr] 47 |     dispatcher.dispatch(&mut world.res);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> examples/sort.rs:55:18
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 .unwrap_or(format!("None"));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("None"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> examples/sort.rs:55:28
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 .unwrap_or(format!("None"));
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"None".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 17.52s
[INFO] running `"docker" "inspect" "bd300ae691d9fff90be66a8471060c3105e4e6aab49fdafafc9cb51bf87b91a0"`
[INFO] running `"docker" "rm" "-f" "bd300ae691d9fff90be66a8471060c3105e4e6aab49fdafafc9cb51bf87b91a0"`
[INFO] [stdout] bd300ae691d9fff90be66a8471060c3105e4e6aab49fdafafc9cb51bf87b91a0