[INFO] crate specker 0.3.5 is already in cache [INFO] extracting crate specker 0.3.5 into work/ex/clippy-test-run/sources/stable/reg/specker/0.3.5 [INFO] extracting crate specker 0.3.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/specker/0.3.5 [INFO] validating manifest of specker-0.3.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of specker-0.3.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing specker-0.3.5 [INFO] finished frobbing specker-0.3.5 [INFO] frobbed toml for specker-0.3.5 written to work/ex/clippy-test-run/sources/stable/reg/specker/0.3.5/Cargo.toml [INFO] started frobbing specker-0.3.5 [INFO] finished frobbing specker-0.3.5 [INFO] frobbed toml for specker-0.3.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/specker/0.3.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting specker-0.3.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/specker/0.3.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e2e818119ffe247b7d12dc098e8ed78518b293b71b004ebd2b8241c91c881ce [INFO] running `"docker" "start" "-a" "5e2e818119ffe247b7d12dc098e8ed78518b293b71b004ebd2b8241c91c881ce"` [INFO] [stderr] Checking specker v0.3.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | token_iter: token_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(Spec { items: items }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:298:21 [INFO] [stderr] | [INFO] [stderr] 298 | LineGroup { tokens: tokens } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:321:29 [INFO] [stderr] | [INFO] [stderr] 321 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:332:33 [INFO] [stderr] | [INFO] [stderr] 332 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:333:33 [INFO] [stderr] | [INFO] [stderr] 333 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:339:29 [INFO] [stderr] | [INFO] [stderr] 339 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:351:59 [INFO] [stderr] | [INFO] [stderr] 351 | None => Err(LineGroupMatchErr::NewLineOrEof { pos: pos }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/combinator.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/combinator.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:144:29 [INFO] [stderr] | [INFO] [stderr] 144 | content_line_end: content_line_end, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_line_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | spec: spec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | extension: extension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | token_iter: token_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(Spec { items: items }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:298:21 [INFO] [stderr] | [INFO] [stderr] 298 | LineGroup { tokens: tokens } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:321:29 [INFO] [stderr] | [INFO] [stderr] 321 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:332:33 [INFO] [stderr] | [INFO] [stderr] 332 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:333:33 [INFO] [stderr] | [INFO] [stderr] 333 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:339:29 [INFO] [stderr] | [INFO] [stderr] 339 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:351:59 [INFO] [stderr] | [INFO] [stderr] 351 | None => Err(LineGroupMatchErr::NewLineOrEof { pos: pos }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/combinator.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/combinator.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:144:29 [INFO] [stderr] | [INFO] [stderr] 144 | content_line_end: content_line_end, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_line_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens/mod.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | spec: spec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | extension: extension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/display/mod.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 154 | | if self.lo == self.hi { [INFO] [stderr] 155 | | format!("{} in {:?} at {}", &self.desc, display_file_name, self.lo) [INFO] [stderr] 156 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 153 | } else if self.lo == self.hi { [INFO] [stderr] 154 | format!("{} in {:?} at {}", &self.desc, display_file_name, self.lo) [INFO] [stderr] 155 | } else { [INFO] [stderr] 156 | format!( [INFO] [stderr] 157 | "{} in {:?} at {} - {}", [INFO] [stderr] 158 | &self.desc, display_file_name, self.lo, self.hi [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/spec.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | / if !skip_lines_state { [INFO] [stderr] 264 | | if pos.byte < contents.len() || (had_new_line && contents.len() > 0) { [INFO] [stderr] 265 | | return Err(TemplateMatchError::ExpectedEof.at(pos, pos)); [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 263 | if !skip_lines_state && (pos.byte < contents.len() || (had_new_line && contents.len() > 0)) { [INFO] [stderr] 264 | return Err(TemplateMatchError::ExpectedEof.at(pos, pos)); [INFO] [stderr] 265 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens/combinator.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens/combinator.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return Ok(Contents::new(input, start_cursor, *cursor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Contents::new(input, start_cursor, *cursor))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens/combinator.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / return Ok(( [INFO] [stderr] 124 | | Contents::new(input, start_cursor, *cursor), [INFO] [stderr] 125 | | TermType::EolOrEof, [INFO] [stderr] 126 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 123 | Ok(( [INFO] [stderr] 124 | Contents::new(input, start_cursor, *cursor), [INFO] [stderr] 125 | TermType::EolOrEof, [INFO] [stderr] 126 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokens/mod.rs:185:32 [INFO] [stderr] | [INFO] [stderr] 185 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 186 | | if self.cursor.byte == self.input.len() { [INFO] [stderr] 187 | | self.token(TokenValueRef::MatchAnyNumberOfLines, pos, pos); [INFO] [stderr] 188 | | LexState::Eol [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 185 | } else if self.cursor.byte == self.input.len() { [INFO] [stderr] 186 | self.token(TokenValueRef::MatchAnyNumberOfLines, pos, pos); [INFO] [stderr] 187 | LexState::Eol [INFO] [stderr] 188 | } else { [INFO] [stderr] 189 | return Err(LexError::ExpectedNewline [INFO] [stderr] 190 | .at(self.cursor.clone(), self.cursor.clone())); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/display/mod.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 154 | | if self.lo == self.hi { [INFO] [stderr] 155 | | format!("{} in {:?} at {}", &self.desc, display_file_name, self.lo) [INFO] [stderr] 156 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 153 | } else if self.lo == self.hi { [INFO] [stderr] 154 | format!("{} in {:?} at {}", &self.desc, display_file_name, self.lo) [INFO] [stderr] 155 | } else { [INFO] [stderr] 156 | format!( [INFO] [stderr] 157 | "{} in {:?} at {} - {}", [INFO] [stderr] 158 | &self.desc, display_file_name, self.lo, self.hi [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/spec.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | / if !skip_lines_state { [INFO] [stderr] 264 | | if pos.byte < contents.len() || (had_new_line && contents.len() > 0) { [INFO] [stderr] 265 | | return Err(TemplateMatchError::ExpectedEof.at(pos, pos)); [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 263 | if !skip_lines_state && (pos.byte < contents.len() || (had_new_line && contents.len() > 0)) { [INFO] [stderr] 264 | return Err(TemplateMatchError::ExpectedEof.at(pos, pos)); [INFO] [stderr] 265 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens/combinator.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens/combinator.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return Ok(Contents::new(input, start_cursor, *cursor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Contents::new(input, start_cursor, *cursor))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens/combinator.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / return Ok(( [INFO] [stderr] 124 | | Contents::new(input, start_cursor, *cursor), [INFO] [stderr] 125 | | TermType::EolOrEof, [INFO] [stderr] 126 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 123 | Ok(( [INFO] [stderr] 124 | Contents::new(input, start_cursor, *cursor), [INFO] [stderr] 125 | TermType::EolOrEof, [INFO] [stderr] 126 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokens/mod.rs:185:32 [INFO] [stderr] | [INFO] [stderr] 185 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 186 | | if self.cursor.byte == self.input.len() { [INFO] [stderr] 187 | | self.token(TokenValueRef::MatchAnyNumberOfLines, pos, pos); [INFO] [stderr] 188 | | LexState::Eol [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 185 | } else if self.cursor.byte == self.input.len() { [INFO] [stderr] 186 | self.token(TokenValueRef::MatchAnyNumberOfLines, pos, pos); [INFO] [stderr] 187 | LexState::Eol [INFO] [stderr] 188 | } else { [INFO] [stderr] 189 | return Err(LexError::ExpectedNewline [INFO] [stderr] 190 | .at(self.cursor.clone(), self.cursor.clone())); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/display/mod.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | if let None = lines { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 99 | | lines = Some(vec![String::from("")]); [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________- help: try this: `if lines.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `error::FilePosition` [INFO] [stderr] --> src/error.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | / pub fn new() -> FilePosition { [INFO] [stderr] 386 | | FilePosition { [INFO] [stderr] 387 | | line: 0, [INFO] [stderr] 388 | | col: 0, [INFO] [stderr] 389 | | byte: 0, [INFO] [stderr] 390 | | } [INFO] [stderr] 391 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 375 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/error.rs:399:25 [INFO] [stderr] | [INFO] [stderr] 399 | let mut other = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/spec.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn iter<'r>(&'r self) -> ItemIter<'r> { [INFO] [stderr] 61 | | self.into_iter() [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/spec.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | output.write(b"\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/spec.rs:133:46 [INFO] [stderr] | [INFO] [stderr] 133 | Ok(String::from_utf8(source).map_err(|e| TemplateWriteError::TemplateIsNotValidUtf8(e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TemplateWriteError::TemplateIsNotValidUtf8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/spec.rs:223:33 [INFO] [stderr] | [INFO] [stderr] 223 | / match err_match { [INFO] [stderr] 224 | | LineGroupMatchErr::Text { pos: err_pos, text } => { [INFO] [stderr] 225 | | return Err(TemplateMatchError::ExpectedTextFoundEof( [INFO] [stderr] 226 | | text.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 229 | | _ => (), [INFO] [stderr] 230 | | }; [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 223 | if let LineGroupMatchErr::Text { pos: err_pos, text } = err_match { [INFO] [stderr] 224 | return Err(TemplateMatchError::ExpectedTextFoundEof( [INFO] [stderr] 225 | text.to_string(), [INFO] [stderr] 226 | ).at(err_pos, eol_pos)) [INFO] [stderr] 227 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/spec.rs:264:62 [INFO] [stderr] | [INFO] [stderr] 264 | if pos.byte < contents.len() || (had_new_line && contents.len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tokens/combinator.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new<'r>(input: &'r [u8], lo: FilePosition, hi: FilePosition) -> Contents<'r> { [INFO] [stderr] 18 | | Contents { [INFO] [stderr] 19 | | slice: &input[lo.byte..hi.byte], [INFO] [stderr] 20 | | lo: lo, [INFO] [stderr] 21 | | hi: hi, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/combinator.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | let start_cursor = cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/combinator.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | let start_cursor = cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:179:35 [INFO] [stderr] | [INFO] [stderr] 179 | let pos = self.cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:191:41 [INFO] [stderr] | [INFO] [stderr] 191 | .at(self.cursor.clone(), self.cursor.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:191:62 [INFO] [stderr] | [INFO] [stderr] 191 | .at(self.cursor.clone(), self.cursor.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:217:34 [INFO] [stderr] | [INFO] [stderr] 217 | }.at(self.cursor.clone(), self.cursor.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:217:55 [INFO] [stderr] | [INFO] [stderr] 217 | }.at(self.cursor.clone(), self.cursor.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokens/mod.rs:237:24 [INFO] [stderr] | [INFO] [stderr] 237 | if contents.slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!contents.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:251:30 [INFO] [stderr] | [INFO] [stderr] 251 | let lo = self.cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:254:57 [INFO] [stderr] | [INFO] [stderr] 254 | content_line_end: Some((lo, self.cursor.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `specker`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/display/mod.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | if let None = lines { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 99 | | lines = Some(vec![String::from("")]); [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________- help: try this: `if lines.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `error::FilePosition` [INFO] [stderr] --> src/error.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | / pub fn new() -> FilePosition { [INFO] [stderr] 386 | | FilePosition { [INFO] [stderr] 387 | | line: 0, [INFO] [stderr] 388 | | col: 0, [INFO] [stderr] 389 | | byte: 0, [INFO] [stderr] 390 | | } [INFO] [stderr] 391 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 375 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/error.rs:399:25 [INFO] [stderr] | [INFO] [stderr] 399 | let mut other = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/spec.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn iter<'r>(&'r self) -> ItemIter<'r> { [INFO] [stderr] 61 | | self.into_iter() [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/spec.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | output.write(b"\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/spec.rs:133:46 [INFO] [stderr] | [INFO] [stderr] 133 | Ok(String::from_utf8(source).map_err(|e| TemplateWriteError::TemplateIsNotValidUtf8(e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TemplateWriteError::TemplateIsNotValidUtf8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/spec.rs:223:33 [INFO] [stderr] | [INFO] [stderr] 223 | / match err_match { [INFO] [stderr] 224 | | LineGroupMatchErr::Text { pos: err_pos, text } => { [INFO] [stderr] 225 | | return Err(TemplateMatchError::ExpectedTextFoundEof( [INFO] [stderr] 226 | | text.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 229 | | _ => (), [INFO] [stderr] 230 | | }; [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 223 | if let LineGroupMatchErr::Text { pos: err_pos, text } = err_match { [INFO] [stderr] 224 | return Err(TemplateMatchError::ExpectedTextFoundEof( [INFO] [stderr] 225 | text.to_string(), [INFO] [stderr] 226 | ).at(err_pos, eol_pos)) [INFO] [stderr] 227 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/spec.rs:264:62 [INFO] [stderr] | [INFO] [stderr] 264 | if pos.byte < contents.len() || (had_new_line && contents.len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tokens/combinator.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new<'r>(input: &'r [u8], lo: FilePosition, hi: FilePosition) -> Contents<'r> { [INFO] [stderr] 18 | | Contents { [INFO] [stderr] 19 | | slice: &input[lo.byte..hi.byte], [INFO] [stderr] 20 | | lo: lo, [INFO] [stderr] 21 | | hi: hi, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/combinator.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | let start_cursor = cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/combinator.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | let start_cursor = cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tokens/combinator.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / fn trim_pos<'a>(text: &'a [u8]) -> Contents<'a> { [INFO] [stderr] 144 | | let c = Contents::new( [INFO] [stderr] 145 | | text, [INFO] [stderr] 146 | | FilePosition::new(), [INFO] [stderr] ... | [INFO] [stderr] 149 | | c.trimmed() [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:179:35 [INFO] [stderr] | [INFO] [stderr] 179 | let pos = self.cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:191:41 [INFO] [stderr] | [INFO] [stderr] 191 | .at(self.cursor.clone(), self.cursor.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:191:62 [INFO] [stderr] | [INFO] [stderr] 191 | .at(self.cursor.clone(), self.cursor.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:217:34 [INFO] [stderr] | [INFO] [stderr] 217 | }.at(self.cursor.clone(), self.cursor.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:217:55 [INFO] [stderr] | [INFO] [stderr] 217 | }.at(self.cursor.clone(), self.cursor.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokens/mod.rs:237:24 [INFO] [stderr] | [INFO] [stderr] 237 | if contents.slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!contents.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:251:30 [INFO] [stderr] | [INFO] [stderr] 251 | let lo = self.cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokens/mod.rs:254:57 [INFO] [stderr] | [INFO] [stderr] 254 | content_line_end: Some((lo, self.cursor.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `specker`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5e2e818119ffe247b7d12dc098e8ed78518b293b71b004ebd2b8241c91c881ce"` [INFO] running `"docker" "rm" "-f" "5e2e818119ffe247b7d12dc098e8ed78518b293b71b004ebd2b8241c91c881ce"` [INFO] [stdout] 5e2e818119ffe247b7d12dc098e8ed78518b293b71b004ebd2b8241c91c881ce