[INFO] crate specinfra 0.3.0 is already in cache [INFO] extracting crate specinfra 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/specinfra/0.3.0 [INFO] extracting crate specinfra 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/specinfra/0.3.0 [INFO] validating manifest of specinfra-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of specinfra-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing specinfra-0.3.0 [INFO] finished frobbing specinfra-0.3.0 [INFO] frobbed toml for specinfra-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/specinfra/0.3.0/Cargo.toml [INFO] started frobbing specinfra-0.3.0 [INFO] finished frobbing specinfra-0.3.0 [INFO] frobbed toml for specinfra-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/specinfra/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting specinfra-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/specinfra/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e6da60001f05590f10ecce2bf5ff9334febcf33aec1f5863ba8d2390a47efc3 [INFO] running `"docker" "start" "-a" "8e6da60001f05590f10ecce2bf5ff9334febcf33aec1f5863ba8d2390a47efc3"` [INFO] [stderr] Checking users v0.5.3 [INFO] [stderr] Checking uname v0.1.1 [INFO] [stderr] Checking digest v0.6.2 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking sha2 v0.6.0 [INFO] [stderr] Checking specinfra v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/ssh.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | provider: provider, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/ssh.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | provider: provider, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/platform/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod platform; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/platform/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod platform; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backend::direct::Direct` [INFO] [stderr] --> src/backend/direct.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Direct { [INFO] [stderr] 17 | | Direct [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/backend/direct.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | while let Some(p) = platforms.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `for p in platforms { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/direct.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match p.inline_detector() { [INFO] [stderr] 26 | | Some(m) => return Some(m), [INFO] [stderr] 27 | | None => (), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Some(m) = p.inline_detector() { return Some(m) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/direct.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | / match p.shell_detector(self) { [INFO] [stderr] 31 | | Some(m) => return Some(m), [INFO] [stderr] 32 | | None => (), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(m) = p.shell_detector(self) { return Some(m) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/direct.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match handle_func.inline { [INFO] [stderr] 40 | | Some(f) => return f(), [INFO] [stderr] 41 | | None => {} [INFO] [stderr] 42 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(f) = handle_func.inline { return f() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/direct.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match handle_func.shell { [INFO] [stderr] 45 | | Some(f) => return f(self), [INFO] [stderr] 46 | | None => {} [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(f) = handle_func.shell { return f(self) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/backend/direct.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | Box::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backend::ssh::SSHBuilder` [INFO] [stderr] --> src/backend/ssh.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Self { [INFO] [stderr] 31 | | SSHBuilder { hostname: None } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/backend/ssh.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | while let Some(p) = platforms.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `for p in platforms { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/ssh.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / match p.shell_detector(self) { [INFO] [stderr] 61 | | Some(m) => return Some(m), [INFO] [stderr] 62 | | None => (), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(m) = p.shell_detector(self) { return Some(m) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/ssh.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match handle_func.shell { [INFO] [stderr] 70 | | Some(f) => return f(self), [INFO] [stderr] 71 | | None => {} [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(f) = handle_func.shell { return f(self) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/backend/ssh.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | CStr::from_ptr(host) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/backend/ssh.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | Box::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `platform::platforms::Platforms` [INFO] [stderr] --> src/platform/platforms.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Platforms { [INFO] [stderr] 12 | | let mut p: Vec>>> = Vec::new(); [INFO] [stderr] 13 | | p.push(Box::new(bsd::Bsd::new())); [INFO] [stderr] 14 | | Platforms { [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/resource/file.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | Box::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/resource/file.rs:45:11 [INFO] [stderr] | [INFO] [stderr] 45 | &*ptr [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/provider/file/inline/posix.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | .ok_or(format!("Failed to get user from uid: {}", uid))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Failed to get user from uid: {}", uid))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backend::direct::Direct` [INFO] [stderr] --> src/backend/direct.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Direct { [INFO] [stderr] 17 | | Direct [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/backend/direct.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | while let Some(p) = platforms.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `for p in platforms { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/direct.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match p.inline_detector() { [INFO] [stderr] 26 | | Some(m) => return Some(m), [INFO] [stderr] 27 | | None => (), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Some(m) = p.inline_detector() { return Some(m) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/direct.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | / match p.shell_detector(self) { [INFO] [stderr] 31 | | Some(m) => return Some(m), [INFO] [stderr] 32 | | None => (), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(m) = p.shell_detector(self) { return Some(m) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/provider/file/inline/posix.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | .ok_or(format!("Failed to get group from gid: {}", gid))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Failed to get group from gid: {}", gid))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/direct.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match handle_func.inline { [INFO] [stderr] 40 | | Some(f) => return f(), [INFO] [stderr] 41 | | None => {} [INFO] [stderr] 42 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(f) = handle_func.inline { return f() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/direct.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match handle_func.shell { [INFO] [stderr] 45 | | Some(f) => return f(self), [INFO] [stderr] 46 | | None => {} [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(f) = handle_func.shell { return f(self) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/backend/direct.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | Box::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backend::ssh::SSHBuilder` [INFO] [stderr] --> src/backend/ssh.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Self { [INFO] [stderr] 31 | | SSHBuilder { hostname: None } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/backend/ssh.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | while let Some(p) = platforms.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `for p in platforms { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/ssh.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / match p.shell_detector(self) { [INFO] [stderr] 61 | | Some(m) => return Some(m), [INFO] [stderr] 62 | | None => (), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(m) = p.shell_detector(self) { return Some(m) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backend/ssh.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match handle_func.shell { [INFO] [stderr] 70 | | Some(f) => return f(self), [INFO] [stderr] 71 | | None => {} [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(f) = handle_func.shell { return f(self) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/backend/ssh.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | CStr::from_ptr(host) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/backend/ssh.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | Box::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `platform::platforms::Platforms` [INFO] [stderr] --> src/platform/platforms.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Platforms { [INFO] [stderr] 12 | | let mut p: Vec>>> = Vec::new(); [INFO] [stderr] 13 | | p.push(Box::new(bsd::Bsd::new())); [INFO] [stderr] 14 | | Platforms { [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/resource/file.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | Box::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/resource/file.rs:45:11 [INFO] [stderr] | [INFO] [stderr] 45 | &*ptr [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/provider/file/inline/posix.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | .ok_or(format!("Failed to get user from uid: {}", uid))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Failed to get user from uid: {}", uid))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/provider/file/inline/posix.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | .ok_or(format!("Failed to get group from gid: {}", gid))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Failed to get group from gid: {}", gid))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/provider/mod.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | pub inline: Option Result>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/provider/mod.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | pub shell: Option Result>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/provider/mod.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn to_u32(o: Output) -> Result> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/provider/mod.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn to_i64(o: Output) -> Result> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/provider/mod.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn to_bool(o: Output) -> Result> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/provider/mod.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn to_string(o: Output) -> Result> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:69:11 [INFO] [stderr] | [INFO] [stderr] 69 | &*ptr [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | Box::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:88:11 [INFO] [stderr] | [INFO] [stderr] 88 | &*ptr [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | CStr::from_ptr(name) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `specinfra`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/provider/mod.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | pub inline: Option Result>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/provider/mod.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | pub shell: Option Result>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/provider/mod.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn to_u32(o: Output) -> Result> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/provider/mod.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn to_i64(o: Output) -> Result> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/provider/mod.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn to_bool(o: Output) -> Result> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/provider/mod.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn to_string(o: Output) -> Result> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:69:11 [INFO] [stderr] | [INFO] [stderr] 69 | &*ptr [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | Box::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:88:11 [INFO] [stderr] | [INFO] [stderr] 88 | &*ptr [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | CStr::from_ptr(name) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `specinfra`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8e6da60001f05590f10ecce2bf5ff9334febcf33aec1f5863ba8d2390a47efc3"` [INFO] running `"docker" "rm" "-f" "8e6da60001f05590f10ecce2bf5ff9334febcf33aec1f5863ba8d2390a47efc3"` [INFO] [stdout] 8e6da60001f05590f10ecce2bf5ff9334febcf33aec1f5863ba8d2390a47efc3