[INFO] crate spc 0.1.1 is already in cache [INFO] extracting crate spc 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/spc/0.1.1 [INFO] extracting crate spc 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spc/0.1.1 [INFO] validating manifest of spc-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spc-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spc-0.1.1 [INFO] finished frobbing spc-0.1.1 [INFO] frobbed toml for spc-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/spc/0.1.1/Cargo.toml [INFO] started frobbing spc-0.1.1 [INFO] finished frobbing spc-0.1.1 [INFO] frobbed toml for spc-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spc/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spc-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spc/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd743d3eca99dc06186df3ba0e1714aa020f6760c29dbc3e3f571fed13b56f93 [INFO] running `"docker" "start" "-a" "dd743d3eca99dc06186df3ba0e1714aa020f6760c29dbc3e3f571fed13b56f93"` [INFO] [stderr] Checking spc v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binary_reader.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | BinaryReader { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/spc.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | Err(e) => fail!(format!("Invalid ID666 tag: {}", e)) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | version_minor: version_minor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `version_minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | pc: pc, [INFO] [stderr] | ^^^^^^ help: replace it with: `pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | psw: psw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `psw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | sp: sp, [INFO] [stderr] | ^^^^^^ help: replace it with: `sp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | id666_tag: id666_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id666_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | ram: ram, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | regs: regs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `regs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | ipl_rom: ipl_rom [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ipl_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | song_title: song_title, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `song_title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | game_title: game_title, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | dumper_name: dumper_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dumper_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | comments: comments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | date_dumped: date_dumped, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_dumped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | seconds_to_play_before_fading_out: seconds_to_play_before_fading_out, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seconds_to_play_before_fading_out` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binary_reader.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | BinaryReader { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/spc.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | Err(e) => fail!(format!("Invalid ID666 tag: {}", e)) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] --> src/spc.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | fade_out_length: fade_out_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fade_out_length` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | version_minor: version_minor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `version_minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | pc: pc, [INFO] [stderr] | ^^^^^^ help: replace it with: `pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | psw: psw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `psw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | sp: sp, [INFO] [stderr] | ^^^^^^ help: replace it with: `sp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | id666_tag: id666_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id666_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | ram: ram, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | regs: regs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `regs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | ipl_rom: ipl_rom [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ipl_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | song_title: song_title, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `song_title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | artist_name: artist_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `artist_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | default_channel_disables: default_channel_disables, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_channel_disables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | game_title: game_title, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_title` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | dumping_emulator: dumping_emulator [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dumping_emulator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | dumper_name: dumper_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dumper_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | comments: comments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | date_dumped: date_dumped, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_dumped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | seconds_to_play_before_fading_out: seconds_to_play_before_fading_out, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seconds_to_play_before_fading_out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | fade_out_length: fade_out_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fade_out_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | artist_name: artist_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `artist_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | default_channel_disables: default_channel_disables, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_channel_disables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spc.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | dumping_emulator: dumping_emulator [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dumping_emulator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spc.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const HEADER_BYTES: &'static [u8; HEADER_LEN] = [INFO] [stderr] | -^^^^^^^----------------- help: consider removing `'static`: `&[u8; HEADER_LEN]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spc.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const HEADER_BYTES: &'static [u8; HEADER_LEN] = [INFO] [stderr] | -^^^^^^^----------------- help: consider removing `'static`: `&[u8; HEADER_LEN]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(((buf[1] as u16) << 8) | (buf[0] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(((buf[1] as u16) << 8) | (buf[0] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | ((buf[3] as u32) << 24) | ((buf[2] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | ((buf[3] as u32) << 24) | ((buf[2] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | ((buf[1] as u32) << 8) | (buf[0] as u32)) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | ((buf[1] as u32) << 8) | (buf[0] as u32)) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/spc.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | let id666_tag = match has_id666_tag { [INFO] [stderr] | _________________________^ [INFO] [stderr] 64 | | true => { [INFO] [stderr] 65 | | try!(r.seek(SeekFrom::Start(0x2e))); [INFO] [stderr] 66 | | match Id666Tag::load(&mut r) { [INFO] [stderr] ... | [INFO] [stderr] 71 | | false => None [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 63 | let id666_tag = if has_id666_tag { [INFO] [stderr] 64 | try!(r.seek(SeekFrom::Start(0x2e))); [INFO] [stderr] 65 | match Id666Tag::load(&mut r) { [INFO] [stderr] 66 | Ok(x) => Some(x), [INFO] [stderr] 67 | Err(e) => fail!(format!("Invalid ID666 tag: {}", e)) [INFO] [stderr] 68 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/spc.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | let is_text_format = match try!(Id666Tag::is_text_region(r, 11)) { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 138 | | true => { [INFO] [stderr] 139 | | try!(r.seek(SeekFrom::Start(0xa9))); [INFO] [stderr] 140 | | try!(Id666Tag::is_text_region(r, 3)) [INFO] [stderr] 141 | | }, [INFO] [stderr] 142 | | _ => false [INFO] [stderr] 143 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 137 | let is_text_format = if match $ expr { [INFO] [stderr] 138 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 139 | :: Err ( err ) => { [INFO] [stderr] 140 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 141 | $ crate :: convert :: From :: from ( err ) ) } } { [INFO] [stderr] 142 | try!(r.seek(SeekFrom::Start(0xa9))); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/spc.rs:202:38 [INFO] [stderr] | [INFO] [stderr] 202 | match char::from_u32(b as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/spc.rs:216:49 [INFO] [stderr] | [INFO] [stderr] 216 | if let Some(c) = char::from_u32(b as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/spc.rs:232:30 [INFO] [stderr] | [INFO] [stderr] 232 | match char::from_u32(d as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(((buf[1] as u16) << 8) | (buf[0] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(((buf[1] as u16) << 8) | (buf[0] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | ((buf[3] as u32) << 24) | ((buf[2] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | ((buf[3] as u32) << 24) | ((buf[2] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | ((buf[1] as u32) << 8) | (buf[0] as u32)) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/binary_reader.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | ((buf[1] as u32) << 8) | (buf[0] as u32)) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/spc.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | let id666_tag = match has_id666_tag { [INFO] [stderr] | _________________________^ [INFO] [stderr] 64 | | true => { [INFO] [stderr] 65 | | try!(r.seek(SeekFrom::Start(0x2e))); [INFO] [stderr] 66 | | match Id666Tag::load(&mut r) { [INFO] [stderr] ... | [INFO] [stderr] 71 | | false => None [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 63 | let id666_tag = if has_id666_tag { [INFO] [stderr] 64 | try!(r.seek(SeekFrom::Start(0x2e))); [INFO] [stderr] 65 | match Id666Tag::load(&mut r) { [INFO] [stderr] 66 | Ok(x) => Some(x), [INFO] [stderr] 67 | Err(e) => fail!(format!("Invalid ID666 tag: {}", e)) [INFO] [stderr] 68 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/spc.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | let is_text_format = match try!(Id666Tag::is_text_region(r, 11)) { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 138 | | true => { [INFO] [stderr] 139 | | try!(r.seek(SeekFrom::Start(0xa9))); [INFO] [stderr] 140 | | try!(Id666Tag::is_text_region(r, 3)) [INFO] [stderr] 141 | | }, [INFO] [stderr] 142 | | _ => false [INFO] [stderr] 143 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 137 | let is_text_format = if match $ expr { [INFO] [stderr] 138 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 139 | :: Err ( err ) => { [INFO] [stderr] 140 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 141 | $ crate :: convert :: From :: from ( err ) ) } } { [INFO] [stderr] 142 | try!(r.seek(SeekFrom::Start(0xa9))); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/spc.rs:202:38 [INFO] [stderr] | [INFO] [stderr] 202 | match char::from_u32(b as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/spc.rs:216:49 [INFO] [stderr] | [INFO] [stderr] 216 | if let Some(c) = char::from_u32(b as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/spc.rs:232:30 [INFO] [stderr] | [INFO] [stderr] 232 | match char::from_u32(d as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "dd743d3eca99dc06186df3ba0e1714aa020f6760c29dbc3e3f571fed13b56f93"` [INFO] running `"docker" "rm" "-f" "dd743d3eca99dc06186df3ba0e1714aa020f6760c29dbc3e3f571fed13b56f93"` [INFO] [stdout] dd743d3eca99dc06186df3ba0e1714aa020f6760c29dbc3e3f571fed13b56f93