[INFO] crate spatial 0.2.0-rc2 is already in cache [INFO] extracting crate spatial 0.2.0-rc2 into work/ex/clippy-test-run/sources/stable/reg/spatial/0.2.0-rc2 [INFO] extracting crate spatial 0.2.0-rc2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spatial/0.2.0-rc2 [INFO] validating manifest of spatial-0.2.0-rc2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spatial-0.2.0-rc2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spatial-0.2.0-rc2 [INFO] finished frobbing spatial-0.2.0-rc2 [INFO] frobbed toml for spatial-0.2.0-rc2 written to work/ex/clippy-test-run/sources/stable/reg/spatial/0.2.0-rc2/Cargo.toml [INFO] started frobbing spatial-0.2.0-rc2 [INFO] finished frobbing spatial-0.2.0-rc2 [INFO] frobbed toml for spatial-0.2.0-rc2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spatial/0.2.0-rc2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spatial-0.2.0-rc2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spatial/0.2.0-rc2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d95977bd7fdc30519c8ba7b9f199c8fc1b816074a8351168d6cdb9bf83cdbc3f [INFO] running `"docker" "start" "-a" "d95977bd7fdc30519c8ba7b9f199c8fc1b816074a8351168d6cdb9bf83cdbc3f"` [INFO] [stderr] Checking generic-array v0.3.2 [INFO] [stderr] Checking ordered-float v0.2.3 [INFO] [stderr] Checking spatial v0.2.0-rc2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | Point{coords: coords} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coords` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | Rect{edges: edges} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:140:14 [INFO] [stderr] | [INFO] [stderr] 140 | Rect{edges: edges} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | Rect{edges: edges} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | preferred_min: preferred_min, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preferred_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | reinsert_m: reinsert_m, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reinsert_m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | choose_subtree_p: choose_subtree_p, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `choose_subtree_p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | min_k: min_k, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | max_k: max_k, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:294:26 [INFO] [stderr] | [INFO] [stderr] 294 | RTreeNode::Level{mbr: mbr, children: vec![root, split]} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mbr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | splitter: splitter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `splitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:322:37 [INFO] [stderr] | [INFO] [stderr] 322 | root = RTreeNode::Level{mbr: mbr, children: children}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mbr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:322:47 [INFO] [stderr] | [INFO] [stderr] 322 | root = RTreeNode::Level{mbr: mbr, children: children}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/leaf.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | MbrLeaf{geometry: geometry, item: item, _p: PhantomData, _dim: PhantomData} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/leaf.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | MbrLeaf{geometry: geometry, item: item, _p: PhantomData, _dim: PhantomData} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | MbrMap{insert_index: insert_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `insert_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | remove_index: remove_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remove_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | return LevelIter{query: query, root: root, level_stack: Vec::with_capacity(0), finished: true}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:135:44 [INFO] [stderr] | [INFO] [stderr] 135 | return LevelIter{query: query, root: root, level_stack: Vec::with_capacity(0), finished: true}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | LevelIter{query: query, root: root, level_stack: Vec::new(), finished: false} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | LevelIter{query: query, root: root, level_stack: Vec::new(), finished: false} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:232:33 [INFO] [stderr] | [INFO] [stderr] 232 | return LevelIterMut{query: query, root: root, level_stack: Vec::with_capacity(0), finished: true}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:232:47 [INFO] [stderr] | [INFO] [stderr] 232 | return LevelIterMut{query: query, root: root, level_stack: Vec::with_capacity(0), finished: true}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:234:22 [INFO] [stderr] | [INFO] [stderr] 234 | LevelIterMut{query: query, root: root, level_stack: Vec::new(), finished: false} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:234:36 [INFO] [stderr] | [INFO] [stderr] 234 | LevelIterMut{query: query, root: root, level_stack: Vec::new(), finished: false} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:333:31 [INFO] [stderr] | [INFO] [stderr] 333 | Iter{query: rc_query, level_iter: level_iter, leaf_iter: None, finished: false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `level_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:409:34 [INFO] [stderr] | [INFO] [stderr] 409 | IterMut{query: rc_query, level_iter: level_iter, leaf_iter: None, finished: false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `level_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | Point{coords: coords} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coords` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | Rect{edges: edges} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:140:14 [INFO] [stderr] | [INFO] [stderr] 140 | Rect{edges: edges} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | Rect{edges: edges} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | preferred_min: preferred_min, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preferred_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | reinsert_m: reinsert_m, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reinsert_m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | choose_subtree_p: choose_subtree_p, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `choose_subtree_p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | min_k: min_k, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | max_k: max_k, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/rstar.rs:294:26 [INFO] [stderr] | [INFO] [stderr] 294 | RTreeNode::Level{mbr: mbr, children: vec![root, split]} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mbr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | splitter: splitter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `splitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:322:37 [INFO] [stderr] | [INFO] [stderr] 322 | root = RTreeNode::Level{mbr: mbr, children: children}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mbr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:322:47 [INFO] [stderr] | [INFO] [stderr] 322 | root = RTreeNode::Level{mbr: mbr, children: children}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/index/r.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/leaf.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | MbrLeaf{geometry: geometry, item: item, _p: PhantomData, _dim: PhantomData} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/leaf.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | MbrLeaf{geometry: geometry, item: item, _p: PhantomData, _dim: PhantomData} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | MbrMap{insert_index: insert_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `insert_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | remove_index: remove_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remove_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | return LevelIter{query: query, root: root, level_stack: Vec::with_capacity(0), finished: true}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:135:44 [INFO] [stderr] | [INFO] [stderr] 135 | return LevelIter{query: query, root: root, level_stack: Vec::with_capacity(0), finished: true}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | LevelIter{query: query, root: root, level_stack: Vec::new(), finished: false} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | LevelIter{query: query, root: root, level_stack: Vec::new(), finished: false} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:232:33 [INFO] [stderr] | [INFO] [stderr] 232 | return LevelIterMut{query: query, root: root, level_stack: Vec::with_capacity(0), finished: true}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:232:47 [INFO] [stderr] | [INFO] [stderr] 232 | return LevelIterMut{query: query, root: root, level_stack: Vec::with_capacity(0), finished: true}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:234:22 [INFO] [stderr] | [INFO] [stderr] 234 | LevelIterMut{query: query, root: root, level_stack: Vec::new(), finished: false} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:234:36 [INFO] [stderr] | [INFO] [stderr] 234 | LevelIterMut{query: query, root: root, level_stack: Vec::new(), finished: false} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:333:31 [INFO] [stderr] | [INFO] [stderr] 333 | Iter{query: rc_query, level_iter: level_iter, leaf_iter: None, finished: false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `level_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mbr/map.rs:409:34 [INFO] [stderr] | [INFO] [stderr] 409 | IterMut{query: rc_query, level_iter: level_iter, leaf_iter: None, finished: false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `level_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/tree/mbr/index/mod.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | fn insert_into_root(&self, mut root: NODE, leaf: MbrLeaf
) -> NODE;
[INFO] [stderr] | ^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default
[INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr] = note: for more information, see issue #35203 ) -> NODE;
[INFO] [stderr] | ^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default
[INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr] = note: for more information, see issue #35203 , children: &Vec `
[INFO] [stderr] --> src/tree/mbr/index/rstar.rs:82:5
[INFO] [stderr] |
[INFO] [stderr] 82 | / pub fn new() -> RStarInsert {
[INFO] [stderr] 83 | | RStarInsert::new_with_options(D_MAX, D_REINSERT_P, D_SPLIT_P, D_CHOOSE_SUBTREE_P)
[INFO] [stderr] 84 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 60 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/tree/mbr/index/r.rs:37:56
[INFO] [stderr] |
[INFO] [stderr] 37 | children: &Vec , children: &mut Vec , children: &Vec ) -> MbrMap ,
[INFO] [stderr] 88 | | RRemove > {
[INFO] [stderr] | |_________________________________________________________________________________________________________________________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr]
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr] --> src/tree/mbr/mod.rs:115:5
[INFO] [stderr] |
[INFO] [stderr] 115 | / pub fn new() -> RStarTree {
[INFO] [stderr] 116 | | RStar::map_from_insert(RStarInsert::new())
[INFO] [stderr] 117 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr]
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::mbr::index::rstar::RStarInsert `
[INFO] [stderr] --> src/tree/mbr/index/rstar.rs:82:5
[INFO] [stderr] |
[INFO] [stderr] 82 | / pub fn new() -> RStarInsert {
[INFO] [stderr] 83 | | RStarInsert::new_with_options(D_MAX, D_REINSERT_P, D_SPLIT_P, D_CHOOSE_SUBTREE_P)
[INFO] [stderr] 84 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 60 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/tree/mbr/index/rstar.rs:353:43
[INFO] [stderr] |
[INFO] [stderr] 353 | let zero_one = Rect::from_corners(g_zero.clone(), g_one.clone());
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `g_zero`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/tree/mbr/index/rstar.rs:353:59
[INFO] [stderr] |
[INFO] [stderr] 353 | let zero_one = Rect::from_corners(g_zero.clone(), g_one.clone());
[INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `g_one`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/tree/mbr/index/r.rs:37:56
[INFO] [stderr] |
[INFO] [stderr] 37 | children: &Vec , children: &mut Vec ) -> MbrMap ,
[INFO] [stderr] 88 | | RRemove > {
[INFO] [stderr] | |_________________________________________________________________________________________________________________________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr]
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr] --> src/tree/mbr/mod.rs:115:5
[INFO] [stderr] |
[INFO] [stderr] 115 | / pub fn new() -> RStarTree {
[INFO] [stderr] 116 | | RStar::map_from_insert(RStarInsert::new())
[INFO] [stderr] 117 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/vecext.rs:131:38
[INFO] [stderr] |
[INFO] [stderr] 131 | fn contains_all(&self, that: &Vec