[INFO] crate sparx 0.1.1 is already in cache [INFO] extracting crate sparx 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/sparx/0.1.1 [INFO] extracting crate sparx 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sparx/0.1.1 [INFO] validating manifest of sparx-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sparx-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sparx-0.1.1 [INFO] finished frobbing sparx-0.1.1 [INFO] frobbed toml for sparx-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/sparx/0.1.1/Cargo.toml [INFO] started frobbing sparx-0.1.1 [INFO] finished frobbing sparx-0.1.1 [INFO] frobbed toml for sparx-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sparx/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sparx-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sparx/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 298707f17485d30b2239c5d2b2a459c61cef28d56625a432a460bf91419c0e59 [INFO] running `"docker" "start" "-a" "298707f17485d30b2239c5d2b2a459c61cef28d56625a432a460bf91419c0e59"` [INFO] [stderr] Checking sparx v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(left)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | k[1] = ((k[1] as u16).wrapping_add(k[0] as u16) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((k[1] as u16).wrapping_add(k[0] as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | (((k[1] >> 16) as u16).wrapping_add((k[0] >> 16) as u16) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((k[1] >> 16) as u16).wrapping_add((k[0] >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | k[3] = ((k[3] as u16) as u32) | (((k[3] >> 16) as u16).wrapping_add(c) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((k[3] as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | k[3] = ((k[3] as u16) as u32) | (((k[3] >> 16) as u16).wrapping_add(c) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((k[3] >> 16) as u16).wrapping_add(c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | k[0] = LittleEndian::read_u32(&key[0 * 4..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | k[1] = LittleEndian::read_u32(&key[1 * 4..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sparx64.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for c in 0..(2 * STEPS + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=2 * STEPS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | let x0 = LittleEndian::read_u32(&block[4 * 0..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:82:48 [INFO] [stderr] | [INFO] [stderr] 82 | let x1 = LittleEndian::read_u32(&block[4 * 1..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:84:35 [INFO] [stderr] | [INFO] [stderr] 84 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:85:44 [INFO] [stderr] | [INFO] [stderr] 85 | LittleEndian::write_u32(&mut block[4 * 0..], x0 ^ x1 ^ tmp); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | LittleEndian::write_u32(&mut block[4 * 1..], x0); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:102:48 [INFO] [stderr] | [INFO] [stderr] 102 | let x1 = LittleEndian::read_u32(&block[4 * 0..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:103:48 [INFO] [stderr] | [INFO] [stderr] 103 | let x0 = LittleEndian::read_u32(&block[4 * 1..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:105:35 [INFO] [stderr] | [INFO] [stderr] 105 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:106:44 [INFO] [stderr] | [INFO] [stderr] 106 | LittleEndian::write_u32(&mut block[4 * 0..], x0); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:107:44 [INFO] [stderr] | [INFO] [stderr] 107 | LittleEndian::write_u32(&mut block[4 * 1..], x0 ^ x1 ^ tmp); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:130:14 [INFO] [stderr] | [INFO] [stderr] 130 | let nc = (LittleEndian::read_u32(nonce) as u64) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LittleEndian::read_u32(nonce))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | k[1] = ((k[1] as u16).wrapping_add(k[0] as u16) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((k[1] as u16).wrapping_add(k[0] as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | (((k[1] >> 16) as u16).wrapping_add((k[0] >> 16) as u16) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((k[1] >> 16) as u16).wrapping_add((k[0] >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | k[3] = ((k[3] as u16).wrapping_add(k[2] as u16) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((k[3] as u16).wrapping_add(k[2] as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | (((k[3] >> 16) as u16).wrapping_add((k[2] >> 16) as u16).wrapping_add(c) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((k[3] >> 16) as u16).wrapping_add((k[2] >> 16) as u16).wrapping_add(c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:52:40 [INFO] [stderr] | [INFO] [stderr] 52 | k[0] = LittleEndian::read_u32(&key[0 * 4..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | k[1] = LittleEndian::read_u32(&key[1 * 4..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sparx128.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for c in 0..(4 * STEPS + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=4 * STEPS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let x0 = LittleEndian::read_u32(&block[4 * 0..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | let x1 = LittleEndian::read_u32(&block[4 * 1..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:90:15 [INFO] [stderr] | [INFO] [stderr] 90 | x2 = ((((x2 as u16) ^ (x1 as u16)) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((x2 as u16) ^ (x1 as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:91:15 [INFO] [stderr] | [INFO] [stderr] 91 | ((((x2 >> 16) as u16) ^ ((x0 >> 16) as u16)) as u32) << 16) ^ tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((x2 >> 16) as u16) ^ ((x0 >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:92:15 [INFO] [stderr] | [INFO] [stderr] 92 | x3 = ((((x3 as u16) ^ (x0 as u16)) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((x3 as u16) ^ (x0 as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:93:15 [INFO] [stderr] | [INFO] [stderr] 93 | ((((x3 >> 16) as u16) ^ ((x1 >> 16) as u16)) as u32) << 16) ^ tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((x3 >> 16) as u16) ^ ((x1 >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | LittleEndian::write_u32(&mut block[4 * 0..], x2); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:95:44 [INFO] [stderr] | [INFO] [stderr] 95 | LittleEndian::write_u32(&mut block[4 * 1..], x3); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:115:52 [INFO] [stderr] | [INFO] [stderr] 115 | let mut x2 = LittleEndian::read_u32(&block[4 * 0..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:116:52 [INFO] [stderr] | [INFO] [stderr] 116 | let mut x3 = LittleEndian::read_u32(&block[4 * 1..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:119:35 [INFO] [stderr] | [INFO] [stderr] 119 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:120:15 [INFO] [stderr] | [INFO] [stderr] 120 | x2 = ((((x2 as u16) ^ (x1 as u16)) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((x2 as u16) ^ (x1 as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:121:15 [INFO] [stderr] | [INFO] [stderr] 121 | ((((x2 >> 16) as u16) ^ ((x0 >> 16) as u16)) as u32) << 16) ^ tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((x2 >> 16) as u16) ^ ((x0 >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:122:15 [INFO] [stderr] | [INFO] [stderr] 122 | x3 = ((((x3 as u16) ^ (x0 as u16)) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((x3 as u16) ^ (x0 as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:123:15 [INFO] [stderr] | [INFO] [stderr] 123 | ((((x3 >> 16) as u16) ^ ((x1 >> 16) as u16)) as u32) << 16) ^ tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((x3 >> 16) as u16) ^ ((x1 >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:124:44 [INFO] [stderr] | [INFO] [stderr] 124 | LittleEndian::write_u32(&mut block[4 * 0..], x0); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:125:44 [INFO] [stderr] | [INFO] [stderr] 125 | LittleEndian::write_u32(&mut block[4 * 1..], x1); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sparx128.rs:151:14 [INFO] [stderr] | [INFO] [stderr] 151 | for i in 0..(BLOCK_SIZE - 6) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `nc[..(BLOCK_SIZE - 6)].clone_from_slice(&nonce[..(BLOCK_SIZE - 6)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sparx`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(left)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | k[1] = ((k[1] as u16).wrapping_add(k[0] as u16) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((k[1] as u16).wrapping_add(k[0] as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | (((k[1] >> 16) as u16).wrapping_add((k[0] >> 16) as u16) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((k[1] >> 16) as u16).wrapping_add((k[0] >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | k[3] = ((k[3] as u16) as u32) | (((k[3] >> 16) as u16).wrapping_add(c) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((k[3] as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | k[3] = ((k[3] as u16) as u32) | (((k[3] >> 16) as u16).wrapping_add(c) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((k[3] >> 16) as u16).wrapping_add(c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | k[0] = LittleEndian::read_u32(&key[0 * 4..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | k[1] = LittleEndian::read_u32(&key[1 * 4..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sparx64.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for c in 0..(2 * STEPS + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=2 * STEPS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | let x0 = LittleEndian::read_u32(&block[4 * 0..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:82:48 [INFO] [stderr] | [INFO] [stderr] 82 | let x1 = LittleEndian::read_u32(&block[4 * 1..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:84:35 [INFO] [stderr] | [INFO] [stderr] 84 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:85:44 [INFO] [stderr] | [INFO] [stderr] 85 | LittleEndian::write_u32(&mut block[4 * 0..], x0 ^ x1 ^ tmp); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | LittleEndian::write_u32(&mut block[4 * 1..], x0); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:102:48 [INFO] [stderr] | [INFO] [stderr] 102 | let x1 = LittleEndian::read_u32(&block[4 * 0..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:103:48 [INFO] [stderr] | [INFO] [stderr] 103 | let x0 = LittleEndian::read_u32(&block[4 * 1..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:105:35 [INFO] [stderr] | [INFO] [stderr] 105 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx64.rs:106:44 [INFO] [stderr] | [INFO] [stderr] 106 | LittleEndian::write_u32(&mut block[4 * 0..], x0); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx64.rs:107:44 [INFO] [stderr] | [INFO] [stderr] 107 | LittleEndian::write_u32(&mut block[4 * 1..], x0 ^ x1 ^ tmp); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sparx64.rs:130:14 [INFO] [stderr] | [INFO] [stderr] 130 | let nc = (LittleEndian::read_u32(nonce) as u64) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LittleEndian::read_u32(nonce))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | *k = (left as u32) | ((right as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | k[1] = ((k[1] as u16).wrapping_add(k[0] as u16) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((k[1] as u16).wrapping_add(k[0] as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | (((k[1] >> 16) as u16).wrapping_add((k[0] >> 16) as u16) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((k[1] >> 16) as u16).wrapping_add((k[0] >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | k[3] = ((k[3] as u16).wrapping_add(k[2] as u16) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((k[3] as u16).wrapping_add(k[2] as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | (((k[3] >> 16) as u16).wrapping_add((k[2] >> 16) as u16).wrapping_add(c) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((k[3] >> 16) as u16).wrapping_add((k[2] >> 16) as u16).wrapping_add(c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:52:40 [INFO] [stderr] | [INFO] [stderr] 52 | k[0] = LittleEndian::read_u32(&key[0 * 4..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | k[1] = LittleEndian::read_u32(&key[1 * 4..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sparx128.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for c in 0..(4 * STEPS + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=4 * STEPS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let x0 = LittleEndian::read_u32(&block[4 * 0..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | let x1 = LittleEndian::read_u32(&block[4 * 1..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:90:15 [INFO] [stderr] | [INFO] [stderr] 90 | x2 = ((((x2 as u16) ^ (x1 as u16)) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((x2 as u16) ^ (x1 as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:91:15 [INFO] [stderr] | [INFO] [stderr] 91 | ((((x2 >> 16) as u16) ^ ((x0 >> 16) as u16)) as u32) << 16) ^ tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((x2 >> 16) as u16) ^ ((x0 >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:92:15 [INFO] [stderr] | [INFO] [stderr] 92 | x3 = ((((x3 as u16) ^ (x0 as u16)) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((x3 as u16) ^ (x0 as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:93:15 [INFO] [stderr] | [INFO] [stderr] 93 | ((((x3 >> 16) as u16) ^ ((x1 >> 16) as u16)) as u32) << 16) ^ tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((x3 >> 16) as u16) ^ ((x1 >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | LittleEndian::write_u32(&mut block[4 * 0..], x2); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:95:44 [INFO] [stderr] | [INFO] [stderr] 95 | LittleEndian::write_u32(&mut block[4 * 1..], x3); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:115:52 [INFO] [stderr] | [INFO] [stderr] 115 | let mut x2 = LittleEndian::read_u32(&block[4 * 0..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:116:52 [INFO] [stderr] | [INFO] [stderr] 116 | let mut x3 = LittleEndian::read_u32(&block[4 * 1..]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:119:35 [INFO] [stderr] | [INFO] [stderr] 119 | let tmp = (tmp as u32) | ((tmp as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:120:15 [INFO] [stderr] | [INFO] [stderr] 120 | x2 = ((((x2 as u16) ^ (x1 as u16)) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((x2 as u16) ^ (x1 as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:121:15 [INFO] [stderr] | [INFO] [stderr] 121 | ((((x2 >> 16) as u16) ^ ((x0 >> 16) as u16)) as u32) << 16) ^ tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((x2 >> 16) as u16) ^ ((x0 >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:122:15 [INFO] [stderr] | [INFO] [stderr] 122 | x3 = ((((x3 as u16) ^ (x0 as u16)) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((x3 as u16) ^ (x0 as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sparx128.rs:123:15 [INFO] [stderr] | [INFO] [stderr] 123 | ((((x3 >> 16) as u16) ^ ((x1 >> 16) as u16)) as u32) << 16) ^ tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(((x3 >> 16) as u16) ^ ((x1 >> 16) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/sparx128.rs:124:44 [INFO] [stderr] | [INFO] [stderr] 124 | LittleEndian::write_u32(&mut block[4 * 0..], x0); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/sparx128.rs:125:44 [INFO] [stderr] | [INFO] [stderr] 125 | LittleEndian::write_u32(&mut block[4 * 1..], x1); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sparx128.rs:151:14 [INFO] [stderr] | [INFO] [stderr] 151 | for i in 0..(BLOCK_SIZE - 6) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `nc[..(BLOCK_SIZE - 6)].clone_from_slice(&nonce[..(BLOCK_SIZE - 6)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sparx`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "298707f17485d30b2239c5d2b2a459c61cef28d56625a432a460bf91419c0e59"` [INFO] running `"docker" "rm" "-f" "298707f17485d30b2239c5d2b2a459c61cef28d56625a432a460bf91419c0e59"` [INFO] [stdout] 298707f17485d30b2239c5d2b2a459c61cef28d56625a432a460bf91419c0e59