[INFO] crate spaniel 0.1.0 is already in cache [INFO] extracting crate spaniel 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/spaniel/0.1.0 [INFO] extracting crate spaniel 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spaniel/0.1.0 [INFO] validating manifest of spaniel-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spaniel-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spaniel-0.1.0 [INFO] finished frobbing spaniel-0.1.0 [INFO] frobbed toml for spaniel-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/spaniel/0.1.0/Cargo.toml [INFO] started frobbing spaniel-0.1.0 [INFO] finished frobbing spaniel-0.1.0 [INFO] frobbed toml for spaniel-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spaniel/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spaniel-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spaniel/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 612a9ffb1f825c931cf1ebe76608763d9cfa13778ae4e8447359ea039d06b9b2 [INFO] running `"docker" "start" "-a" "612a9ffb1f825c931cf1ebe76608763d9cfa13778ae4e8447359ea039d06b9b2"` [INFO] [stderr] Checking spaniel v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/protocol/codec/mod.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/protocol/codec/mod.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | return Ok(AsyncSink::Ready); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(AsyncSink::Ready)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/frames.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | pub const MAGIC_NUM: u32 = 0xC0A1BA11; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC0A1_BA11` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/mod.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::Framed': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/mod.rs:11:47 [INFO] [stderr] | [INFO] [stderr] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/reader.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use tokio_io::codec::length_delimited; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/reader.rs:12:10 [INFO] [stderr] | [INFO] [stderr] 12 | src: length_delimited::FramedRead, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::Framed': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/mod.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | inner: Framed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::Builder': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/reader.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | let src = length_delimited::Builder::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::Builder': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/mod.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | inner: length_delimited::Builder::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/protocol/codec/mod.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/protocol/codec/mod.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | return Ok(AsyncSink::Ready); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(AsyncSink::Ready)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/frames.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | pub const MAGIC_NUM: u32 = 0xC0A1BA11; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC0A1_BA11` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/mod.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::Framed': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/mod.rs:11:47 [INFO] [stderr] | [INFO] [stderr] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/reader.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use tokio_io::codec::length_delimited; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/reader.rs:12:10 [INFO] [stderr] | [INFO] [stderr] 12 | src: length_delimited::FramedRead, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::Framed': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/mod.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | inner: Framed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::Builder': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/reader.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | let src = length_delimited::Builder::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::Builder': Moved to tokio-codec [INFO] [stderr] --> src/protocol/codec/mod.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | inner: length_delimited::Builder::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `src` [INFO] [stderr] --> src/protocol/frames.rs:305:28 [INFO] [stderr] | [INFO] [stderr] 305 | fn decode_from(src: &mut B) -> Result { [INFO] [stderr] | ^^^ help: consider using `_src` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dst` [INFO] [stderr] --> src/protocol/frames.rs:309:38 [INFO] [stderr] | [INFO] [stderr] 309 | fn encode_into(&self, dst: &mut B) -> Result<(), ()> { [INFO] [stderr] | ^^^ help: consider using `_dst` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `notify_all` [INFO] [stderr] --> src/connection.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | fn notify_all(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CreditBased` [INFO] [stderr] --> src/flow_control.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | CreditBased(FlowControlRatio), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_front` [INFO] [stderr] --> src/protocol/codec/buffer.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn push_front(&mut self, value: B) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Error` [INFO] [stderr] --> src/protocol/codec/writer.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | Error, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_watermarks` [INFO] [stderr] --> src/protocol/codec/writer.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn set_watermarks(&mut self, high: usize, low: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_and_flush` [INFO] [stderr] --> src/protocol/codec/writer.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn write_and_flush(&mut self, data: Bytes) -> Poll<(), std::io::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/connection.rs:106:55 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn get_stream_state_mut(&mut self, stream_id: &StreamId) -> Option<&mut StreamState> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `StreamId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/connection.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / match self.stream_states.get_mut(&stream_id) { [INFO] [stderr] 129 | | Some(_) => return Err(ConnectionError::InvalidStreamId), [INFO] [stderr] 130 | | None => (), [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = self.stream_states.get_mut(&stream_id) { return Err(ConnectionError::InvalidStreamId) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/connection.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | / loop { [INFO] [stderr] 392 | | match self.poll_read_progress() { [INFO] [stderr] 393 | | Ok(Async::Ready(())) => { [INFO] [stderr] 394 | | return Ok(Async::Ready(())); [INFO] [stderr] ... | [INFO] [stderr] 420 | | } [INFO] [stderr] 421 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/protocol/codec/reader.rs:39:60 [INFO] [stderr] | [INFO] [stderr] 39 | let bytes_res = try_ready!(self.src.poll().map_err(|err| FramingError::Io(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FramingError::Io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stream.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | / match ctx.get_stream_state_mut(&self.stream_id) { [INFO] [stderr] 213 | | Some(_) => return Err(()), // TODO StreamAlreadyExists [INFO] [stderr] 214 | | None => (), [INFO] [stderr] 215 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = ctx.get_stream_state_mut(&self.stream_id) { return Err(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `spaniel`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `src` [INFO] [stderr] --> src/protocol/frames.rs:305:28 [INFO] [stderr] | [INFO] [stderr] 305 | fn decode_from(src: &mut B) -> Result { [INFO] [stderr] | ^^^ help: consider using `_src` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dst` [INFO] [stderr] --> src/protocol/frames.rs:309:38 [INFO] [stderr] | [INFO] [stderr] 309 | fn encode_into(&self, dst: &mut B) -> Result<(), ()> { [INFO] [stderr] | ^^^ help: consider using `_dst` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `notify_all` [INFO] [stderr] --> src/connection.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | fn notify_all(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CreditBased` [INFO] [stderr] --> src/flow_control.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | CreditBased(FlowControlRatio), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_front` [INFO] [stderr] --> src/protocol/codec/buffer.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn push_front(&mut self, value: B) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Error` [INFO] [stderr] --> src/protocol/codec/writer.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | Error, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_watermarks` [INFO] [stderr] --> src/protocol/codec/writer.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn set_watermarks(&mut self, high: usize, low: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_and_flush` [INFO] [stderr] --> src/protocol/codec/writer.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn write_and_flush(&mut self, data: Bytes) -> Poll<(), std::io::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/connection.rs:106:55 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn get_stream_state_mut(&mut self, stream_id: &StreamId) -> Option<&mut StreamState> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `StreamId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/connection.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / match self.stream_states.get_mut(&stream_id) { [INFO] [stderr] 129 | | Some(_) => return Err(ConnectionError::InvalidStreamId), [INFO] [stderr] 130 | | None => (), [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = self.stream_states.get_mut(&stream_id) { return Err(ConnectionError::InvalidStreamId) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/connection.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | / loop { [INFO] [stderr] 392 | | match self.poll_read_progress() { [INFO] [stderr] 393 | | Ok(Async::Ready(())) => { [INFO] [stderr] 394 | | return Ok(Async::Ready(())); [INFO] [stderr] ... | [INFO] [stderr] 420 | | } [INFO] [stderr] 421 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/protocol/codec/reader.rs:39:60 [INFO] [stderr] | [INFO] [stderr] 39 | let bytes_res = try_ready!(self.src.poll().map_err(|err| FramingError::Io(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FramingError::Io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stream.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | / match ctx.get_stream_state_mut(&self.stream_id) { [INFO] [stderr] 213 | | Some(_) => return Err(()), // TODO StreamAlreadyExists [INFO] [stderr] 214 | | None => (), [INFO] [stderr] 215 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = ctx.get_stream_state_mut(&self.stream_id) { return Err(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `spaniel`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "612a9ffb1f825c931cf1ebe76608763d9cfa13778ae4e8447359ea039d06b9b2"` [INFO] running `"docker" "rm" "-f" "612a9ffb1f825c931cf1ebe76608763d9cfa13778ae4e8447359ea039d06b9b2"` [INFO] [stdout] 612a9ffb1f825c931cf1ebe76608763d9cfa13778ae4e8447359ea039d06b9b2