[INFO] crate spades 1.0.0 is already in cache
[INFO] extracting crate spades 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/spades/1.0.0
[INFO] extracting crate spades 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spades/1.0.0
[INFO] validating manifest of spades-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of spades-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing spades-1.0.0
[INFO] finished frobbing spades-1.0.0
[INFO] frobbed toml for spades-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/spades/1.0.0/Cargo.toml
[INFO] started frobbing spades-1.0.0
[INFO] finished frobbing spades-1.0.0
[INFO] frobbed toml for spades-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spades/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting spades-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spades/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 07a6b592fd62840579b68db42a8976549e1bb61f3173ab0e50228b1c5b7cf744
[INFO] running `"docker" "start" "-a" "07a6b592fd62840579b68db42a8976549e1bb61f3173ab0e50228b1c5b7cf744"`
[INFO] [stderr]     Checking spades v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scoring.rs:81:33
[INFO] [stderr]    |
[INFO] [stderr] 81 |             config: GameConfig {max_points: max_points},
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_points`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:97:13
[INFO] [stderr]    |
[INFO] [stderr] 97 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scoring.rs:81:33
[INFO] [stderr]    |
[INFO] [stderr] 81 |             config: GameConfig {max_points: max_points},
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_points`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:97:13
[INFO] [stderr]    |
[INFO] [stderr] 97 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scoring.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 |         return winner;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `winner`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cards.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     return winning_index;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `winning_index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cards.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 |     return cards;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `cards`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cards.rs:183:5
[INFO] [stderr]     |
[INFO] [stderr] 183 |     return hands;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `hands`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 |         return Err(GetError::InvalidUuid);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(GetError::InvalidUuid)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:226:21
[INFO] [stderr]     |
[INFO] [stderr] 226 |                     return Ok((&self.player_a.id, &self.player_c.id));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((&self.player_a.id, &self.player_c.id))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:228:21
[INFO] [stderr]     |
[INFO] [stderr] 228 |                     return Ok((&self.player_b.id, &self.player_d.id));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((&self.player_b.id, &self.player_d.id))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                         return Err(TransitionError::NotStarted); 
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::NotStarted)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:250:25
[INFO] [stderr]     |
[INFO] [stderr] 250 |                         return Err(TransitionError::BetInTrickStage);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::BetInTrickStage)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:253:25
[INFO] [stderr]     |
[INFO] [stderr] 253 |                         return Err(TransitionError::CompletedGame);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::CompletedGame)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:267:25
[INFO] [stderr]     |
[INFO] [stderr] 267 |                         return Ok(TransitionSuccess::Bet);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TransitionSuccess::Bet)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:274:25
[INFO] [stderr]     |
[INFO] [stderr] 274 |                         return Err(TransitionError::NotStarted); 
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::NotStarted)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:277:25
[INFO] [stderr]     |
[INFO] [stderr] 277 |                         return Err(TransitionError::CompletedGame);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::CompletedGame)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:280:25
[INFO] [stderr]     |
[INFO] [stderr] 280 |                         return Err(TransitionError::CardInBettingStage)
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::CardInBettingStage)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:324:29
[INFO] [stderr]     |
[INFO] [stderr] 324 |                             return Ok(TransitionSuccess::Trick);
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TransitionSuccess::Trick)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:328:29
[INFO] [stderr]     |
[INFO] [stderr] 328 |                             return Ok(TransitionSuccess::PlayCard);
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TransitionSuccess::PlayCard)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:339:17
[INFO] [stderr]     |
[INFO] [stderr] 339 |                 return Ok(TransitionSuccess::Start);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TransitionSuccess::Start)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `others`
[INFO] [stderr]    --> src/cards.rs:103:14
[INFO] [stderr]     |
[INFO] [stderr] 103 |     for i in 0..4 {
[INFO] [stderr]     |              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 103 |     for (i, <item>) in others.iter().enumerate().take(4) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/cards.rs:147:35
[INFO] [stderr]     |
[INFO] [stderr] 147 |             cards.push(Card {suit:s.clone(), rank:r.clone()});
[INFO] [stderr]     |                                   ^^^^^^^^^ help: try dereferencing it: `*s`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/cards.rs:147:51
[INFO] [stderr]     |
[INFO] [stderr] 147 |             cards.push(Card {suit:s.clone(), rank:r.clone()});
[INFO] [stderr]     |                                                   ^^^^^^^^^ help: try dereferencing it: `*r`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cards.rs:178:11
[INFO] [stderr]     |
[INFO] [stderr] 178 |     while cards.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cards.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/cards.rs:179:9
[INFO] [stderr]     |
[INFO] [stderr] 179 |         &hands[i].push(cards.pop().unwrap());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hands[i].push(cards.pop().unwrap());`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scoring.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 |         return winner;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `winner`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cards.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     return winning_index;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `winning_index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cards.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 |     return cards;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `cards`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cards.rs:183:5
[INFO] [stderr]     |
[INFO] [stderr] 183 |     return hands;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `hands`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 |         return Err(GetError::InvalidUuid);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(GetError::InvalidUuid)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:226:21
[INFO] [stderr]     |
[INFO] [stderr] 226 |                     return Ok((&self.player_a.id, &self.player_c.id));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((&self.player_a.id, &self.player_c.id))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:228:21
[INFO] [stderr]     |
[INFO] [stderr] 228 |                     return Ok((&self.player_b.id, &self.player_d.id));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((&self.player_b.id, &self.player_d.id))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                         return Err(TransitionError::NotStarted); 
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::NotStarted)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:250:25
[INFO] [stderr]     |
[INFO] [stderr] 250 |                         return Err(TransitionError::BetInTrickStage);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::BetInTrickStage)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:253:25
[INFO] [stderr]     |
[INFO] [stderr] 253 |                         return Err(TransitionError::CompletedGame);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::CompletedGame)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:267:25
[INFO] [stderr]     |
[INFO] [stderr] 267 |                         return Ok(TransitionSuccess::Bet);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TransitionSuccess::Bet)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:274:25
[INFO] [stderr]     |
[INFO] [stderr] 274 |                         return Err(TransitionError::NotStarted); 
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::NotStarted)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:277:25
[INFO] [stderr]     |
[INFO] [stderr] 277 |                         return Err(TransitionError::CompletedGame);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::CompletedGame)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:280:25
[INFO] [stderr]     |
[INFO] [stderr] 280 |                         return Err(TransitionError::CardInBettingStage)
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransitionError::CardInBettingStage)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:324:29
[INFO] [stderr]     |
[INFO] [stderr] 324 |                             return Ok(TransitionSuccess::Trick);
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TransitionSuccess::Trick)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:328:29
[INFO] [stderr]     |
[INFO] [stderr] 328 |                             return Ok(TransitionSuccess::PlayCard);
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TransitionSuccess::PlayCard)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:339:17
[INFO] [stderr]     |
[INFO] [stderr] 339 |                 return Ok(TransitionSuccess::Start);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TransitionSuccess::Start)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `others`
[INFO] [stderr]    --> src/cards.rs:103:14
[INFO] [stderr]     |
[INFO] [stderr] 103 |     for i in 0..4 {
[INFO] [stderr]     |              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 103 |     for (i, <item>) in others.iter().enumerate().take(4) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/cards.rs:147:35
[INFO] [stderr]     |
[INFO] [stderr] 147 |             cards.push(Card {suit:s.clone(), rank:r.clone()});
[INFO] [stderr]     |                                   ^^^^^^^^^ help: try dereferencing it: `*s`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/cards.rs:147:51
[INFO] [stderr]     |
[INFO] [stderr] 147 |             cards.push(Card {suit:s.clone(), rank:r.clone()});
[INFO] [stderr]     |                                                   ^^^^^^^^^ help: try dereferencing it: `*r`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cards.rs:178:11
[INFO] [stderr]     |
[INFO] [stderr] 178 |     while cards.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cards.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/cards.rs:179:9
[INFO] [stderr]     |
[INFO] [stderr] 179 |         &hands[i].push(cards.pop().unwrap());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hands[i].push(cards.pop().unwrap());`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/tests/spades_deck_unit.rs:13:13
[INFO] [stderr]    |
[INFO] [stderr] 13 |     let y = x[0].suit.clone();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `x[0].suit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/integration_tests.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return hand.iter().position(|ref x| x.suit == leading_suit).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hand.iter().position(|ref x| x.suit == leading_suit).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/integration_tests.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |         return 0;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> tests/integration_tests.rs:63:55
[INFO] [stderr]    |
[INFO] [stderr] 63 | pub fn get_valid_card_index(leading_suit: Suit, hand: &Vec<Card>) -> usize {
[INFO] [stderr]    |                                                       ^^^^^^^^^^ help: change this to: `&[Card]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.53s
[INFO] running `"docker" "inspect" "07a6b592fd62840579b68db42a8976549e1bb61f3173ab0e50228b1c5b7cf744"`
[INFO] running `"docker" "rm" "-f" "07a6b592fd62840579b68db42a8976549e1bb61f3173ab0e50228b1c5b7cf744"`
[INFO] [stdout] 07a6b592fd62840579b68db42a8976549e1bb61f3173ab0e50228b1c5b7cf744