[INFO] crate spaceralk 0.1.0 is already in cache
[INFO] extracting crate spaceralk 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/spaceralk/0.1.0
[INFO] extracting crate spaceralk 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spaceralk/0.1.0
[INFO] validating manifest of spaceralk-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of spaceralk-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing spaceralk-0.1.0
[INFO] finished frobbing spaceralk-0.1.0
[INFO] frobbed toml for spaceralk-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/spaceralk/0.1.0/Cargo.toml
[INFO] started frobbing spaceralk-0.1.0
[INFO] finished frobbing spaceralk-0.1.0
[INFO] frobbed toml for spaceralk-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spaceralk/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting spaceralk-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spaceralk/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3fa3302e752ac1cbc15ada7be78e83667ad486732cc684f6a8507ca6a2837d73
[INFO] running `"docker" "start" "-a" "3fa3302e752ac1cbc15ada7be78e83667ad486732cc684f6a8507ca6a2837d73"`
[INFO] [stderr]     Checking xml-rs v0.4.1
[INFO] [stderr]     Checking xmlrpc v0.4.1
[INFO] [stderr]     Checking spaceralk v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:33:17
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 url: url,
[INFO] [stderr]    |                 ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:34:17
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 username: username,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `username`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 password: password,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `password`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:33:17
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 url: url,
[INFO] [stderr]    |                 ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:34:17
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 username: username,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `username`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 password: password,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `password`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/lib.rs:73:32
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if self.authkey != String::from("") {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/lib.rs:74:17
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 self.call(String::from("auth.logout"), String::from("[]"));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:86:32
[INFO] [stderr]    |
[INFO] [stderr] 86 |     fn decode_json_array(jarr: &Vec<serde_json::Value>) -> xmlrpc::Value {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[serde_json::Value]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `jarr`.
[INFO] [stderr]   --> src/lib.rs:88:18
[INFO] [stderr]    |
[INFO] [stderr] 88 |         for i in 0..jarr.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 88 |         for <item> in &jarr {
[INFO] [stderr]    |             ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:96:9
[INFO] [stderr]     |
[INFO] [stderr] 96  | /         match jval {
[INFO] [stderr] 97  | |             &serde_json::Value::Number(ref item_val) => xmlrpc::Value::Int64(item_val.as_i64().unwrap()),
[INFO] [stderr] 98  | |             &serde_json::Value::String(ref item_val) => xmlrpc::Value::String(item_val.clone()),
[INFO] [stderr] 99  | |             &serde_json::Value::Null => xmlrpc::Value::Nil,
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |             _ => panic!("unhandeled value: {:?}", jval),
[INFO] [stderr] 103 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 96  |         match *jval {
[INFO] [stderr] 97  |             serde_json::Value::Number(ref item_val) => xmlrpc::Value::Int64(item_val.as_i64().unwrap()),
[INFO] [stderr] 98  |             serde_json::Value::String(ref item_val) => xmlrpc::Value::String(item_val.clone()),
[INFO] [stderr] 99  |             serde_json::Value::Null => xmlrpc::Value::Nil,
[INFO] [stderr] 100 |             serde_json::Value::Array(ref item_val) => decode_json_array(item_val),
[INFO] [stderr] 101 |             serde_json::Value::Bool(item_val) => xmlrpc::Value::Bool(item_val),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/lib.rs:73:32
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if self.authkey != String::from("") {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/lib.rs:74:17
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 self.call(String::from("auth.logout"), String::from("[]"));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:86:32
[INFO] [stderr]    |
[INFO] [stderr] 86 |     fn decode_json_array(jarr: &Vec<serde_json::Value>) -> xmlrpc::Value {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[serde_json::Value]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `jarr`.
[INFO] [stderr]   --> src/lib.rs:88:18
[INFO] [stderr]    |
[INFO] [stderr] 88 |         for i in 0..jarr.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 88 |         for <item> in &jarr {
[INFO] [stderr]    |             ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:96:9
[INFO] [stderr]     |
[INFO] [stderr] 96  | /         match jval {
[INFO] [stderr] 97  | |             &serde_json::Value::Number(ref item_val) => xmlrpc::Value::Int64(item_val.as_i64().unwrap()),
[INFO] [stderr] 98  | |             &serde_json::Value::String(ref item_val) => xmlrpc::Value::String(item_val.clone()),
[INFO] [stderr] 99  | |             &serde_json::Value::Null => xmlrpc::Value::Nil,
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |             _ => panic!("unhandeled value: {:?}", jval),
[INFO] [stderr] 103 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 96  |         match *jval {
[INFO] [stderr] 97  |             serde_json::Value::Number(ref item_val) => xmlrpc::Value::Int64(item_val.as_i64().unwrap()),
[INFO] [stderr] 98  |             serde_json::Value::String(ref item_val) => xmlrpc::Value::String(item_val.clone()),
[INFO] [stderr] 99  |             serde_json::Value::Null => xmlrpc::Value::Nil,
[INFO] [stderr] 100 |             serde_json::Value::Array(ref item_val) => decode_json_array(item_val),
[INFO] [stderr] 101 |             serde_json::Value::Bool(item_val) => xmlrpc::Value::Bool(item_val),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.23s
[INFO] running `"docker" "inspect" "3fa3302e752ac1cbc15ada7be78e83667ad486732cc684f6a8507ca6a2837d73"`
[INFO] running `"docker" "rm" "-f" "3fa3302e752ac1cbc15ada7be78e83667ad486732cc684f6a8507ca6a2837d73"`
[INFO] [stdout] 3fa3302e752ac1cbc15ada7be78e83667ad486732cc684f6a8507ca6a2837d73