[INFO] crate spaceapi-server 0.4.1 is already in cache
[INFO] extracting crate spaceapi-server 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/spaceapi-server/0.4.1
[INFO] extracting crate spaceapi-server 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spaceapi-server/0.4.1
[INFO] validating manifest of spaceapi-server-0.4.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of spaceapi-server-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing spaceapi-server-0.4.1
[INFO] finished frobbing spaceapi-server-0.4.1
[INFO] frobbed toml for spaceapi-server-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/spaceapi-server/0.4.1/Cargo.toml
[INFO] started frobbing spaceapi-server-0.4.1
[INFO] finished frobbing spaceapi-server-0.4.1
[INFO] frobbed toml for spaceapi-server-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spaceapi-server/0.4.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting spaceapi-server-0.4.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spaceapi-server/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9ef3fb17f600877fc54b6a38a5e4cc88dc9a1453be6e090cfbf3dd66aa7de124
[INFO] running `"docker" "start" "-a" "9ef3fb17f600877fc54b6a38a5e4cc88dc9a1453be6e090cfbf3dd66aa7de124"`
[INFO] [stderr]     Checking error-type v0.1.2
[INFO] [stderr]     Checking scheduled-thread-pool v0.1.0
[INFO] [stderr]     Checking redis v0.8.0
[INFO] [stderr]     Checking spaceapi v0.5.1
[INFO] [stderr]     Checking iron v0.5.1
[INFO] [stderr]     Checking r2d2 v0.7.4
[INFO] [stderr]     Checking persistent v0.3.0
[INFO] [stderr]     Checking router v0.5.1
[INFO] [stderr]     Checking r2d2_redis v0.6.0
[INFO] [stderr]     Checking bodyparser v0.5.0
[INFO] [stderr]     Checking urlencoded v0.5.0
[INFO] [stderr]     Checking spaceapi-server v0.4.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/handlers.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/handlers.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             redis_pool: redis_pool,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redis_pool`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/handlers.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             sensor_specs: sensor_specs,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sensor_specs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/handlers.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             status_modifiers: status_modifiers,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_modifiers`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server/handlers.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             redis_pool: redis_pool,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redis_pool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server/handlers.rs:134:13
[INFO] [stderr]     |
[INFO] [stderr] 134 |             sensor_specs: sensor_specs,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sensor_specs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/mod.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/mod.rs:67:65
[INFO] [stderr]    |
[INFO] [stderr] 67 |             sensors::SensorSpec { template: Box::new(template), data_key: data_key}
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/handlers.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/handlers.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             redis_pool: redis_pool,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redis_pool`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/handlers.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             sensor_specs: sensor_specs,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sensor_specs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/handlers.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             status_modifiers: status_modifiers,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_modifiers`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server/handlers.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             redis_pool: redis_pool,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redis_pool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server/handlers.rs:134:13
[INFO] [stderr]     |
[INFO] [stderr] 134 |             sensor_specs: sensor_specs,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sensor_specs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/mod.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/mod.rs:67:65
[INFO] [stderr]    |
[INFO] [stderr] 67 |             sensors::SensorSpec { template: Box::new(template), data_key: data_key}
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/server/handlers.rs:151:24
[INFO] [stderr]     |
[INFO] [stderr] 151 |         Response::with((status::NoContent))
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/server/handlers.rs:151:24
[INFO] [stderr]     |
[INFO] [stderr] 151 |         Response::with((status::NoContent))
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/server/handlers.rs:143:33
[INFO] [stderr]     |
[INFO] [stderr] 143 |                                .ok_or(sensors::SensorError::UnknownSensor(sensor.into())));
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| sensors::SensorError::UnknownSensor(sensor.into()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/server/handlers.rs:151:24
[INFO] [stderr]     |
[INFO] [stderr] 151 |         Response::with((status::NoContent))
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/server/handlers.rs:151:24
[INFO] [stderr]     |
[INFO] [stderr] 151 |         Response::with((status::NoContent))
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/modifiers.rs:18:47
[INFO] [stderr]    |
[INFO] [stderr] 18 |           let people_now_present: Option<u64> = status.sensors.as_ref()
[INFO] [stderr]    |  _______________________________________________^
[INFO] [stderr] 19 | |             .map(|sensors| sensors.people_now_present[0].value)
[INFO] [stderr] 20 | |             .into();
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]    |
[INFO] [stderr] 18 |         let people_now_present: Option<u64> = status.sensors.as_ref()
[INFO] [stderr] 19 |             .map(|sensors| sensors.people_now_present[0].value);
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/server/handlers.rs:143:33
[INFO] [stderr]     |
[INFO] [stderr] 143 |                                .ok_or(sensors::SensorError::UnknownSensor(sensor.into())));
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| sensors::SensorError::UnknownSensor(sensor.into()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/modifiers.rs:18:47
[INFO] [stderr]    |
[INFO] [stderr] 18 |           let people_now_present: Option<u64> = status.sensors.as_ref()
[INFO] [stderr]    |  _______________________________________________^
[INFO] [stderr] 19 | |             .map(|sensors| sensors.people_now_present[0].value)
[INFO] [stderr] 20 | |             .into();
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]    |
[INFO] [stderr] 18 |         let people_now_present: Option<u64> = status.sensors.as_ref()
[INFO] [stderr] 19 |             .map(|sensors| sensors.people_now_present[0].value);
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 32.25s
[INFO] running `"docker" "inspect" "9ef3fb17f600877fc54b6a38a5e4cc88dc9a1453be6e090cfbf3dd66aa7de124"`
[INFO] running `"docker" "rm" "-f" "9ef3fb17f600877fc54b6a38a5e4cc88dc9a1453be6e090cfbf3dd66aa7de124"`
[INFO] [stdout] 9ef3fb17f600877fc54b6a38a5e4cc88dc9a1453be6e090cfbf3dd66aa7de124