[INFO] crate spaceapi 0.6.0 is already in cache [INFO] extracting crate spaceapi 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/spaceapi/0.6.0 [INFO] extracting crate spaceapi 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spaceapi/0.6.0 [INFO] validating manifest of spaceapi-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spaceapi-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spaceapi-0.6.0 [INFO] finished frobbing spaceapi-0.6.0 [INFO] frobbed toml for spaceapi-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/spaceapi/0.6.0/Cargo.toml [INFO] started frobbing spaceapi-0.6.0 [INFO] finished frobbing spaceapi-0.6.0 [INFO] frobbed toml for spaceapi-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/spaceapi/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spaceapi-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/spaceapi/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8681966cfaa5dc81737e0cfad2a6428a73dd47f30eab674bbd729ae8585eb9f2 [INFO] running `"docker" "start" "-a" "8681966cfaa5dc81737e0cfad2a6428a73dd47f30eab674bbd729ae8585eb9f2"` [INFO] [stderr] Checking spaceapi v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sensors.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sensors.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/status.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/status.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | contact: contact, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `contact` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/status.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | issue_report_channels: issue_report_channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `issue_report_channels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/status.rs:422:21 [INFO] [stderr] | [INFO] [stderr] 422 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sensors.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sensors.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/status.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/status.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | contact: contact, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `contact` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/status.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | issue_report_channels: issue_report_channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `issue_report_channels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/status.rs:422:21 [INFO] [stderr] | [INFO] [stderr] 422 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/status.rs:427:24 [INFO] [stderr] | [INFO] [stderr] 427 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/status.rs:427:34 [INFO] [stderr] | [INFO] [stderr] 427 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/status.rs:427:24 [INFO] [stderr] | [INFO] [stderr] 427 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/status.rs:427:34 [INFO] [stderr] | [INFO] [stderr] 427 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/sensors.rs:22:48 [INFO] [stderr] | [INFO] [stderr] 22 | if value_str.parse::().map(|value|{ [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 23 | | let sensor = PeopleNowPresentSensor { [INFO] [stderr] 24 | | location: self.location.clone(), [INFO] [stderr] 25 | | name: self.name.clone(), [INFO] [stderr] ... | [INFO] [stderr] 31 | | sensors.people_now_present.push(sensor); [INFO] [stderr] 32 | | }).is_err() { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/sensors.rs:48:48 [INFO] [stderr] | [INFO] [stderr] 48 | if value_str.parse::().map(|value|{ [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 49 | | let sensor = TemperatureSensor { [INFO] [stderr] 50 | | unit: self.unit.clone(), [INFO] [stderr] 51 | | location: self.location.clone(), [INFO] [stderr] ... | [INFO] [stderr] 56 | | sensors.temperature.push(sensor); [INFO] [stderr] 57 | | }).is_err() { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/sensors.rs:22:48 [INFO] [stderr] | [INFO] [stderr] 22 | if value_str.parse::().map(|value|{ [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 23 | | let sensor = PeopleNowPresentSensor { [INFO] [stderr] 24 | | location: self.location.clone(), [INFO] [stderr] 25 | | name: self.name.clone(), [INFO] [stderr] ... | [INFO] [stderr] 31 | | sensors.people_now_present.push(sensor); [INFO] [stderr] 32 | | }).is_err() { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/sensors.rs:48:48 [INFO] [stderr] | [INFO] [stderr] 48 | if value_str.parse::().map(|value|{ [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 49 | | let sensor = TemperatureSensor { [INFO] [stderr] 50 | | unit: self.unit.clone(), [INFO] [stderr] 51 | | location: self.location.clone(), [INFO] [stderr] ... | [INFO] [stderr] 56 | | sensors.temperature.push(sensor); [INFO] [stderr] 57 | | }).is_err() { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.77s [INFO] running `"docker" "inspect" "8681966cfaa5dc81737e0cfad2a6428a73dd47f30eab674bbd729ae8585eb9f2"` [INFO] running `"docker" "rm" "-f" "8681966cfaa5dc81737e0cfad2a6428a73dd47f30eab674bbd729ae8585eb9f2"` [INFO] [stdout] 8681966cfaa5dc81737e0cfad2a6428a73dd47f30eab674bbd729ae8585eb9f2