[INFO] crate space_os 1.0.0 is already in cache [INFO] extracting crate space_os 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/space_os/1.0.0 [INFO] extracting crate space_os 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/space_os/1.0.0 [INFO] validating manifest of space_os-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of space_os-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing space_os-1.0.0 [INFO] finished frobbing space_os-1.0.0 [INFO] frobbed toml for space_os-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/space_os/1.0.0/Cargo.toml [INFO] started frobbing space_os-1.0.0 [INFO] finished frobbing space_os-1.0.0 [INFO] frobbed toml for space_os-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/space_os/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting space_os-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/space_os/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2556275e4aa9be29250dcb4040a3fa99e6832aa8862513649f3cc72c081d4b45 [INFO] running `"docker" "start" "-a" "2556275e4aa9be29250dcb4040a3fa99e6832aa8862513649f3cc72c081d4b45"` [INFO] [stderr] Checking libloading v0.5.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking stb_truetype v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking space_os v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:182:29 [INFO] [stderr] | [INFO] [stderr] 182 | / if !menu.onmenu{ [INFO] [stderr] 183 | | if level.meteors[i].pos_y > 570.0 { [INFO] [stderr] 184 | | level.check_level(&mut player); [INFO] [stderr] 185 | | //println!("{}", player.score); [INFO] [stderr] ... | [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | if !menu.onmenu && level.meteors[i].pos_y > 570.0 { [INFO] [stderr] 183 | level.check_level(&mut player); [INFO] [stderr] 184 | //println!("{}", player.score); [INFO] [stderr] 185 | level.meteors[i].pos_x = rng.gen_range(20, 570) as f64; [INFO] [stderr] 186 | level.meteors[i].pos_y = rng.gen_range(-650, -50) as f64; [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | return Glyphs::new(font, factory, TextureSettings::new()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Glyphs::new(font, factory, TextureSettings::new()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:301:14 [INFO] [stderr] | [INFO] [stderr] 301 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:300:18 [INFO] [stderr] | [INFO] [stderr] 300 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:299:22 [INFO] [stderr] | [INFO] [stderr] 299 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:298:26 [INFO] [stderr] | [INFO] [stderr] 298 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:312:14 [INFO] [stderr] | [INFO] [stderr] 312 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:311:18 [INFO] [stderr] | [INFO] [stderr] 311 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:310:22 [INFO] [stderr] | [INFO] [stderr] 310 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:309:26 [INFO] [stderr] | [INFO] [stderr] 309 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:405:14 [INFO] [stderr] | [INFO] [stderr] 405 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:404:18 [INFO] [stderr] | [INFO] [stderr] 404 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:403:22 [INFO] [stderr] | [INFO] [stderr] 403 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:402:26 [INFO] [stderr] | [INFO] [stderr] 402 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:416:14 [INFO] [stderr] | [INFO] [stderr] 416 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:415:18 [INFO] [stderr] | [INFO] [stderr] 415 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:414:22 [INFO] [stderr] | [INFO] [stderr] 414 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:413:26 [INFO] [stderr] | [INFO] [stderr] 413 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:428:9 [INFO] [stderr] | [INFO] [stderr] 428 | return Meteor {pos_y: rng.gen_range(-650, -50) as f64, pos_x: rng.gen_range(20, 570) as f64, vitesse: 2,texture: Texture::from_path(Path::new(&"assets/meteor.png"),&TextureSettings::new()).unwrap()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Meteor {pos_y: rng.gen_range(-650, -50) as f64, pos_x: rng.gen_range(20, 570) as f64, vitesse: 2,texture: Texture::from_path(Path::new(&"assets/meteor.png"),&TextureSettings::new()).unwrap()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:436:9 [INFO] [stderr] | [INFO] [stderr] 436 | return Image::new().rect(square(self.pos_x, self.pos_y, 70.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Image::new().rect(square(self.pos_x, self.pos_y, 70.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:444:9 [INFO] [stderr] | [INFO] [stderr] 444 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | / if (self.pos_x+60.0) > pos_x && self.pos_x < (pos_x+50.0){ [INFO] [stderr] 440 | | if (self.pos_y+60.0) > pos_y && self.pos_y < (pos_y+50.0){ [INFO] [stderr] 441 | | return true; [INFO] [stderr] 442 | | } [INFO] [stderr] 443 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 439 | if (self.pos_x+60.0) > pos_x && self.pos_x < (pos_x+50.0) && (self.pos_y+60.0) > pos_y && self.pos_y < (pos_y+50.0) { [INFO] [stderr] 440 | return true; [INFO] [stderr] 441 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | menu.images.get("background").unwrap().draw(menu.textures.get("background").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["background"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:114:65 [INFO] [stderr] | [INFO] [stderr] 114 | menu.images.get("background").unwrap().draw(menu.textures.get("background").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["background"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | menu.images.get("surcouche_on_play").unwrap().draw(menu.textures.get("surcouche_on_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["surcouche_on_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:116:76 [INFO] [stderr] | [INFO] [stderr] 116 | menu.images.get("surcouche_on_play").unwrap().draw(menu.textures.get("surcouche_on_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["surcouche_on_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | menu.images.get("surcouche_off_play").unwrap().draw(menu.textures.get("surcouche_off_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["surcouche_off_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:118:77 [INFO] [stderr] | [INFO] [stderr] 118 | menu.images.get("surcouche_off_play").unwrap().draw(menu.textures.get("surcouche_off_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["surcouche_off_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | menu.images.get("surcouche_on_quit").unwrap().draw(menu.textures.get("surcouche_on_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["surcouche_on_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:121:76 [INFO] [stderr] | [INFO] [stderr] 121 | menu.images.get("surcouche_on_quit").unwrap().draw(menu.textures.get("surcouche_on_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["surcouche_on_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | menu.images.get("surcouche_off_quit").unwrap().draw(menu.textures.get("surcouche_off_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["surcouche_off_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:123:77 [INFO] [stderr] | [INFO] [stderr] 123 | menu.images.get("surcouche_off_quit").unwrap().draw(menu.textures.get("surcouche_off_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["surcouche_off_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | gameover.images.get("background").unwrap().draw(gameover.textures.get("background").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["background"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:126:69 [INFO] [stderr] | [INFO] [stderr] 126 | gameover.images.get("background").unwrap().draw(gameover.textures.get("background").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["background"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | gameover.images.get("gameover_surcouche_on_play").unwrap().draw(gameover.textures.get("gameover_surcouche_on_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["gameover_surcouche_on_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:128:89 [INFO] [stderr] | [INFO] [stderr] 128 | gameover.images.get("gameover_surcouche_on_play").unwrap().draw(gameover.textures.get("gameover_surcouche_on_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["gameover_surcouche_on_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:130:25 [INFO] [stderr] | [INFO] [stderr] 130 | gameover.images.get("gameover_surcouche_off_play").unwrap().draw(gameover.textures.get("gameover_surcouche_off_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["gameover_surcouche_off_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:130:90 [INFO] [stderr] | [INFO] [stderr] 130 | gameover.images.get("gameover_surcouche_off_play").unwrap().draw(gameover.textures.get("gameover_surcouche_off_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["gameover_surcouche_off_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | gameover.images.get("gameover_surcouche_on_quit").unwrap().draw(gameover.textures.get("gameover_surcouche_on_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["gameover_surcouche_on_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:133:89 [INFO] [stderr] | [INFO] [stderr] 133 | gameover.images.get("gameover_surcouche_on_quit").unwrap().draw(gameover.textures.get("gameover_surcouche_on_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["gameover_surcouche_on_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | gameover.images.get("gameover_surcouche_off_quit").unwrap().draw(gameover.textures.get("gameover_surcouche_off_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["gameover_surcouche_off_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:135:90 [INFO] [stderr] | [INFO] [stderr] 135 | gameover.images.get("gameover_surcouche_off_quit").unwrap().draw(gameover.textures.get("gameover_surcouche_off_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["gameover_surcouche_off_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:58 [INFO] [stderr] | [INFO] [stderr] 146 | level.meteors[i].pos_x = rng.gen_range(20, 570) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(20, 570))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:58 [INFO] [stderr] | [INFO] [stderr] 147 | level.meteors[i].pos_y = rng.gen_range(-650, -50) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(-650, -50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:186:62 [INFO] [stderr] | [INFO] [stderr] 186 | level.meteors[i].pos_x = rng.gen_range(20, 570) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(20, 570))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:187:62 [INFO] [stderr] | [INFO] [stderr] 187 | level.meteors[i].pos_y = rng.gen_range(-650, -50) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(-650, -50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | for (_key, img) in &life.coeurs_i { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 194 | for img in life.coeurs_i.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | let ref font = assets.join(s); [INFO] [stderr] | ----^^^^^^^^------------------ help: try: `let font = &assets.join(s);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:290:33 [INFO] [stderr] | [INFO] [stderr] 290 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:394:33 [INFO] [stderr] | [INFO] [stderr] 394 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:428:31 [INFO] [stderr] | [INFO] [stderr] 428 | return Meteor {pos_y: rng.gen_range(-650, -50) as f64, pos_x: rng.gen_range(20, 570) as f64, vitesse: 2,texture: Texture::from_path(Path::new(&"assets/meteor.png"),&TextureSettings::new()).unwrap()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(-650, -50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:428:71 [INFO] [stderr] | [INFO] [stderr] 428 | return Meteor {pos_y: rng.gen_range(-650, -50) as f64, pos_x: rng.gen_range(20, 570) as f64, vitesse: 2,texture: Texture::from_path(Path::new(&"assets/meteor.png"),&TextureSettings::new()).unwrap()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(20, 570))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:461:33 [INFO] [stderr] | [INFO] [stderr] 461 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 490 | | match key { [INFO] [stderr] 491 | | Key::Up => { [INFO] [stderr] 492 | | self.up_d = true; [INFO] [stderr] ... | [INFO] [stderr] 504 | | } [INFO] [stderr] 505 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 489 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:508:9 [INFO] [stderr] | [INFO] [stderr] 508 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 509 | | match key { [INFO] [stderr] 510 | | Key::Up => { [INFO] [stderr] 511 | | self.up_d = false; [INFO] [stderr] ... | [INFO] [stderr] 523 | | } [INFO] [stderr] 524 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 508 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:182:29 [INFO] [stderr] | [INFO] [stderr] 182 | / if !menu.onmenu{ [INFO] [stderr] 183 | | if level.meteors[i].pos_y > 570.0 { [INFO] [stderr] 184 | | level.check_level(&mut player); [INFO] [stderr] 185 | | //println!("{}", player.score); [INFO] [stderr] ... | [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | if !menu.onmenu && level.meteors[i].pos_y > 570.0 { [INFO] [stderr] 183 | level.check_level(&mut player); [INFO] [stderr] 184 | //println!("{}", player.score); [INFO] [stderr] 185 | level.meteors[i].pos_x = rng.gen_range(20, 570) as f64; [INFO] [stderr] 186 | level.meteors[i].pos_y = rng.gen_range(-650, -50) as f64; [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | return Glyphs::new(font, factory, TextureSettings::new()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Glyphs::new(font, factory, TextureSettings::new()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:301:14 [INFO] [stderr] | [INFO] [stderr] 301 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:300:18 [INFO] [stderr] | [INFO] [stderr] 300 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:299:22 [INFO] [stderr] | [INFO] [stderr] 299 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:298:26 [INFO] [stderr] | [INFO] [stderr] 298 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:312:14 [INFO] [stderr] | [INFO] [stderr] 312 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:311:18 [INFO] [stderr] | [INFO] [stderr] 311 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:310:22 [INFO] [stderr] | [INFO] [stderr] 310 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:309:26 [INFO] [stderr] | [INFO] [stderr] 309 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:405:14 [INFO] [stderr] | [INFO] [stderr] 405 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:404:18 [INFO] [stderr] | [INFO] [stderr] 404 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:403:22 [INFO] [stderr] | [INFO] [stderr] 403 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:402:26 [INFO] [stderr] | [INFO] [stderr] 402 | }else{if self.play {self.play = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.play {self.play = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:416:14 [INFO] [stderr] | [INFO] [stderr] 416 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:415:18 [INFO] [stderr] | [INFO] [stderr] 415 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:414:22 [INFO] [stderr] | [INFO] [stderr] 414 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:413:26 [INFO] [stderr] | [INFO] [stderr] 413 | }else{if self.quit {self.quit = false;}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if self.quit {self.quit = false;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:428:9 [INFO] [stderr] | [INFO] [stderr] 428 | return Meteor {pos_y: rng.gen_range(-650, -50) as f64, pos_x: rng.gen_range(20, 570) as f64, vitesse: 2,texture: Texture::from_path(Path::new(&"assets/meteor.png"),&TextureSettings::new()).unwrap()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Meteor {pos_y: rng.gen_range(-650, -50) as f64, pos_x: rng.gen_range(20, 570) as f64, vitesse: 2,texture: Texture::from_path(Path::new(&"assets/meteor.png"),&TextureSettings::new()).unwrap()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:436:9 [INFO] [stderr] | [INFO] [stderr] 436 | return Image::new().rect(square(self.pos_x, self.pos_y, 70.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Image::new().rect(square(self.pos_x, self.pos_y, 70.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:444:9 [INFO] [stderr] | [INFO] [stderr] 444 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | / if (self.pos_x+60.0) > pos_x && self.pos_x < (pos_x+50.0){ [INFO] [stderr] 440 | | if (self.pos_y+60.0) > pos_y && self.pos_y < (pos_y+50.0){ [INFO] [stderr] 441 | | return true; [INFO] [stderr] 442 | | } [INFO] [stderr] 443 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 439 | if (self.pos_x+60.0) > pos_x && self.pos_x < (pos_x+50.0) && (self.pos_y+60.0) > pos_y && self.pos_y < (pos_y+50.0) { [INFO] [stderr] 440 | return true; [INFO] [stderr] 441 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | menu.images.get("background").unwrap().draw(menu.textures.get("background").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["background"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:114:65 [INFO] [stderr] | [INFO] [stderr] 114 | menu.images.get("background").unwrap().draw(menu.textures.get("background").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["background"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | menu.images.get("surcouche_on_play").unwrap().draw(menu.textures.get("surcouche_on_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["surcouche_on_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:116:76 [INFO] [stderr] | [INFO] [stderr] 116 | menu.images.get("surcouche_on_play").unwrap().draw(menu.textures.get("surcouche_on_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["surcouche_on_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | menu.images.get("surcouche_off_play").unwrap().draw(menu.textures.get("surcouche_off_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["surcouche_off_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:118:77 [INFO] [stderr] | [INFO] [stderr] 118 | menu.images.get("surcouche_off_play").unwrap().draw(menu.textures.get("surcouche_off_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["surcouche_off_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | menu.images.get("surcouche_on_quit").unwrap().draw(menu.textures.get("surcouche_on_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["surcouche_on_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:121:76 [INFO] [stderr] | [INFO] [stderr] 121 | menu.images.get("surcouche_on_quit").unwrap().draw(menu.textures.get("surcouche_on_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["surcouche_on_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | menu.images.get("surcouche_off_quit").unwrap().draw(menu.textures.get("surcouche_off_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.images["surcouche_off_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:123:77 [INFO] [stderr] | [INFO] [stderr] 123 | menu.images.get("surcouche_off_quit").unwrap().draw(menu.textures.get("surcouche_off_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&menu.textures["surcouche_off_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | gameover.images.get("background").unwrap().draw(gameover.textures.get("background").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["background"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:126:69 [INFO] [stderr] | [INFO] [stderr] 126 | gameover.images.get("background").unwrap().draw(gameover.textures.get("background").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["background"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | gameover.images.get("gameover_surcouche_on_play").unwrap().draw(gameover.textures.get("gameover_surcouche_on_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["gameover_surcouche_on_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:128:89 [INFO] [stderr] | [INFO] [stderr] 128 | gameover.images.get("gameover_surcouche_on_play").unwrap().draw(gameover.textures.get("gameover_surcouche_on_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["gameover_surcouche_on_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:130:25 [INFO] [stderr] | [INFO] [stderr] 130 | gameover.images.get("gameover_surcouche_off_play").unwrap().draw(gameover.textures.get("gameover_surcouche_off_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["gameover_surcouche_off_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:130:90 [INFO] [stderr] | [INFO] [stderr] 130 | gameover.images.get("gameover_surcouche_off_play").unwrap().draw(gameover.textures.get("gameover_surcouche_off_play").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["gameover_surcouche_off_play"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | gameover.images.get("gameover_surcouche_on_quit").unwrap().draw(gameover.textures.get("gameover_surcouche_on_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["gameover_surcouche_on_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:133:89 [INFO] [stderr] | [INFO] [stderr] 133 | gameover.images.get("gameover_surcouche_on_quit").unwrap().draw(gameover.textures.get("gameover_surcouche_on_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["gameover_surcouche_on_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | gameover.images.get("gameover_surcouche_off_quit").unwrap().draw(gameover.textures.get("gameover_surcouche_off_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.images["gameover_surcouche_off_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:135:90 [INFO] [stderr] | [INFO] [stderr] 135 | gameover.images.get("gameover_surcouche_off_quit").unwrap().draw(gameover.textures.get("gameover_surcouche_off_quit").unwrap(), &DrawState::new_alpha(), c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gameover.textures["gameover_surcouche_off_quit"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:58 [INFO] [stderr] | [INFO] [stderr] 146 | level.meteors[i].pos_x = rng.gen_range(20, 570) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(20, 570))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:58 [INFO] [stderr] | [INFO] [stderr] 147 | level.meteors[i].pos_y = rng.gen_range(-650, -50) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(-650, -50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:186:62 [INFO] [stderr] | [INFO] [stderr] 186 | level.meteors[i].pos_x = rng.gen_range(20, 570) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(20, 570))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:187:62 [INFO] [stderr] | [INFO] [stderr] 187 | level.meteors[i].pos_y = rng.gen_range(-650, -50) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(-650, -50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | for (_key, img) in &life.coeurs_i { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 194 | for img in life.coeurs_i.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | let ref font = assets.join(s); [INFO] [stderr] | ----^^^^^^^^------------------ help: try: `let font = &assets.join(s);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:290:33 [INFO] [stderr] | [INFO] [stderr] 290 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:394:33 [INFO] [stderr] | [INFO] [stderr] 394 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:428:31 [INFO] [stderr] | [INFO] [stderr] 428 | return Meteor {pos_y: rng.gen_range(-650, -50) as f64, pos_x: rng.gen_range(20, 570) as f64, vitesse: 2,texture: Texture::from_path(Path::new(&"assets/meteor.png"),&TextureSettings::new()).unwrap()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(-650, -50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:428:71 [INFO] [stderr] | [INFO] [stderr] 428 | return Meteor {pos_y: rng.gen_range(-650, -50) as f64, pos_x: rng.gen_range(20, 570) as f64, vitesse: 2,texture: Texture::from_path(Path::new(&"assets/meteor.png"),&TextureSettings::new()).unwrap()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(20, 570))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:461:33 [INFO] [stderr] | [INFO] [stderr] 461 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 490 | | match key { [INFO] [stderr] 491 | | Key::Up => { [INFO] [stderr] 492 | | self.up_d = true; [INFO] [stderr] ... | [INFO] [stderr] 504 | | } [INFO] [stderr] 505 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 489 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:508:9 [INFO] [stderr] | [INFO] [stderr] 508 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 509 | | match key { [INFO] [stderr] 510 | | Key::Up => { [INFO] [stderr] 511 | | self.up_d = false; [INFO] [stderr] ... | [INFO] [stderr] 523 | | } [INFO] [stderr] 524 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 508 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `"docker" "inspect" "2556275e4aa9be29250dcb4040a3fa99e6832aa8862513649f3cc72c081d4b45"` [INFO] running `"docker" "rm" "-f" "2556275e4aa9be29250dcb4040a3fa99e6832aa8862513649f3cc72c081d4b45"` [INFO] [stdout] 2556275e4aa9be29250dcb4040a3fa99e6832aa8862513649f3cc72c081d4b45