[INFO] crate space_email_api 0.2.0 is already in cache [INFO] extracting crate space_email_api 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/space_email_api/0.2.0 [INFO] extracting crate space_email_api 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/space_email_api/0.2.0 [INFO] validating manifest of space_email_api-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of space_email_api-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing space_email_api-0.2.0 [INFO] finished frobbing space_email_api-0.2.0 [INFO] frobbed toml for space_email_api-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/space_email_api/0.2.0/Cargo.toml [INFO] started frobbing space_email_api-0.2.0 [INFO] finished frobbing space_email_api-0.2.0 [INFO] frobbed toml for space_email_api-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/space_email_api/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting space_email_api-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/space_email_api/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48f569f36a3598b6297301796b525f38b2cea2295a15a38c964b5888a0f0e8cd [INFO] running `"docker" "start" "-a" "48f569f36a3598b6297301796b525f38b2cea2295a15a38c964b5888a0f0e8cd"` [INFO] [stderr] Checking tendril v0.3.1 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking space_email_api v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | const TEST_ID: u32 = 139244; [INFO] [stderr] | ^^^^^^ help: consider: `139_244` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/client.rs:148:93 [INFO] [stderr] | [INFO] [stderr] 148 | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %end, %Y at %I:%M%P")).or [INFO] [stderr] | _____________________________________________________________________________________________^ [INFO] [stderr] 149 | | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %erd, %Y at %I:%M%P")) [INFO] [stderr] | |___________________________________________________________________________________________^ help: try this: `or_else(|_| chrono::NaiveDateTime::parse_from_str(date, "%A, %b %erd, %Y at %I:%M%P"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/client.rs:147:93 [INFO] [stderr] | [INFO] [stderr] 147 | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %est, %Y at %I:%M%P")).or [INFO] [stderr] | _____________________________________________________________________________________________^ [INFO] [stderr] 148 | | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %end, %Y at %I:%M%P")).or [INFO] [stderr] | |___________________________________________________________________________________________^ help: try this: `or_else(|_| chrono::NaiveDateTime::parse_from_str(date, "%A, %b %end, %Y at %I:%M%P"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/client.rs:146:93 [INFO] [stderr] | [INFO] [stderr] 146 | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %eth, %Y at %I:%M%P")).or [INFO] [stderr] | _____________________________________________________________________________________________^ [INFO] [stderr] 147 | | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %est, %Y at %I:%M%P")).or [INFO] [stderr] | |___________________________________________________________________________________________^ help: try this: `or_else(|_| chrono::NaiveDateTime::parse_from_str(date, "%A, %b %est, %Y at %I:%M%P"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/data.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | pub(crate) fn into_id(&self) -> Option { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | pub(crate) fn into_id(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/data.rs:91:27 [INFO] [stderr] | [INFO] [stderr] 91 | pub(crate) fn into_id(&self) -> u32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:91:27 [INFO] [stderr] | [INFO] [stderr] 91 | pub(crate) fn into_id(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/client.rs:148:93 [INFO] [stderr] | [INFO] [stderr] 148 | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %end, %Y at %I:%M%P")).or [INFO] [stderr] | _____________________________________________________________________________________________^ [INFO] [stderr] 149 | | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %erd, %Y at %I:%M%P")) [INFO] [stderr] | |___________________________________________________________________________________________^ help: try this: `or_else(|_| chrono::NaiveDateTime::parse_from_str(date, "%A, %b %erd, %Y at %I:%M%P"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/client.rs:147:93 [INFO] [stderr] | [INFO] [stderr] 147 | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %est, %Y at %I:%M%P")).or [INFO] [stderr] | _____________________________________________________________________________________________^ [INFO] [stderr] 148 | | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %end, %Y at %I:%M%P")).or [INFO] [stderr] | |___________________________________________________________________________________________^ help: try this: `or_else(|_| chrono::NaiveDateTime::parse_from_str(date, "%A, %b %end, %Y at %I:%M%P"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/client.rs:146:93 [INFO] [stderr] | [INFO] [stderr] 146 | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %eth, %Y at %I:%M%P")).or [INFO] [stderr] | _____________________________________________________________________________________________^ [INFO] [stderr] 147 | | (chrono::NaiveDateTime::parse_from_str(date, "%A, %b %est, %Y at %I:%M%P")).or [INFO] [stderr] | |___________________________________________________________________________________________^ help: try this: `or_else(|_| chrono::NaiveDateTime::parse_from_str(date, "%A, %b %est, %Y at %I:%M%P"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/data.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | pub(crate) fn into_id(&self) -> Option { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | pub(crate) fn into_id(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/data.rs:91:27 [INFO] [stderr] | [INFO] [stderr] 91 | pub(crate) fn into_id(&self) -> u32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:91:27 [INFO] [stderr] | [INFO] [stderr] 91 | pub(crate) fn into_id(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.96s [INFO] running `"docker" "inspect" "48f569f36a3598b6297301796b525f38b2cea2295a15a38c964b5888a0f0e8cd"` [INFO] running `"docker" "rm" "-f" "48f569f36a3598b6297301796b525f38b2cea2295a15a38c964b5888a0f0e8cd"` [INFO] [stdout] 48f569f36a3598b6297301796b525f38b2cea2295a15a38c964b5888a0f0e8cd